From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 695931B6D2 for ; Mon, 23 Oct 2017 23:02:18 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2017 14:01:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,424,1503385200"; d="scan'208";a="1234295169" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.136]) ([10.241.225.136]) by fmsmga002.fm.intel.com with ESMTP; 23 Oct 2017 14:01:27 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , Matan Azrad Cc: dev@dpdk.org References: <1508423514-28557-1-git-send-email-matan@mellanox.com> <1508619286-7096-1-git-send-email-matan@mellanox.com> <20171023084613.GL3596@bidouze.vm.6wind.com> From: Ferruh Yigit Message-ID: Date: Mon, 23 Oct 2017 14:01:27 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171023084613.GL3596@bidouze.vm.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/failsafe: improve stats accuracy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 21:02:18 -0000 On 10/23/2017 1:46 AM, Gaëtan Rivet wrote: > Thanks Matan, > > On Sat, Oct 21, 2017 at 08:54:45PM +0000, Matan Azrad wrote: >> The stats_get API was changed to signal a potential failure to read >> stats. Furthermore, some PMDs are able to provide statistics even >> after a removal event occurred. >> >> Considering this, the fail-safe can try to access the latest >> statistics of a PMD to improve statistics accuracy. >> >> Attempt an ultimate statistics read on removal time; if that >> fails, use the latest recorded snapshot. >> >> Signed-off-by: Matan Azrad > Acked-by: Gaetan Rivet Series applied to dpdk-next-net/master, thanks. (Fixed build error for 32bits [1] while applying, please check.) [1] .../dpdk/drivers/net/failsafe/failsafe_ether.c: In function ‘fs_dev_stats_save’: .../dpdk/drivers/net/failsafe/failsafe_ether.c:328:50: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t {aka long long unsigned int}’ [-Werror=format=] (rte_rdtsc() - timestamp) / rte_get_tsc_hz()); ^ .../dpdk/i686-native-linuxapp-gcc/include/rte_log.h:345:25: note: in definition of macro ‘RTE_LOG’ RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__) ^ .../dpdk/drivers/net/failsafe/failsafe_private.h:299:26: note: in expansion of macro ‘LOG__’ #define LOG_(level, ...) LOG__(level, __VA_ARGS__, '\n') ^~~~~ .../dpdk/drivers/net/failsafe/failsafe_private.h:302:19: note: in expansion of macro ‘LOG_’ #define WARN(...) LOG_(WARNING, __VA_ARGS__) ^~~~ .../dpdk/drivers/net/failsafe/failsafe_ether.c:327:4: note: in expansion of macro ‘WARN’ WARN("Using latest snapshot taken before %lu seconds.\n", ^~~~