From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EBA8438F1; Thu, 18 Jan 2024 10:41:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7272F410F9; Thu, 18 Jan 2024 10:41:21 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 63096402B0 for ; Thu, 18 Jan 2024 10:41:08 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B6B9759; Thu, 18 Jan 2024 12:41:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B6B9759 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1705570867; bh=m2MJcKsdEOzdTJHcSkr8K+ov3ti7dqUavEqqNxM11HA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sTeFeVqNDtx1IMGQFsjxhlben9z1eKaAaLoF1L1cEyiC9cwVVatU//QIuH49Rj1gy ZqEXZTQaaIBsKM1mSUHOzxMkUVwNqBIGsN27dnYs0P3KhH9DCkfihZ/02xCEHX8hHj vifletaaAFNMD78pPeXUJowFj7/IJa/ipdPcdDQg= Message-ID: Date: Thu, 18 Jan 2024 12:41:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/6] mempool: avoid floating point expression in static assertion Content-Language: en-US To: =?UTF-8?Q?Morten_Br=C3=B8rup?= , Stephen Hemminger , dev@dpdk.org Cc: Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad References: <20231111172153.57461-1-stephen@networkplumber.org> <20240117182541.211125-1-stephen@networkplumber.org> <20240117182541.211125-6-stephen@networkplumber.org> <98CBD80474FA8B44BF855DF32C47DC35E9F171@smartserver.smartshare.dk> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F171@smartserver.smartshare.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/17/24 21:32, Morten Brørup wrote: >> From: Stephen Hemminger [mailto:stephen@networkplumber.org] >> Sent: Wednesday, 17 January 2024 19.20 >> >> Clang does not handle casts in static_assert() expressions. >> It doesn't like use of floating point to calculate threshold. >> Use a different expression with same effect. >> >> Modify comment in mlx5 so that developers don't go searching >> for old value. >> >> Signed-off-by: Stephen Hemminger > > Acked-by: Morten Brørup > Reviewed-by: Andrew Rybchenko