From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Pascal Mazon <pascal.mazon@6wind.com>, Ophir Munk <ophirmu@mellanox.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Olga Shern <olgas@mellanox.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/tap: fix flow and port commands
Date: Mon, 18 Sep 2017 20:35:55 +0100 [thread overview]
Message-ID: <aee3a1d2-af81-e97c-161e-64ebf1dc7b70@intel.com> (raw)
In-Reply-To: <30b8c47b-9f44-881e-ee71-7b6e2abc5da1@6wind.com>
On 9/18/2017 8:46 AM, Pascal Mazon wrote:
>
> On 17/09/2017 00:32, Ophir Munk wrote:
>> This commit fixes two bugs related to tap devices. The first bug occurs
>> when executing in testpmd the following flow rule assuming tap device has
>> 4 rx and tx pair queues
>> "flow create 0 ingress pattern eth / end actions queue index 5 / end"
>> This command will report on success and will print ""Flow rule #0 created"
>> although it should have failed as queue index number 5 does not exist
>>
>> The second bug occurs when executing in testpmd "port start all" following
>> a port configuration. Assuming 1 pair of rx and tx queues an error is
>> reported: "Fail to start port 0"
>>
>> Before this commit a fixed max number (16) of rx and tx queue pairs were
>> created on startup where the file descriptors (fds) of rx and tx pairs were
>> identical. As a result in the first bug queue index 5 existed because the
>> tap device was created with 16 rx and tx queue pairs regardless of the
>> configured number of queues. In the second bug when tap device was started
>> tx fd was closed before opening it and executing ioctl() on it. However
>> closing the sole fd of the device caused ioctl to fail with "No such
>> device".
>>
>> This commit creates the configured number of rx and tx queue pairs (up to
>> max 16) and assigns a unique fd to each queue. It was written to solve the
>> first bug and was found as the right fix for the second bug as well.
>>
>> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
>> Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing")
>> Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> Hi,
>
> Your reasons to keep *dev in pmd_internals are good enough for me!
>
> The rest of the patch looks fine.
>
> Acked-by: Pascal Mazon <pascal.mazon@6wind.com>
Applied to dpdk-next-net/master, thanks.
(Welcome Ophir!)
prev parent reply other threads:[~2017-09-18 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 10:48 [dpdk-dev] [PATCH] " Ophir Munk
2017-09-14 15:07 ` [dpdk-dev] [PATCH v2] " Ophir Munk
2017-09-15 7:31 ` Pascal Mazon
2017-09-16 22:32 ` [dpdk-dev] [PATCH v3] " Ophir Munk
2017-09-18 7:46 ` Pascal Mazon
2017-09-18 19:35 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aee3a1d2-af81-e97c-161e-64ebf1dc7b70@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=pascal.mazon@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).