From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 0D3181B471; Fri, 29 Jun 2018 17:16:25 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 14D9D4C0059; Fri, 29 Jun 2018 15:16:23 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Fri, 29 Jun 2018 16:16:17 +0100 To: Jerin Jacob , CC: , , References: <20180629094443.26540-1-jerin.jacob@caviumnetworks.com> From: Andrew Rybchenko Message-ID: Date: Fri, 29 Jun 2018 18:16:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180629094443.26540-1-jerin.jacob@caviumnetworks.com> Content-Language: en-US X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23936.003 X-TM-AS-Result: No--16.434400-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1530285384-z7PtnfaULvSl Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] ethdev: fix queue mapping documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 15:16:25 -0000 On 06/29/2018 12:44 PM, Jerin Jacob wrote: > The RTE_MAX_ETHPORT_QUEUE_STATS_MAPS does not exists, change > to the correct definition(RTE_ETHDEV_QUEUE_STAT_CNTRS) > > Fixes: 5de201df8927 ("ethdev: add stats per queue") > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob > --- > lib/librte_ethdev/rte_ethdev.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 36e3984ea..375ea24ce 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -2144,7 +2144,7 @@ void rte_eth_xstats_reset(uint16_t port_id); > * @param stat_idx > * The per-queue packet statistics functionality number that the transmit > * queue is to be assigned. > - * The value must be in the range [0, RTE_MAX_ETHPORT_QUEUE_STATS_MAPS - 1]. > + * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. > * @return > * Zero if successful. Non-zero otherwise. > */ > @@ -2164,7 +2164,7 @@ int rte_eth_dev_set_tx_queue_stats_mapping(uint16_t port_id, > * @param stat_idx > * The per-queue packet statistics functionality number that the receive > * queue is to be assigned. > - * The value must be in the range [0, RTE_MAX_ETHPORT_QUEUE_STATS_MAPS - 1]. > + * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. > * @return > * Zero if successful. Non-zero otherwise. > */ Reviewed-by: Andrew Rybchenko