From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FC8EA04AE; Tue, 5 May 2020 10:01:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C316C1D50C; Tue, 5 May 2020 10:01:20 +0200 (CEST) Received: from relay0124.mxlogin.com (relay0124.mxlogin.com [199.181.239.124]) by dpdk.org (Postfix) with ESMTP id F10A31D158 for ; Tue, 5 May 2020 10:01:18 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by relay0124.mxlogin.com (ZoneMTA) with ESMTPSA id 171e3da7113000167e.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 05 May 2020 08:01:16 +0000 X-Zone-Loop: 7404d697262ca6937edeb838f96bc83a2e3c7e4666fd X-Originating-IP: [149.28.56.236] Received: from galaxy.mxroute.com (unknown [23.92.70.113]) by filter004.mxroute.com (Postfix) with ESMTPS id 367613E9EF; Tue, 5 May 2020 08:01:10 +0000 (UTC) Received: from [192.198.151.44] by galaxy.mxroute.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1jVs5A-0006bK-DL; Tue, 05 May 2020 03:33:36 -0400 To: Jerin Jacob , Thomas Monjalon Cc: "Dumitrescu, Cristian" , Bruce Richardson , Ferruh Yigit , Luca Boccassi , Nithin Dabilpuram , "Singh, Jasvinder" , Andrew Rybchenko , "dev@dpdk.org" , "jerinj@marvell.com" , "kkanas@marvell.com" , Nithin Dabilpuram , "Kinsella, Ray" , Neil Horman , Kevin Traynor , David Marchand References: <20200330160019.29674-1-ndabilpuram@marvell.com> <20200428144535.GC1897@bricha3-MOBL.ger.corp.intel.com> <19c8b69f68bcdb7ac23126e63456223f7aff0465.camel@debian.org> <1923738.gORTcIGjah@thomas> From: Ray Kinsella Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: Date: Tue, 5 May 2020 09:01:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/05/2020 14:18, Jerin Jacob wrote: > On Tue, Apr 28, 2020 at 9:24 PM Thomas Monjalon wrote: >> >> 28/04/2020 17:04, Luca Boccassi: >>> On Tue, 2020-04-28 at 15:45 +0100, Bruce Richardson wrote: >>>> On Tue, Apr 28, 2020 at 03:06:20PM +0100, Ferruh Yigit wrote: >>>>> On 4/27/2020 5:59 PM, Jerin Jacob wrote: >>>>>> On Mon, Apr 27, 2020 at 10:19 PM Ferruh Yigit wrote: >>>>>>> On 4/27/2020 5:29 PM, Jerin Jacob wrote: >>>>>>>> On Mon, Apr 27, 2020 at 9:42 PM Ferruh Yigit wrote: >>>>>>>>> On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote: >>>>>>>>>> From: Yigit, Ferruh >>>>>>>>>>> On 4/24/2020 11:28 AM, Dumitrescu, Cristian wrote: >>>>>>>>>>>> From: Nithin Dabilpuram >>>>>>>>>>>>> This patch also updates tm port/level/node capability structures with >>>>>>>>>>>>> exiting features of scheduler wfq packet mode, scheduler wfq byte mode >>>>>>>>>>>>> and private/shared shaper byte mode. >>>>>>>>>>>>> >>>>>>>>>>>>> SoftNIC PMD is also updated with new capabilities. >> [...] >>>>>>>>>>> Hi Nithin, >>>>>>>>>>> >>>>>>>>>>> It looks like patch is causing ABI break, I am getting following warning [1], >>>>>>>>>>> can you please check? >>>>>>>>>>> >>>>>>>>>>> [1] >>>>>>>>>>> https://pastebin.com/XYNFg14u >>>>>>>>>> >>>>>>>>>> Hi Ferruh, >>>>>>>>>> >>>>>>>>>> The RTE_TM API is marked as experimental, >>>>>>>>>> but it looks that this was not correctly marked >>>>>>>>>> when __rte_experimental ABI checker was introduced. >>>>>>>>>> >>>>>>>>>> It is marked as experimental at the top of the rte_tm.h, >>>>>>>>>> similarly to other APIs introduced around same time, >>>>>>>>>> but it was not correctly picked up by the ABI check procedure >>>>>>>>>> when later introduced, so __rte_experimental was not added to every function. >>>>>>>>>> >>>>>>>>> >>>>>>>>> :( >>>>>>>>> >>>>>>>>> Is it time to mature them? >>>>>>>>> >>>>>>>>> As you said they are not marked as experimental both in header file (function >>>>>>>>> declarations) and .map file. >>>>>>>>> >>>>>>>>> The problem is, they are not marked as experimental in DPDK_20.0 ABI (v19.11), >>>>>>>>> so marking them as experimental now will break the ABI. Not sure what to do, >>>>>>>>> cc'ed a few ABI related names for comment. >>>>>>>>> >>>>>>>>> For me, we need to proceed as the experimental tag removed and APIs become >>>>>>>>> mature starting from v19.11, since this is what happened in practice, and remove >>>>>>>>> a few existing being experimental references in the doxygen comments. >>>>>>>> >>>>>>>> I think, accidentally we can not make a library as NON-experimental. >>>>>>>> TM never went through experimental to mature transition(see git log >>>>>>>> lib/librte_ethdev/rte_tm.h) >>>>>>>> It was a bug to not mark as experimental in each function in the ABI process. >>>>>>>> Some of the features like packet marking are not even implemented by any HW. >>>>>>>> I think, we can make API stable only all the features are implemented >>>>>>>> by one or two HW. >> >> Yes this is what was decided one or two years ago I think. >> But rte_tm API was introduced 3 years ago and is implemented by 6 PMDs. > > None of the 6 PMDS covers all the features. > >> >>>>> Existing experimental marks are text only for human parsing. >>>>> >>>>> The compiler attribute and build time checks are missing, and the symbol in the >>>>> binary doesn't have experimental tag. Our scripts and automated checks won't >>>>> detect it as experimental. >>>>> >>>>> My point is just having experimental comment in header file is not enough to >>>>> qualify the APIs as experimental. >>>>> >>>>>> Anyway, we need to break the ABI to make it work on various HW. >> >> Yes this is why I was asking in 19.11 to check our API, >> in order to avoid such situation. >> >> >>>>>> I am not sure what to do? >> >> Either manage ABI versioning, or wait 20.11. > > ABI change are in structures. So the function versioning does not > help. So we will wait for 20.11 then :-( > yes - I spent some time looking at this also, and came to same conclusion. Ray K