* Re: [dpdk-dev] [PATCH] net/iavf: fix port VLAN cfg err for AVF with SVM
2021-01-22 13:35 [dpdk-dev] [PATCH] net/iavf: fix port VLAN cfg err for AVF with SVM Junfeng Guo
@ 2021-01-22 6:12 ` Wang, Haiyue
2021-01-25 12:49 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Wang, Haiyue @ 2021-01-22 6:12 UTC (permalink / raw)
To: Guo, Junfeng, Zhang, Qi Z, Wu, Jingjing, Xing, Beilei; +Cc: dev, Zhang, Yuying
> -----Original Message-----
> From: Guo, Junfeng <junfeng.guo@intel.com>
> Sent: Friday, January 22, 2021 21:36
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Wang, Haiyue <haiyue.wang@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>; Guo,
> Junfeng <junfeng.guo@intel.com>
> Subject: [PATCH] net/iavf: fix port VLAN cfg err for AVF with SVM
>
> For AVF with single vlan mode (SVM), port vlan stripping config
> has already been disabled by PF. In this scenario, the error of
> -ENOTSUP can be ignored.
>
> Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities")
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> ---
> drivers/net/iavf/iavf_ethdev.c | 3 +++
> 1 file changed, 3 insertions(+)
Good catch, I missed this scenario handling. ;-)
Acked-by: Haiyue Wang <haiyue.wang@intel.com>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-dev] [PATCH] net/iavf: fix port VLAN cfg err for AVF with SVM
@ 2021-01-22 13:35 Junfeng Guo
2021-01-22 6:12 ` Wang, Haiyue
0 siblings, 1 reply; 3+ messages in thread
From: Junfeng Guo @ 2021-01-22 13:35 UTC (permalink / raw)
To: qi.z.zhang, jingjing.wu, beilei.xing
Cc: dev, haiyue.wang, yuying.zhang, junfeng.guo
For AVF with single vlan mode (SVM), port vlan stripping config
has already been disabled by PF. In this scenario, the error of
-ENOTSUP can be ignored.
Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities")
Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
---
drivers/net/iavf/iavf_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index cf6ea0b15..8175c7729 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1092,6 +1092,9 @@ iavf_dev_vlan_offload_set_v2(struct rte_eth_dev *dev, int mask)
enable = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP);
err = iavf_config_vlan_strip_v2(adapter, enable);
+ /* If not support, the stripping is already disabled by PF */
+ if (err == -ENOTSUP && !enable)
+ err = 0;
if (err)
return -EIO;
}
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/iavf: fix port VLAN cfg err for AVF with SVM
2021-01-22 6:12 ` Wang, Haiyue
@ 2021-01-25 12:49 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2021-01-25 12:49 UTC (permalink / raw)
To: Wang, Haiyue, Guo, Junfeng, Wu, Jingjing, Xing, Beilei; +Cc: dev, Zhang, Yuying
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Friday, January 22, 2021 2:12 PM
> To: Guo, Junfeng <junfeng.guo@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhang, Yuying <yuying.zhang@intel.com>
> Subject: RE: [PATCH] net/iavf: fix port VLAN cfg err for AVF with SVM
>
> > -----Original Message-----
> > From: Guo, Junfeng <junfeng.guo@intel.com>
> > Sent: Friday, January 22, 2021 21:36
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> > Cc: dev@dpdk.org; Wang, Haiyue <haiyue.wang@intel.com>; Zhang, Yuying
> > <yuying.zhang@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>
> > Subject: [PATCH] net/iavf: fix port VLAN cfg err for AVF with SVM
> >
> > For AVF with single vlan mode (SVM), port vlan stripping config has
> > already been disabled by PF. In this scenario, the error of -ENOTSUP
> > can be ignored.
> >
> > Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities")
> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > ---
> > drivers/net/iavf/iavf_ethdev.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> Good catch, I missed this scenario handling. ;-)
>
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-25 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-22 13:35 [dpdk-dev] [PATCH] net/iavf: fix port VLAN cfg err for AVF with SVM Junfeng Guo
2021-01-22 6:12 ` Wang, Haiyue
2021-01-25 12:49 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).