From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Igor Ryzhov <iryzhov@nfware.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [RFC] kni: remove ethtool support
Date: Mon, 18 Feb 2019 13:18:32 +0000 [thread overview]
Message-ID: <af366c71-327e-4d53-6462-0bbd9c962387@intel.com> (raw)
In-Reply-To: <CAF+s_Fzhb2j+XdSysQhjiDhp0M3=1KpR5e3DjqtM2-mKJ-WSTA@mail.gmail.com>
On 2/18/2019 1:07 PM, Igor Ryzhov wrote:
> Hi Ferruh,
>
> Thanks. Should I be a maintainer to ack the patch?
No, everyone can (n)ack a patch, though maintainers have more weight.
>
> Best regards,
> Igor
>
> On Mon, Feb 18, 2019 at 3:33 PM Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
>
> On 2/6/2019 1:12 PM, Igor Ryzhov wrote:
> > Hi Ferruh,
> >
> > What's the plan with this patch?
>
> Hi Igor,
>
> I just sent a deprecation notice for this:
> https://patches.dpdk.org/patch/50347/
>
> If the deprecation notice approved, requires 3 acks, note will go into 19.05
> And later this patch can go in 19.08
>
> Thanks,
> ferruh
>
> >
> > Best regards,
> > Igor
> >
> > On Sat, Jan 5, 2019 at 7:55 PM Igor Ryzhov <iryzhov@nfware.com
> <mailto:iryzhov@nfware.com>
> > <mailto:iryzhov@nfware.com <mailto:iryzhov@nfware.com>>> wrote:
> >
> > Hi Ferruh,
> >
> > I answered in another thread.
> >
> > Regarding this patch – I have no objections now.
> >
> > Best regards,
> > Igor
> >
> > On Tue, Dec 18, 2018 at 9:17 PM Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>
> > <mailto:ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>>> wrote:
> >
> > On 12/18/2018 9:20 AM, Ferruh Yigit wrote:
> > > On 12/18/2018 8:20 AM, Igor Ryzhov wrote:
> > >> Hi Ferruh,
> > >>
> > >> Please, look at my patch http://patches.dpdk.org/patch/48454/ and
> > consider
> > >> rebasing your patch over mine.
> > >
> > > Sorry about that, yes I will check it today.
> >
> > Hi Igor,
> >
> > I put some comments on your patch.
> >
> > As far as I can see it also has a target to remove current type of
> ethtool
> > support, so this RFC should not be a concern to you.
> > All ethtool support can be removed, when you have an actual
> solution for
> > driver
> > independent ethtool support only a little code needs to be added back.
> >
> > Thanks,
> > ferruh
> >
> > >
> > >>
> > >> As we discussed with Stephen, KNI needs to supply ethtool_ops with
> > >> .get_link function, to properly support link status.
> > >> So we should save ethtool_ops and implement .get_link using
> standard
> > >> ethtool_op_get_link.
> > >>
> > >> Best regards,
> > >> Igor
> > >
> > >
> >
>
next prev parent reply other threads:[~2019-02-18 13:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 1:25 Ferruh Yigit
2018-12-18 8:20 ` Igor Ryzhov
2018-12-18 9:20 ` Ferruh Yigit
2018-12-18 18:17 ` Ferruh Yigit
2019-01-05 16:55 ` Igor Ryzhov
2019-02-06 13:12 ` Igor Ryzhov
2019-02-18 12:33 ` Ferruh Yigit
2019-02-18 13:07 ` Igor Ryzhov
2019-02-18 13:18 ` Ferruh Yigit [this message]
2019-05-24 16:29 ` [dpdk-dev] [PATCH] " Ferruh Yigit
2019-05-24 16:46 ` Stephen Hemminger
2019-05-24 16:46 ` Ferruh Yigit
2019-05-24 16:55 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2019-05-24 19:27 ` Neil Horman
2019-05-29 21:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af366c71-327e-4d53-6462-0bbd9c962387@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).