From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id B3FB0201 for ; Thu, 2 Feb 2017 09:05:20 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id r141so76676133wmg.1 for ; Thu, 02 Feb 2017 00:05:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=Nn5bhpt7ikmVmsK35bwKuCQbEc4LJxuFgpRFbVexSU8=; b=1FI2g4C3HDAZYots2xpCwuMsEnVwu3xai/Ii72vv2Ws4NAG5dl9MXdf4jsJHE2ZRgm tGf1BdwnwW2Lle9DG/QDzPqOviyNglo+exDJPwzjoDYLkfMOZrzANo8Vbe4xfL0GrdFJ qHRaOjN8gLqoEKOfJUtuGJ9kxjm8dZVXnaCv/HvbWOOvMCzaPIOVnGmGSsq2RmhwFZP2 EZPavx4gmx7AXg6yUykv4+/NFbKlsbiNrGzaAYviQ/Cn9mQbernFaP/KDrobQT25s8O0 6NuqNuibDLYo+1s/bNRGQgEJo9jyy2AIPikNcsio5uywBboRwwygAOv4WyQB7dBmZGkv qj2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=Nn5bhpt7ikmVmsK35bwKuCQbEc4LJxuFgpRFbVexSU8=; b=Jvxy9LXNqpmb6YoE8DQ2GOYvjrpn74tLklV8FIcFWQej52KO9UzBA/gDZ+HLUSIodr qWjfmNjLRpn3usX3rgnHPqwexWLn2uo3INl3iSDioc3XpifEupZ/PUGS/PONxEWitVSc QZifsksjdJ6abROf3r9B8h/LBov56L/DurqX8bDhWmi34IsCQ7gg3bnHvOtNG1Uyfe9G 2JmG2E3O+vmDFUckEEmB1wDZ0id6kwTuyRZxDT6MXbT+IDJG3VF5mnj/3yo2uPRpsHDr mBxECK4JLx5k6F2N8CXavo8xCRsOtXwwUqe1Vwwf5paGcQzercDZT+aejyiuRQ3iuUkH bBeg== X-Gm-Message-State: AIkVDXKsa6llczVaSgI68b7LHg6INZvFPC43CW2p0zZmNMttt3JSpLzCFRs0/JmMqAXZ0FbJ X-Received: by 10.28.37.195 with SMTP id l186mr20413581wml.73.1486022719753; Thu, 02 Feb 2017 00:05:19 -0800 (PST) Received: from [10.16.0.184] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y65sm33892578wmb.5.2017.02.02.00.05.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Feb 2017 00:05:18 -0800 (PST) To: Ferruh Yigit , "Wiles, Keith" References: <1485855778-15496-1-git-send-email-pascal.mazon@6wind.com> <39a46c11-66c4-d8ed-a2bc-d9421cb4afd0@6wind.com> <9fa2c783-349c-e20c-0e57-0c24e67a4683@intel.com> <9C574760-33CF-4163-94D4-A0C919F4592C@intel.com> <74B7FC24-638D-4A48-A02D-C80B5B4E7E2B@intel.com> <78727e66-3588-79ab-6448-9858c19e2361@6wind.com> <8a13261b-215c-e294-1f61-b57e5ea998eb@6wind.com> <8D715219-BBBE-4484-8CB1-499C9DBE781A@intel.com> <5ee7a20c-9bd9-79f3-1ac9-b8d59ca837da@intel.com> Cc: "dev@dpdk.org" From: Pascal Mazon Message-ID: Date: Thu, 2 Feb 2017 09:05:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <5ee7a20c-9bd9-79f3-1ac9-b8d59ca837da@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/6] net/tap: use correct tap name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2017 08:05:20 -0000 On 02/01/2017 06:50 PM, Ferruh Yigit wrote: > On 2/1/2017 3:55 PM, Wiles, Keith wrote: >> >>> On Feb 1, 2017, at 9:40 AM, Pascal Mazon wrote: >>> >>> On 02/01/2017 04:25 PM, Wiles, Keith wrote: >>>> >>>>> On Feb 1, 2017, at 2:11 AM, Pascal Mazon wrote: >>>>> >>>>> On 02/01/2017 12:29 AM, Wiles, Keith wrote: >>>>>> >>>>>>> On Jan 31, 2017, at 10:39 AM, Pascal Mazon wrote: >>>>>>> >>>>>>> On 01/31/2017 05:06 PM, Wiles, Keith wrote:> >>>>>>>> Looking at the changes to set the link up/down and the adding the two functions. I noticed in the stop/start routines I was set the link in DPDK and not adjusting the interface link. Should the stop/start routine also do the same thing? >>>>>>>> >>>>>>> >>>>>>> Well, my patch is probably wrong. >>>>>>> The best option would probably be to set dev->data->dev_link.link_status >>>>>>> appropriately inside tap_link_set() only. >>>>>>> >>>>>>> I'm not sure it's compulsory to actually set the link UP in tap_dev_start() >>>>>>> (respectively DOWN in tap_dev_stop()). >>>>>>> If it is, however, it would be best done using tap_link_set() in those >>>>>>> functions. >>>>>> >>>>>> I was setting the link up/down in both places in the old code. The gotta is link up/down came later (I guess) and applications only call start/stop. In the other drivers like ring the like they tend to set link in start/stop and in link up/down, which is what I patterned my driver on. >>>>>> >>>>>> I looked around and the only applications calling link up/down was testpmd and ip_pipeline, but all of the apps call start/stop. Even the docs to not suggest that link up/down be used it appears start/stop must set the Link state and the developer can call link up/down APIs if needed for others reasons. >>>>>> >>>>>> I assume the link up/down only effects the link state and the start/stop is creating/destroying resources. >>>>>> >>>>>> My only solution I guess is to add the link up/down code to the start/stop API. >>>>> >>>>> I'm not sure I understand your conclusion. >>>>> If the apps usually call start/stop only, then definitely those functions should set the link state appropriately. >>>>> To that effect, I think it best to just call tap_link_set() in tap_dev_start() (and similar for stopping). >>>>> Apps with just start/stop functions would get the expected behavior, and the tap PMD would also support setting the link up/down independently, for testpmd and ip_pipeline for example. >>>>> >>>>> Does that sound fine? >>>> >>>> Yes, this was what I was trying to say and calling tap_link_set() in tap_dev_start() is the solution. >>> >>> Great, that looks good to me! >> >> Ferruh, Please apply Pascal’s 6 patches and I will based my changes on top of those changes. Does that sound reasonable? > > That is good, I will. > > Pascal, > > Only patch 1/6 commit log needs reworking, rest looks good, (although I > still will do one more round of basic tests). For commit log update, do > you want to send a v2 or prefer me do the update? I'd prefer if you did the update. Thank you! Pascal > > Thanks, > ferruh > >> >>> >>> Regards, >>> Pascal >> >> Regards, >> Keith >> >