From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Pallantla Poornima <pallantlax.poornima@intel.com>, dev@dpdk.org
Cc: reshma.pattan@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: fix sprintf with snprintf
Date: Thu, 7 Feb 2019 16:40:10 +0000 [thread overview]
Message-ID: <af7ea900-8e53-1237-3964-b53d1144c27a@intel.com> (raw)
In-Reply-To: <1549263758-32677-1-git-send-email-pallantlax.poornima@intel.com>
On 2/4/2019 7:02 AM, Pallantla Poornima wrote:
> sprintf function is not secure as it doesn't check the length of string.
> More secure function snprintf is used.
>
> Fixes: 3fc5ca2f63 ("kni: initial import")
> Fixes: b9ee370557 ("kni: update kernel driver ethtool baseline")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> ---
> kernel/linux/kni/ethtool/igb/igb_ethtool.c | 41 +++++++++++--------
> kernel/linux/kni/ethtool/igb/igb_main.c | 12 ++++--
> .../linux/kni/ethtool/ixgbe/ixgbe_ethtool.c | 30 ++++++++------
Overall updates looks good, but I am not sure if we need to update the kernel
drivers in KNI. At least *_ethtool.c ones shouldn't be called at all.
Any objection to skip these files from this patch?
next prev parent reply other threads:[~2019-02-07 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 7:02 Pallantla Poornima
2019-02-07 16:40 ` Ferruh Yigit [this message]
2019-02-07 18:01 ` Wiles, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af7ea900-8e53-1237-3964-b53d1144c27a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=pallantlax.poornima@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).