From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9FDED1B608 for ; Thu, 7 Feb 2019 20:28:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Feb 2019 11:28:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,345,1544515200"; d="scan'208";a="318506308" Received: from jlaghzal-mobl2.ger.corp.intel.com (HELO [10.252.8.49]) ([10.252.8.49]) by fmsmga005.fm.intel.com with ESMTP; 07 Feb 2019 11:28:53 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, Yipeng Wang , Sameh Gobriel , Bruce Richardson , Pablo de Lara References: <1549375057-4211-1-git-send-email-vladimir.medvedkin@intel.com> <1549375057-4211-2-git-send-email-vladimir.medvedkin@intel.com> <5937441.0T0pBNs0GK@xps> From: "Medvedkin, Vladimir" Message-ID: Date: Thu, 7 Feb 2019 19:28:52 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <5937441.0T0pBNs0GK@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 19:28:58 -0000 On 06/02/2019 10:38, Thomas Monjalon wrote: > 05/02/2019 14:57, Vladimir Medvedkin: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> +M: Vladimir Medvedkin >> +F: lib/librte_hash/rte_thash.h > I'm not sure about adding maintainership for one file. > You are the author of this file, so you should be consulted > during reviews if you don't catch them by yourself. > But I prefer seeing maintainers as taking charge and understanding of > a full library as a block. > > And unfortunately, it does not work with the script: > devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h > You would appear as maintainer for all hash files. It could be solved by adding header. In fact thash is not used by other parts of the hash library (instead it could be used by softnic for example). From my point of view, hash library consists of two parts, hash table itself and a number of hash functions. Hash functions, in turn, can be used for many other purposes, not just for a hash table. Maybe we should separate hash functions and hash table? And if you think it is a bad idea, so be it, 4 maintainers for hash is enough. > > >