DPDK patches and discussions
 help / color / mirror / Atom feed
From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Pavel Belous <Pavel.Belous@aquantia.com>,
	Igor Russkikh <Igor.Russkikh@aquantia.com>
Subject: [dpdk-dev] [PATCH 06/10] net/atlantic: fix eeprom fetching for small and uneven lengths
Date: Sat, 2 Mar 2019 12:10:52 +0000	[thread overview]
Message-ID: <afc2259673b7fc39a2c92670d5c4eb0f4db8d8fc.1551528549.git.igor.russkikh@aquantia.com> (raw)
In-Reply-To: <cover.1551528549.git.igor.russkikh@aquantia.com>

From: Pavel Belous <Pavel.Belous@aquantia.com>

Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: Pavel Belous <Pavel.Belous@aquantia.com>
---
 .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c   | 27 ++++++++++++++++---
 1 file changed, 23 insertions(+), 4 deletions(-)

diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c
index d0eb9f5e9..efa999268 100644
--- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c
+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c
@@ -531,13 +531,32 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, int dev_addr, u32 *data, u32
 		return err;
 
 	if (result == 0) {
-		err = hw_atl_utils_fw_downld_dwords(self,
+		u32 num_dwords = len / sizeof(u32);
+		u32 bytes_remains = len % sizeof(u32);
+
+		if (num_dwords) {
+			err = hw_atl_utils_fw_downld_dwords(self,
 				self->rpc_addr + sizeof(u32) * 2,
 				data,
-				RTE_ALIGN(len, sizeof(u32)));
+				num_dwords);
 
-		if (err < 0)
-			return err;
+			if (err < 0)
+				return err;
+		}
+
+		if (bytes_remains) {
+			u32 val = 0;
+
+			err = hw_atl_utils_fw_downld_dwords(self,
+				self->rpc_addr + sizeof(u32) * 2 + num_dwords,
+				&val,
+				sizeof(u32));
+
+			if (err < 0)
+				return err;
+
+			rte_memcpy((u8*)data + len - bytes_remains, &val, bytes_remains);
+		}
 	}
 
 	return 0;
-- 
2.17.1

  parent reply	other threads:[~2019-03-02 12:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-02 12:10 [dpdk-dev] [PATCH 00/10] net/atlantic: bugfixes and code cleanup Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 01/10] net/atlantic: Fix negative error codes Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 02/10] net/atlantic: remove unused variable Igor Russkikh
2019-03-04 21:22   ` Rami Rosen
2019-03-02 12:10 ` [dpdk-dev] [PATCH 03/10] net/atlantic: check for error codes Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 04/10] net/atlantic: fix buffer overflow Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 05/10] net/atlantic: use eeprom magic as a device address Igor Russkikh
2019-03-02 12:10 ` Igor Russkikh [this message]
2019-03-02 12:10 ` [dpdk-dev] [PATCH 07/10] net/atlantic: fix link configuration Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 08/10] net/atlantic: eliminate excessive log levels on rx/tx Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 09/10] net/atlantic: fix missing vlan filter offload Igor Russkikh
2019-03-02 12:11 ` [dpdk-dev] [PATCH 10/10] net/atlantic: fix xstats to return correct number of requested items Igor Russkikh
2019-03-04 21:12   ` Rami Rosen
2019-03-04  9:40 ` [dpdk-dev] [PATCH 00/10] net/atlantic: bugfixes and code cleanup David Marchand
2019-03-06 12:08   ` Igor Russkikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afc2259673b7fc39a2c92670d5c4eb0f4db8d8fc.1551528549.git.igor.russkikh@aquantia.com \
    --to=igor.russkikh@aquantia.com \
    --cc=Pavel.Belous@aquantia.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).