From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4CC243270; Thu, 2 Nov 2023 17:35:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F4F640262; Thu, 2 Nov 2023 17:35:51 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2054.outbound.protection.outlook.com [40.107.223.54]) by mails.dpdk.org (Postfix) with ESMTP id 648CF40144 for ; Thu, 2 Nov 2023 17:35:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HVpxMO/yR3cVRpYlw6jLiPrNwglNmqPjA7/vlbX53lBf4JAlk8ucd0WfjSNYErGz/7lgTBkXrWvknCCe23SGZ7YxKd+Rg2cUCJq8ddnN6vuZ9p/kgQovqsHIgtITK4/+VObyerbUsVFnLK42+k7p66S4+L+vm1fYrVMrW7CWO85BmRMLBAY5gzZkfo9nqP1wLREWaPCegmivMsNqnwbdeRABcyueqbXMHY9v/qW0SWcVX1K+f4aokOCWtJVjFj3hJWQLCNeb9GNR76pPFVQx68emtqwOtebYcCitA30OxJX3KQa1Y1BTcx5fpRMjORQhJ3wP9vMrHins15HYYI/Ehg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=InvJ3qFSh7De5xw37FKfD9tzWg5Nxwog9hLUEog8qbs=; b=fW7eRZOsRDjFJFvYr8WYLmNiMbHKWGjV+zXFNtm2YOU2toiHR7wS1zRDZuGIRKPsZXlM7RguHv6wUcya3dLEiw6f4IRKkPKouuyWbMdhlLFaSfQ+lzRJNMfwXe0W8Gy4EY/eZO30qTwiXrSIk11cxG4d6zrKNkA3QrsNPaU+Ql4mgx7D6qh7lWQi0pleTXTQi/PDl6f4yKMM7CIUV7zknhd1XNUuhz1kXlsMkxZoWOaZ725IWS9xsjb92Qgiihf5RNWAqMxHVqre1mZriS7OfjZ/9pZZvJVTOxjpW4XZ7XNtBWOrAbdHpYwpl3Q9gZ7IMf/kA8ZWGncb+PShJXNmHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=InvJ3qFSh7De5xw37FKfD9tzWg5Nxwog9hLUEog8qbs=; b=lrlmqV2VskqVVftOi8MyhtSZ7YUFhivwmEoSSzyZSsnpAeFRsoMctu/44zls5UrOW69b6ttM7KfkTc7FeWsBCiuD423HiXcXE2AF2t6gBwpV96ViAROTg1Bwz2rYzzPpOP+gA/Dk35yjGK1AFjfnr87XvEzqw0oB2gp8hggA8GA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Thu, 2 Nov 2023 16:35:46 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.019; Thu, 2 Nov 2023 16:35:46 +0000 Message-ID: Date: Thu, 2 Nov 2023 16:35:36 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] ethdev: introduce maximum Rx buffer size Content-Language: en-US To: Huisong Li , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko Cc: liuyonglong@huawei.com References: <20230808040234.12947-1-lihuisong@huawei.com> <20231102121608.10170-1-lihuisong@huawei.com> <20231102121608.10170-2-lihuisong@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231102121608.10170-2-lihuisong@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN2PR12MB4192:EE_ X-MS-Office365-Filtering-Correlation-Id: a065ae77-b1a4-46e4-3215-08dbdbc1c36e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YjKLVGi6oy6Sp9XbooGwIyX+rw1bzywxl/VIwfy85MVQ77Bz8XElaVZH7CLllvutyE2cISMLftP9OAsoCnkHbDepv9D9JytC6FwjQbgqrfcNFvSGzcuSn7Ge293m05iM2U7Go1ve0D5cya9LqmsnaGm+utPS9bPTMdouK4E3EgWSl9xwMIXuu2It/ne+cj8L+R5jbpVNpLE+MC/osuFZqdZ46V4VEq8OECzXX5BRuhz8Sq37vVi8Qn3bsitunRpac/XvHwD2b6mb467Y0JwGHvKYWnweg3SfA6vbUi+xPS/7QM0Qg2eAq5bf/ER+23bG4BrCS1XlD4oavgsOmXBCWdy4jCEMP7B+nXSeToiWeZufid+CFVnFLMMMR1CfPm33VesdgGL7CXfFNJwWua/mZa4QzYVtmdRc6XHxqx4W1dMcgrjoy8voszibU1Z0mT27r3TXfdCcQ9lcVTvUAnennoh+UbW8yVnTuB3PtFz5i4MDq+yYcVRVL+83eHi8Us7RxC/uxm9Ev1gzqAn/Vi3yQU4WR+L5Z1/Tf6IoOb1qg+iSwj2kfe7gyh9HlHMyKMIi2fmIu8jtVcOF6fTDBT7FefLavNvF20jrCGdJXmEurfVzT2JTdA01TTQdXcs63hvvW0Wc4sPc845clTMFvdEwRw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(346002)(136003)(366004)(396003)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(31686004)(6512007)(26005)(316002)(6506007)(38100700002)(36756003)(31696002)(2616005)(86362001)(2906002)(478600001)(44832011)(5660300002)(53546011)(6666004)(66574015)(66476007)(8676002)(8936002)(6486002)(4326008)(66946007)(83380400001)(41300700001)(110136005)(66556008)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SE50V09rMi9tM3ZJbHVXaC8vOHNEZ1NXQkZJajBoSXUxSFFUMnZRYjRqSGs1?= =?utf-8?B?bXRYYkMzdXl1SEFHMDFlZWw0RkhUaW1NaFV0cS9kSW1KWVdxVXhKV0JLTW5k?= =?utf-8?B?ZUNTMy9RUVBtSjRUN2Y1QW9mQ3laQmNmT2JtWm9sMUdZUG15amF5bzBLMTNa?= =?utf-8?B?eWQ4K1JNVHlrMGRHSGI3bDVjWEJ4OVhYbEdYMXFPeDhIVmUzaDN1SHRPbWQv?= =?utf-8?B?RnhzWVBqMGVGaWh1aEZwbThwUHVkcUtCZUFZK1ZQelN6dnN3VEhGZkRPcXZT?= =?utf-8?B?N0cxUm8xV1BnZFVXajgyZ3NCaHpYdFkzVnJWQkpROUtCcTRMR2QxSFVFcnhk?= =?utf-8?B?ZzZ5Z0JEcldjdk5iY1U2T3BzNFVSNzJHalRuY1QzbXBoUlBaNnFzWGdWRk5w?= =?utf-8?B?MkZ5YzB4dEJzN1huN1EwdERsSzFLNmxnSktsc2ZyMlBzTVZWbWl1QWZRZzBm?= =?utf-8?B?TURwaUwrYkFCV2QvSVlGaHBySzF4SGhBc2kzaFRXeDRsVnBwMEIxV0RKajhQ?= =?utf-8?B?WWlBVmQzSFBzKzd1RWU5bnByeGtRMkwxRDFFWVRYRC9seGY5dTd3Wis1Y1Nv?= =?utf-8?B?NWtESzZ5UGFtWlltWFVxbnN4RDNHU0kxRDJ6Unc2RWJKMGpNMTN3Tm4zcTNT?= =?utf-8?B?MDhoalFQQVlheURFd3RUSVFHdC8rb0N4dUNCV1dmdkE0WG11ZWg3dC8xOVI2?= =?utf-8?B?YlBEanZaQlJ5ZUxKOXdoS3VLSGhOUUlmN1hMOGZxYVJLK1BqRk1RbzZya0hX?= =?utf-8?B?bTNXNXdsV1UwSVR4a0FUQ3pxUCtWeS9oMXhMeGlFTkdJMUg5TkNvRWZFZmNi?= =?utf-8?B?Nk5uRTkveG9yVTMycnZ1L3dQRVFqRkFyTit5RXNpL1ppZ1VFUExWMEdpU1p6?= =?utf-8?B?SGNkSFR1dkJ1ZEYyNkEyaTlzdXBUM2N1RHBlM1FGZG9vUHp5c2U4T0RjOFRt?= =?utf-8?B?OVhsa3IvakI3b3M3NGZucnR3WG1VZEhtNFFZcGVKVk1MNGd5K1NaU0VJby8z?= =?utf-8?B?RWJ2VDBGUzFRenVoY1FzeFdkcDdnaUE2N3BaRDJiM05nazlTMW9ZQWd5YzQx?= =?utf-8?B?Z2F5bjhvaElWM01DUC9xdFhXSE5YWmFCRStXTDVUaFZCUVRvVGozYVlrZDJ6?= =?utf-8?B?NDFLcUR0RW12YVhrUnVOQlVTWVRCQjFwMmkvYSt3OWxhQS9XdXEraEc2RkFh?= =?utf-8?B?WFB2OXRuc2xsSzQzMG83TytXd3JVUFppTFJFV0FSZ3ZrV2RZK1EvaytpRFNp?= =?utf-8?B?bkx5VVRNQWxjZDlHK1FoUmpOYlRuWE5PWmtZWG9sVi9SbFZ5TnpMSVRCQ2xR?= =?utf-8?B?Z1Rpa2JoUEV6SE5WV05RelRaWW4wMWc2TTNtT3A0LzBoQ2pLYWdrbWJXdDdO?= =?utf-8?B?eTBzRmhrOXRkWEtPNEFEMU5zdG5KRXZpMnJyaWVabWd6ZmdwRnNQeUlZTmJZ?= =?utf-8?B?MWVoOWRNMHQxaGljOUFOZmRLOW1UZVVVZGRDbjZMRTVwOERuRDdNSFpBYW9s?= =?utf-8?B?T1h2cnp6T3pWMElDNkVPbnlTVFYvcXllZzg5d0Npc2dYeVpHL3RJY1BZcUlM?= =?utf-8?B?WXR3eUpsVkVhZTZGdEpoWkRYR3JtdEFPNDFvL2s4b1BDdm5ZQ2hGd1ZNOHBQ?= =?utf-8?B?Uk41OThpQnlUSllmeExTSlQwK3ZRQVdLdFVJV0syYW1wSWVkeGpLSllRQVY0?= =?utf-8?B?ZUdZbStJc1Jpd2xzR1Ricnh1QVVCVFpvTUZqMkM3T2R4NWpLKysvZi80SDM0?= =?utf-8?B?NEFxRllpRUJGV21jWGs5TzVtd041ak4zeE9qRGh6bWJxQ3NrQWFtZVVPOVVG?= =?utf-8?B?Q2hhN2FZRS85ZG1xZjdwUTZ2TlJOQ0lySi9yMGJTY0xFcVZKSWMyY2U4enp6?= =?utf-8?B?L0FuREwyTnNIOHNRL0p1ckR0dHBMVVQ2RDdkSTg3Mm5pMzNlcWdpNzhKLzhV?= =?utf-8?B?VTY1SjZSVy9CZDdCV0cwTnI2Nk9PUkl0ZkY0ckl2Qjd6UjVHV2NSMlJ3QnB5?= =?utf-8?B?bWJ3MGxNYzNhOGlRdkVCRVcxVGJhU2IrSVE4V3FaVzlpaU5PNzBndjMyVTRL?= =?utf-8?B?cXpPUUpYUThzdDlTK1JRMkRZYlJNaWZJOGlkQ3hwTHNKT01ZZER3L2xxQkZa?= =?utf-8?Q?Fo7FNImMKm1lGcCdF+igtTL+n?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a065ae77-b1a4-46e4-3215-08dbdbc1c36e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 16:35:45.9527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yYlKQ7qQqfnpoW9k1EzgAh+vCfdnGCceX8b3OF5VhWQTzksS4HJQ6Vg0rgQ68GWa X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4192 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/2/2023 12:16 PM, Huisong Li wrote: > The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum > Rx buffer size supported by hardware. Actually, some engines also have > the maximum Rx buffer specification, like, hns3, i40e and so on. If mbuf > data room size in mempool is greater then the maximum Rx buffer size > per descriptor supported by HW, the data size application used in each > mbuf is just as much as the maximum Rx buffer size instead of the whole > data room size. > > So introduce maximum Rx buffer size which is not enforced just to > report user to avoid memory waste. In addition, fix the comment for > the "min_rx_bufsize" to make it be more specific. > > Signed-off-by: Huisong Li > Acked-by: Chengwen Feng > Acked-by: Morten Brørup > --- > doc/guides/rel_notes/release_23_11.rst | 7 +++++++ > lib/ethdev/rte_ethdev.c | 7 +++++++ > lib/ethdev/rte_ethdev.h | 10 +++++++++- > 3 files changed, 23 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst > index 95db98d098..d4f7d5b266 100644 > --- a/doc/guides/rel_notes/release_23_11.rst > +++ b/doc/guides/rel_notes/release_23_11.rst > @@ -122,6 +122,13 @@ New Features > a group's miss actions, which are the actions to be performed on packets > that didn't match any of the flow rules in the group. > > +* **Added maximum Rx buffer size to report.** > + > + Introduced the ``max_rx_bufsize`` field representing the maximum Rx > + buffer size per descriptor supported by HW in structure ``rte_eth_dev_info`` > + to report user and to avoid wasting space of mempool. > + Its value is UINT32_MAX if driver doesn't report it. > + > * **Updated Amazon ena (Elastic Network Adapter) net driver.** > > * Upgraded ENA HAL to latest version. > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index af23ac0ad0..03539bb6c3 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -2112,6 +2112,7 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, > struct rte_eth_dev *dev; > struct rte_eth_dev_info dev_info; > struct rte_eth_rxconf local_conf; > + uint32_t vld_bufsize; > I guess 'vld' is valid, but that is not accurate. Can we rename it something like 'buf_data_size'? > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > dev = &rte_eth_devices[port_id]; > @@ -2158,6 +2159,11 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, > return ret; > > mbp_buf_size = rte_pktmbuf_data_room_size(mp); > + vld_bufsize = mbp_buf_size - RTE_PKTMBUF_HEADROOM; > + if (vld_bufsize > dev_info.max_rx_bufsize) > + RTE_ETHDEV_LOG(INFO, > + "For port_id=%u the max data size per mbuf in Rx is %u instead of the whole data room(%u).\n", > + port_id, dev_info.max_rx_bufsize, vld_bufsize); > This log gives some information, but it is not clear what user should do. My concern is this can confuse end users (not developers but users of dpdk application). Since audience of this message is DPDK application developer, most of the times end user don't have anything to do with this log, what do you think to change log level to 'debug'? Also can we add some action to it, something like: "mbuf data buffer size is bigger than what device can utilize, consider reducing mbuf size." > } else if (rx_conf != NULL && rx_conf->rx_nseg > 0) { > const struct rte_eth_rxseg_split *rx_seg; > uint16_t n_seg; > @@ -3757,6 +3763,7 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) > dev_info->min_mtu = RTE_ETHER_MIN_LEN - RTE_ETHER_HDR_LEN - > RTE_ETHER_CRC_LEN; > dev_info->max_mtu = UINT16_MAX; > + dev_info->max_rx_bufsize = UINT32_MAX; > > if (*dev->dev_ops->dev_infos_get == NULL) > return -ENOTSUP; > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index a53dd5a1ef..7133b73d26 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -1723,7 +1723,15 @@ struct rte_eth_dev_info { > uint16_t min_mtu; /**< Minimum MTU allowed */ > uint16_t max_mtu; /**< Maximum MTU allowed */ > const uint32_t *dev_flags; /**< Device flags */ > - uint32_t min_rx_bufsize; /**< Minimum size of Rx buffer. */ > + /** Minimum Rx buffer size per descriptor supported by HW. */ > + uint32_t min_rx_bufsize; > + /** > + * Maximum Rx buffer size per descriptor supported by HW. > + * The value is not enforced, information only to application to > + * optimize mbuf size. Its value is UINT32_MAX when not specified > + * by the driver. > + */ > + uint32_t max_rx_bufsize; > uint32_t max_rx_pktlen; /**< Maximum configurable length of Rx pkt. */ > /** Maximum configurable size of LRO aggregated packet. */ > uint32_t max_lro_pkt_size;