From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EX13-EDG-OU-002.vmware.com (ex13-edg-ou-002.vmware.com [208.91.0.190]) by dpdk.org (Postfix) with ESMTP id 158CC234 for ; Wed, 15 Mar 2017 19:30:04 +0100 (CET) Received: from sc9-mailhost3.vmware.com (10.113.161.73) by EX13-EDG-OU-002.vmware.com (10.113.208.156) with Microsoft SMTP Server id 15.0.1156.6; Wed, 15 Mar 2017 11:29:31 -0700 Received: from shri-linux.eng.vmware.com (shri-linux.eng.vmware.com [10.33.72.16]) by sc9-mailhost3.vmware.com (Postfix) with ESMTP id 935A5403CD; Wed, 15 Mar 2017 11:30:03 -0700 (PDT) Date: Wed, 15 Mar 2017 11:30:03 -0700 From: Shrikrishna Khare To: Yong Wang CC: "Charles (Chas) Williams" , "dev@dpdk.org" , Shrikrishna Khare In-Reply-To: Message-ID: References: <1489444915-3660-1-git-send-email-ciwillia@brocade.com> <1489581310-26094-1-git-send-email-ciwillia@brocade.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Received-SPF: None (EX13-EDG-OU-002.vmware.com: skhare@shri-linux.eng.vmware.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 18:30:05 -0000 On Wed, 15 Mar 2017, Yong Wang wrote: > > -----Original Message----- > > From: Charles (Chas) Williams [mailto:ciwillia@brocade.com] > > Sent: Wednesday, March 15, 2017 5:35 AM > > To: dev@dpdk.org > > Cc: Yong Wang ; Charles (Chas) Williams > > > > Subject: [PATCH] net/vmxnet3: fix queue size changes > > > > If the user reconfigures the queue size, then the previously allocated > > memzone may potentially be too small.  Release the memzone when a > > queue > > is released and allocate a new one each time a queue is setup. > > > > While here convert to rte_eth_dma_zone_reserve() which does basically > > the same things as the private function. > > > > Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver > > implementation") > > > > Signed-off-by: Chas Williams > > --- > > Looks good to me and cc-ing Shrikrishna, the new vmxnet3 pmd maintainer. Looks good to me too. Acked-by: Shrikrishna Khare