DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 6/6] net/vmxnet3: preserve configured MAC address
@ 2017-05-19 18:01 Charles (Chas) Williams
  2017-05-22 18:33 ` Shrikrishna Khare
  0 siblings, 1 reply; 2+ messages in thread
From: Charles (Chas) Williams @ 2017-05-19 18:01 UTC (permalink / raw)
  To: dev; +Cc: skhare, George Wilkie

From: George Wilkie <gwilkie@brocade.com>

When starting a vmxnet3 device, it is always writing the permanent MAC
address, even if a different MAC address was configured.  Write from
the device data instead which holds the current one.

Signed-off-by: George Wilkie <gwilkie@brocade.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index d241499..2e80cb1 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -734,7 +734,7 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
 	vmxnet3_dev_vlan_offload_set(dev,
 				     ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK);
 
-	vmxnet3_write_mac(hw, hw->perm_addr);
+	vmxnet3_write_mac(hw, dev->data->mac_addrs->addr_bytes);
 
 	return VMXNET3_SUCCESS;
 }
-- 
2.1.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH 6/6] net/vmxnet3: preserve configured MAC address
  2017-05-19 18:01 [dpdk-dev] [PATCH 6/6] net/vmxnet3: preserve configured MAC address Charles (Chas) Williams
@ 2017-05-22 18:33 ` Shrikrishna Khare
  0 siblings, 0 replies; 2+ messages in thread
From: Shrikrishna Khare @ 2017-05-22 18:33 UTC (permalink / raw)
  To: Charles (Chas) Williams; +Cc: dev, skhare, George Wilkie



On Fri, 19 May 2017, Charles (Chas) Williams wrote:

> From: George Wilkie <gwilkie@brocade.com>
> 
> When starting a vmxnet3 device, it is always writing the permanent MAC
> address, even if a different MAC address was configured.  Write from
> the device data instead which holds the current one.
> 
> Signed-off-by: George Wilkie <gwilkie@brocade.com>

Acked-by: Shrikrishna Khare <skhare@vmware.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-05-22 18:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-19 18:01 [dpdk-dev] [PATCH 6/6] net/vmxnet3: preserve configured MAC address Charles (Chas) Williams
2017-05-22 18:33 ` Shrikrishna Khare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).