From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EX13-EDG-OU-002.vmware.com (ex13-edg-ou-002.vmware.com [208.91.0.190]) by dpdk.org (Postfix) with ESMTP id 590409139 for ; Wed, 24 May 2017 23:09:45 +0200 (CEST) Received: from sc9-mailhost3.vmware.com (10.113.161.73) by EX13-EDG-OU-002.vmware.com (10.113.208.156) with Microsoft SMTP Server id 15.0.1156.6; Wed, 24 May 2017 14:09:37 -0700 Received: from shri-linux.eng.vmware.com (shri-linux.eng.vmware.com [10.33.72.16]) by sc9-mailhost3.vmware.com (Postfix) with ESMTP id AFAD140704; Wed, 24 May 2017 14:09:43 -0700 (PDT) Date: Wed, 24 May 2017 14:09:40 -0700 From: Shrikrishna Khare To: "Charles (Chas) Williams" CC: , , Nachiketa Prachanda In-Reply-To: <1495216560-12920-1-git-send-email-ciwillia@brocade.com> Message-ID: References: <1495216560-12920-1-git-send-email-ciwillia@brocade.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Received-SPF: None (EX13-EDG-OU-002.vmware.com: skhare@shri-linux.eng.vmware.com does not designate permitted sender hosts) Subject: Re: [dpdk-dev] [PATCH 1/6] net/vmxnet3: retain counters on restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2017 21:09:45 -0000 On Fri, 19 May 2017, Charles (Chas) Williams wrote: > From: Nachiketa Prachanda > > Most nics like virtio, igb/ixgbe etc. don't reset counters on > dev_start and arguably this helps in monitoring the counters > across a longer time span with multiple device start/stops. > vmxnet3 behavior is opposite to that and counters are reset by > the host side implementation each time the device is restarted. > > Change the driver to save the counters in its private context > before it is reset by writing CMD_ACTIVATE to REG_CMD. > > Signed-off-by: Nachiketa Prachanda This won't be able to deal with vMotion or suspend/resume?