From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <skhare@vmware.com>
Received: from EX13-EDG-OU-002.vmware.com (ex13-edg-ou-002.vmware.com
 [208.91.0.190]) by dpdk.org (Postfix) with ESMTP id B4D6B1B16F
 for <dev@dpdk.org>; Thu, 18 Jan 2018 07:04:24 +0100 (CET)
Received: from sc9-mailhost3.vmware.com (10.113.161.73) by
 EX13-EDG-OU-002.vmware.com (10.113.208.156) with Microsoft SMTP Server id
 15.0.1156.6; Wed, 17 Jan 2018 22:03:16 -0800
Received: from shri-linux.eng.vmware.com (shri-linux.eng.vmware.com
 [10.33.72.16])
 by sc9-mailhost3.vmware.com (Postfix) with ESMTP id E31C941E48;
 Wed, 17 Jan 2018 22:04:23 -0800 (PST)
Date: Wed, 17 Jan 2018 22:04:23 -0800
From: Shrikrishna Khare <skhare@shri-linux.eng.vmware.com>
To: <garwilkie@gmail.com>
CC: <skhare@vmware.com>, <dev@dpdk.org>, George Wilkie
 <george.wilkie@intl.att.com>
In-Reply-To: <1515585942-10720-1-git-send-email-george.wilkie@intl.att.com>
Message-ID: <alpine.DEB.2.10.1801172204070.12208@shri-linux.eng.vmware.com>
References: <1515585942-10720-1-git-send-email-george.wilkie@intl.att.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Received-SPF: None (EX13-EDG-OU-002.vmware.com:
 skhare@shri-linux.eng.vmware.com does not designate permitted sender hosts)
Subject: Re: [dpdk-dev] [PATCH] vmxnet3: set unknown packet_type for
	non-ipv4 packets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2018 06:04:25 -0000



On Wed, 10 Jan 2018, garwilkie@gmail.com wrote:

> From: George Wilkie <george.wilkie@intl.att.com>
> 
> With bonding, after sending sufficient ipv4 packets,
> bond_ethdev_rx_burst_8023ad() no longer recognizes LACP packets
> because the packet_type is set to RTE_PTYPE_L3_IPV4.
> Ensure packet_type is reset for non-ipv4 packets in vmxnet3_rx_offload.
> 
> Signed-off-by: George Wilkie <george.wilkie@intl.att.com>

Acked-by: Shrikrishna Khare <skhare@vmware.com>

> ---
>  drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> index f9416f3..abea641 100644
> --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> @@ -674,6 +674,8 @@ vmxnet3_rx_offload(const Vmxnet3_RxCompDesc *rcd, struct rte_mbuf *rxm)
>  			if ((rcd->tcp || rcd->udp) && !rcd->tuc)
>  				rxm->ol_flags |= PKT_RX_L4_CKSUM_BAD;
>  		}
> +	} else {
> +		rxm->packet_type = RTE_PTYPE_UNKNOWN;
>  	}
>  }
>  
> -- 
> 2.7.4
> 
>