From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00191d01.pphosted.com (mx0b-00191d01.pphosted.com [67.231.157.136]) by dpdk.org (Postfix) with ESMTP id 7598429CD for ; Thu, 20 Oct 2016 15:36:17 +0200 (CEST) Received: from pps.filterd (m0049458.ppops.net [127.0.0.1]) by m0049458.ppops.net-00191d01. (8.16.0.17/8.16.0.17) with SMTP id u9KDZWfU021150; Thu, 20 Oct 2016 09:36:16 -0400 Received: from alpi155.enaf.aldc.att.com (sbcsmtp7.sbc.com [144.160.229.24]) by m0049458.ppops.net-00191d01. with ESMTP id 266xqggudn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Oct 2016 09:36:16 -0400 Received: from enaf.aldc.att.com (localhost [127.0.0.1]) by alpi155.enaf.aldc.att.com (8.14.5/8.14.5) with ESMTP id u9KDaGqd016101; Thu, 20 Oct 2016 09:36:16 -0400 Received: from mlpi408.sfdc.sbc.com (mlpi408.sfdc.sbc.com [130.9.128.240]) by alpi155.enaf.aldc.att.com (8.14.5/8.14.5) with ESMTP id u9KDa9U1015952 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 20 Oct 2016 09:36:10 -0400 Received: from clpi183.sldc.sbc.com (clpi183.sldc.sbc.com [135.41.1.46]) by mlpi408.sfdc.sbc.com (RSA Interceptor); Thu, 20 Oct 2016 13:35:53 GMT Received: from sldc.sbc.com (localhost [127.0.0.1]) by clpi183.sldc.sbc.com (8.14.5/8.14.5) with ESMTP id u9KDZrbQ020620; Thu, 20 Oct 2016 08:35:53 -0500 Received: from mail-green.research.att.com (mail-green.research.att.com [135.207.255.15]) by clpi183.sldc.sbc.com (8.14.5/8.14.5) with ESMTP id u9KDZhLP019960; Thu, 20 Oct 2016 08:35:43 -0500 Received: from mt-230-10.research.att.com (mt-230-10.research.att.com [135.207.230.10]) by mail-green.research.att.com (Postfix) with ESMTP id 8ADBAE292E; Thu, 20 Oct 2016 09:35:33 -0400 (EDT) Date: Thu, 20 Oct 2016 09:35:44 -0400 (EDT) From: Scott Daniels To: "Lu, Wenzhuo" cc: "Zhang, Helin" , "Iremonger, Bernard" , "dev@dpdk.org" , "ZELEZNIAK, ALEX" In-Reply-To: Message-ID: References: <1476915787-28205-1-git-send-email-daniels@research.att.com> <1476915787-28205-2-git-send-email-daniels@research.att.com> <6A0DE07E22DDAD4C9103DF62FEBC09093933D40B@shsmsx102.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093933D428@shsmsx102.ccr.corp.intel.com> User-Agent: Alpine 2.20.12 (LSU 116 2015-12-14) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-RSA-Inspected: yes X-RSA-Classifications: public X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-10-20_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610200243 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2016 13:36:17 -0000 On Wed, 19 Oct 2016, DANIELS, EDWARD S (EDWARD) wrote: > *** Security Advisory: This Message Originated Outside of AT&T ***. > Reference http://cso.att.com/EmailSecurity/IDSP.html for more information. > > > > On Wed, 19 Oct 2016, Lu, Wenzhuo wrote: > >> Hi Scott, >> >>> -----Original Message----- >>> From: Scott Daniels [mailto:daniels@research.att.com] >>> Sent: Thursday, October 20, 2016 10:11 AM >>> To: Lu, Wenzhuo >>> Cc: Zhang, Helin; Iremonger, Bernard; dev@dpdk.org; ZELEZNIAK, ALEX >>> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list >>> >>> >>> >>> On Wed, 19 Oct 2016, Lu, Wenzhuo wrote: >>> >>>> Hi Scott, >>>> >>>>> -----Original Message----- >>>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of E. Scott Daniels >>>>> Sent: Thursday, October 20, 2016 6:23 AM >>>>> To: Zhang, Helin; Iremonger, Bernard >>>>> Cc: dev@dpdk.org; az5157@att.com; E. Scott Daniels >>>>> Subject: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on >>>>> list >>>>> >>>>> This change prevents the attempt to add a structure which is already >>>>> on the callback list. If a struct with matching parameters is found >>>>> on the list, then no action is taken. If a struct with matching >>>>> parameters is found on the list, then no action is taken. >>>>> >>>>> Signed-off-by: E. Scott Daniels >>>> I think the fix itself is good. But 2 things, 1, normally we don't >>>> create a cover letter for a patch set which only has one patch. Just sending the >>> patch itself is enough. >>>> 2, ' net/ixgbe: ' in the title is used to describe the component. So the title >>> should be ' lib/ether: prevent duplicate callback on list'. >>>> Thanks. >>> >>> Thanks for the advice. My mistake on the component. Is there an easy way to >>> fix, or does it make sense just to nack this and I'll submit one with the correct >>> component. >> No need to NACK it. You can send a V2 with the correct component. And I think you can add my ack in the V2. >> Acked-by: Wenzhuo Lu >> >> BTW, I forgot to mention that as it's a fix. We always add a Fixes tag in the commit log. You can find the example from other one's mails :) > > Will do. The patch checker was squaking about the fixes tag and I remvoed > it :( So, I need to figure out what it didn't like about it and I'll fix > with a V2 and add your ack. Getting late here tonight, so tomorrow. > > Thanks > Scott V2 created, but with the change to the component the subject is different: [PATCH v2] lib/ether: prevent duplicate callback on list > > >> > >>> >>> Scott >>> >>>> >>>> >> >