From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 01EDE38EB
 for <dev@dpdk.org>; Sat,  7 Oct 2017 01:04:22 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by orsmga104.jf.intel.com with ESMTP; 06 Oct 2017 16:04:21 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,486,1500966000"; d="scan'208";a="159812795"
Received: from unknown (HELO [10.241.225.2]) ([10.241.225.2])
 by fmsmga005.fm.intel.com with ESMTP; 06 Oct 2017 16:04:20 -0700
To: "Yao, Lei A" <lei.a.yao@intel.com>, "Hu, Jiayu" <jiayu.hu@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Cc: "Tan, Jianfeng" <jianfeng.tan@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "thomas@monjalon.net" <thomas@monjalon.net>,
 "Wu, Jingjing" <jingjing.wu@intel.com>
References: <1504420216-3258-1-git-send-email-jiayu.hu@intel.com>
 <1506407202-29843-1-git-send-email-jiayu.hu@intel.com>
 <2DBBFF226F7CF64BAFCA79B681719D953A2965D1@shsmsx102.ccr.corp.intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <b003fe26-033b-8f28-65a7-b0924893ad01@intel.com>
Date: Sat, 7 Oct 2017 00:04:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A2965D1@shsmsx102.ccr.corp.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: enable the heavyweight mode
	TCP/IPv4 GRO
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Oct 2017 23:04:23 -0000

On 9/27/2017 8:23 AM, Yao, Lei A wrote:
<...>

>> The GRO library provides two modes to reassemble packets. Currently, the
>> csum forwarding engine has supported to use the lightweight mode to
>> reassemble TCP/IPv4 packets. This patch introduces the heavyweight mode
>> for TCP/IPv4 GRO in the csum forwarding engine.
>>
>> With the command "set port <port_id> gro on|off", users can enable
>> TCP/IPv4 GRO for a given port. With the command "set gro flush <cycles>",
>> users can determine when the GROed TCP/IPv4 packets are flushed from
>> reassembly tables. With the command "show port <port_id> gro", users can
>> display GRO configuration.
>>
>> The GRO library doesn't re-calculate checksums for merged packets. If
>> users want the merged packets to have correct IP and TCP checksums,
>> please select HW IP checksum calculation and HW TCP checksum calculation
>> for the port which the merged packets are transmitted to.
>>
>> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

> Tested-by: Yao Lei<lei.a.yao@intel.com>

Applied to dpdk-next-net/master, thanks.