From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 124962C38; Thu, 23 Aug 2018 15:15:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2018 06:15:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,278,1531810800"; d="scan'208";a="84297995" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga001.jf.intel.com with ESMTP; 23 Aug 2018 06:15:34 -0700 To: Chas Williams <3chas3@gmail.com>, Thomas Monjalon Cc: Chas Williams , dev@dpdk.org, Declan Doherty , Radu Nicolau , stable@dpdk.org References: <1533129523-1407-1-git-send-email-radu.nicolau@intel.com> <0c16cb66-6ee4-ff2d-6d16-7a3fdd021b0c@intel.com> <11360076.HoYMhSRcrZ@xps> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Thu, 23 Aug 2018 14:15:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 13:15:37 -0000 On 8/6/2018 4:50 PM, Chas Williams wrote: > On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon wrote: > >> 02/08/2018 15:38, Doherty, Declan: >>> On 01/08/2018 2:18 PM, Radu Nicolau wrote: >>>> When a bonding port is stopped also stop and deactivate all slaves. >>>> Otherwise slaves will be still listed as active. >>>> >>>> Fixes: 69bce062132b ("net/bonding: do not clear active slave count") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Radu Nicolau >>> >>> Acked-by: Declan Doherty >> >> Waiting for opinion from the other bonding maintainer (Chas) >> who started to review and has some doubts. >> > > The slaves being listed as active is not a bug. If the slaves are not > deactivated, then they should be considered activated. Previously, > stopping the bonding PMD just reset the active slave count. That's > not the right way to deactivate slaves. This was fixed by 69bce062132b. > > This patch is new behavior of explicitly deactivating the slaves when > the bonding PMD is stopped. > > As I mentioned, I think this makes life difficult for those of us using > an external state machine. However, that should probably be fixed > differently then. > > >> >> Chas, please do you agree with Declan's ack? >> >> >> > Change the Fixes line. Hi Chas, Are you OK with the rest of the patch if Fixes line fixed? If already have a proposed fixes line I can fix it while merging. Thanks, ferruh