From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B997F45909;
	Thu,  5 Sep 2024 08:33:12 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4B93040264;
	Thu,  5 Sep 2024 08:33:12 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 1F45D4025C
 for <dev@dpdk.org>; Thu,  5 Sep 2024 08:33:10 +0200 (CEST)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 0966156
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1725517989;
 bh=nJb7KuXnTX2IU/q+Ytu9WmXECRWWGu8CykCtxXeNA1c=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=pBjiTuwQFvg2wfui+M2q7djMQW6jotHsxf898o9mDxV5THCpZ3olTGtWPj+IHr1H4
 f3hVkUuJPR13gOeY77wcgImtCptIGinv1QV8GcwTu1/Q5uEXzm68HDHH1XDbgZD0JD
 otFxsngTrM6on8vwj2OJ50F3bP91XMXomo/KiE64=
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 0966156;
 Thu,  5 Sep 2024 09:33:09 +0300 (MSK)
Message-ID: <b03519d2-9f34-4cd3-b744-033d1200f381@oktetlabs.ru>
Date: Thu, 5 Sep 2024 09:33:08 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/3] ethdev: add description for KEEP CRC offload
To: Jie Hai <haijie1@huawei.com>, dev@dpdk.org, stephen@networkplumber.org,
 ferruh.yigit@amd.com, mb@smartsharesystems.com,
 Thomas Monjalon <thomas@monjalon.net>,
 Allain Legacy <allain.legacy@windriver.com>
Cc: huangdengdui@huawei.com, fengchengwen@huawei.com, lihuisong@huawei.com
References: <20240206011030.2007689-1-haijie1@huawei.com>
 <20240719090415.1513301-1-haijie1@huawei.com>
 <20240719090415.1513301-2-haijie1@huawei.com>
Content-Language: en-US
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20240719090415.1513301-2-haijie1@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 7/19/24 12:04, Jie Hai wrote:
> From: Dengdui Huang <huangdengdui@huawei.com>
> 
> The data exceeds the pkt_len in mbuf is inavailable for user.
> When KEEP CRC offload is enabled, CRC field length should be
> included in the pkt_len in mbuf. However, almost of drivers
> supported KEEP CRC feature didn't add the CRC data length to
> pkt_len. So it is very necessary to add comments for this.
> 
> Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Huisong Li <lihuisong@huawei.com>
> Acked-by: Jie Hai <haijie1@huawei.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>