From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED915A0524; Tue, 20 Apr 2021 11:39:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D352D412B0; Tue, 20 Apr 2021 11:39:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 6E901411A5 for ; Tue, 20 Apr 2021 11:39:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618911576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=neU3drbYPL4hoXAJKAXwlw2M0CNaHJ05q7x4oGEQ4DM=; b=My5y6qFGp6tF5U9FZNFYFE6yg02PuZNHpddFQvy3wGH94gzFRKrw1QlDzVeudCEhlOb2XV pMXIOFWqhRo3C6/70rH4UgG48JkDCada7fv+bz5M9i3qXJDVXN2N55nRko/8mEO7F+7ujp /7yEjSgK/G4xXG+3QqtRSNApKaemkIg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-1-WRRLumbmNcONQ0Kj2520ow-1; Tue, 20 Apr 2021 05:39:34 -0400 X-MC-Unique: WRRLumbmNcONQ0Kj2520ow-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 70A978143FE; Tue, 20 Apr 2021 09:39:33 +0000 (UTC) Received: from [10.36.110.28] (unknown [10.36.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE4A350DDB; Tue, 20 Apr 2021 09:39:31 +0000 (UTC) To: Jiayu Hu , dev@dpdk.org, chenbo.xia@intel.com Cc: yinan.wang@intel.com, sunil.pai.g@intel.com, cheng1.jiang@intel.com, stable@dpdk.org References: <1617368642-131298-1-git-send-email-jiayu.hu@intel.com> <1618909066-114980-1-git-send-email-jiayu.hu@intel.com> <1618909066-114980-4-git-send-email-jiayu.hu@intel.com> From: Maxime Coquelin Message-ID: Date: Tue, 20 Apr 2021 11:39:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1618909066-114980-4-git-send-email-jiayu.hu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 3/4] vhost: fix unnecessary vring_state_changed call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/20/21 10:57 AM, Jiayu Hu wrote: > When VHOST_USER_F_PROTOCOL_FEATURES is not negotiated, > there is no need for vhost_user_set_vring_kick() to > notify the application of vring enabled, as > vhost_user_msg_handler() also notifies the application. > > This patch is to remove unnecessary vring_state_changed() call. > > Fixes: 966027b4b3a3 ("vhost: fix silent queue enabling with legacy guests") Sorry, I thought the vring_state_changed cb was introduced when Matan did the rework last year, but it is actually older. If we backport the patch on v19.11, we will create a regression as it will revert Ilya's patch. I think that your fix is correct only once Matan's series is present, so we should have below Fixes tag: Fixes: d0fcc38f5fa4 ("vhost: improve device readiness notifications") > Cc: stable@dpdk.org > > Signed-off-by: Jiayu Hu > Tested-by: Yinan Wang > --- > lib/librte_vhost/vhost_user.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index fa8929f..611ff20 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -1922,9 +1922,6 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg, > */ > if (!(dev->features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES))) { > vq->enabled = true; > - if (dev->notify_ops->vring_state_changed) > - dev->notify_ops->vring_state_changed( > - dev->vid, file.index, 1); > } > > if (vq->ready) { > With the fixes tag changed: Reviewed-by: Maxime Coquelin Chanbo, can you change the Fixes tag while applying or Jiayu needs to send a new revision? Thanks, Maxime