From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.napatech.com (mail02.napatech.com [188.120.77.119]) by dpdk.org (Postfix) with ESMTP id 028A7A2F for ; Wed, 26 Apr 2017 13:15:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; i=@napatech.com; q=dns/txt; s=mar2017; t=1493205327; x=1524741327; h=from:to:cc:subject:date:message-id:mime-version; bh=3Uad2kB263UjRiklkFJjIHP5P34JA78IyGxw58FOG2I=; b=B8hFKQs269ENyalEkoS5Ql4TPFaUeiGpnlEULF6Vtq7tVE6zBZM9y5jk hjg7upC4Nkiegjgm5FoxLnH6P60xRw45sov5rEZ+4IfJHfHmZvH66JibR EkLz2Pcoi6Fujroy9Trd1ViImwao92zBTH/s8Cmy6KWkg8LG5ZEK9HvKC KltIO7r22UdjLJ0cLe9WVI1THr09KG7/tPzMMeGfJJvpghBjQzI/BYlTL vMx/Zp20OtkR1spmSJjCQLkcObaumOiteJhtm9j+UB63+RYHYCcsWYqj+ qNPNY/DwoIN/uXoCIUkhgGdiC0/2ezI1AjKt9YwzBjmxPPcwRSVarCMoB g==; IronPort-PHdr: =?us-ascii?q?9a23=3AV3hRPRFVBmGcv5atN6lONJ1GYnF86YWxBRYc798d?= =?us-ascii?q?s5kLTJ7yoM2wAkXT6L1XgUPTWs2DsrQf2rSQ7/yrAjdIyK3CmUhKSIZLWR4BhJ?= =?us-ascii?q?detC0bK+nBN3fGKuX3ZTcxBsVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBxrwKxd+?= =?us-ascii?q?KPjrFY7OlcS30P2594HObwlSijewZbJ/IA+5oAjeucUbj4VvIbstxxXUpXdFZ/?= =?us-ascii?q?5Yzn5yK1KJmBb86Maw/Jp9/ClVpvks6c1OX7jkcqohVbBXAygoPG4z5M3wqBnM?= =?us-ascii?q?VhCP6WcGUmUXiRVHHQ7I5wznU5jrsyv6su192DSGPcDzULs5Vyiu47ttRRT1ji?= =?us-ascii?q?oMKjw3/3zNisFojKxVvg+vpwBxzYDXYYGaKPVxc7jHct8GR2pMRNpdWzBfDo66?= =?us-ascii?q?coABD/ABPeFdr4TloFUOrAexBQm2C+zxzj9Dm3n43aw+0+QjCw7NwQstH9cKsH?= =?us-ascii?q?nPqtX6Lr8SXvqpzKbW0TrDb+la1iv66IjNax0sp+yHU7x3ccrU00YvFgXFg02W?= =?us-ascii?q?qYP/JzOazPgNvHaH4OpgT+6gl2knqwR3rzOyxckskpHEip8Jxlze6yl0z5o5Kc?= =?us-ascii?q?elREJhYtOpH4NcuzyGO4dsXM8vTH1ktDwnxrEao5K2fTYGxIwpxxHBaPGLb42F?= =?us-ascii?q?7xfjWeuSPDt1gXJodK+liBqv9EWv0PHzW8e60FtPrSdIncfDu3YQ3BLJ8MeHUO?= =?us-ascii?q?Fy/kK51DaK0ADc9/9LLFgvlareN54h2rkwlocPsUjbHi/5hkH2jKiOe0Uh4Oeo?= =?us-ascii?q?6uDnbq/gppCGL497kB3+Pboylcy/G+g3Lg8OX22D9eS90r3s41H5Ta1XgvEqiK?= =?us-ascii?q?XVrp/XKdgBqqKkGQNY0Yku5w66Dzi80dQYmXcHLEhCeBKCl4XpPlXOLev+Dfil?= =?us-ascii?q?m1SjiitryO7aMb3hGJnCMn/DkLL5cbZn90Fc0BYzzcxY559MFL4BJPPzWknruN?= =?us-ascii?q?3ZDh82KQq0w+n8BdV80IMeRXyAAquDPKzOtl+I4/olI/OQa48NpDb9N/8l6ubs?= =?us-ascii?q?jX84n18dcqup3ZoRaHC3BPhnLViZbGHtgtcHDWcFoA4+QPb2h12FVD5Zf2yyUL?= =?us-ascii?q?4k5jEnFIKmCp/OSZ2zj7yfxyq0A4VWaX1FClyWFnfobYqECL8wb3fYL8tglHoW?= =?us-ascii?q?VbGnRKcg0w2jsEnxzL8tZr7Z/iwe84Dj3d56z+zViRw2szdzCpLZmyuPTmd7nG?= =?us-ascii?q?IOSHkpwYh+p1BwzhGI1q0yy6haFNpc5fJPXUElKLbdyfB3D5b5XQeXLfmTT1Pz?= =?us-ascii?q?Z9StATg8SpoVwtsMag4pHtGKiBnb1janCL9TnLuOUs9nupnA1mT8cp4ug03N07?= =?us-ascii?q?Ms2gEr?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EEAQBMgABZ/1QB8ApbHAEBBAEBCgEBF?= =?us-ascii?q?wEBBAEBCgEBgkOBSIEMB413pzmCDxwQhXiEXhgBAQEBAQEBAQEBAQKBEIIzIIE?= =?us-ascii?q?sLAhIAUcGTBIBgQAmAQQBDQUIiiGrXzqLMAEBAQEBAQEBAQEBAQEBAQEBHAWEQ?= =?us-ascii?q?4IRgV6HQxEBgmgMgw0FiTWILotrkwKCC4U3iiMCSJNfH4E4CCcdCBkVhzB1hke?= =?us-ascii?q?BIYENAQEB?= X-IPAS-Result: =?us-ascii?q?A2EEAQBMgABZ/1QB8ApbHAEBBAEBCgEBFwEBBAEBCgEBgkO?= =?us-ascii?q?BSIEMB413pzmCDxwQhXiEXhgBAQEBAQEBAQEBAQKBEIIzIIEsLAhIAUcGTBIBg?= =?us-ascii?q?QAmAQQBDQUIiiGrXzqLMAEBAQEBAQEBAQEBAQEBAQEBHAWEQ4IRgV6HQxEBgmg?= =?us-ascii?q?Mgw0FiTWILotrkwKCC4U3iiMCSJNfH4E4CCcdCBkVhzB1hkeBIYENAQEB?= Received: from cph-gen-exch02.napatech.com (10.240.1.84) by cph-gen-exch02.napatech.com (10.240.1.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Wed, 26 Apr 2017 13:15:22 +0200 Received: from cph-gen-exch02.napatech.com ([fe80::581:51a1:ac3f:84e]) by cph-gen-exch02.napatech.com ([fe80::581:51a1:ac3f:84e%12]) with mapi id 15.01.0845.034; Wed, 26 Apr 2017 13:15:22 +0200 From: Michael Lilja To: "elin.zhang@intel.com" , "jingjing.wu@intel.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH] drivers/net/i40e/i40e_fdir.c: Improved i40e FDIR programming times Thread-Index: AdK+fF9XJzhS+qx4RkaCMtW6n3fwzA== Date: Wed, 26 Apr 2017 11:15:22 +0000 Message-ID: Accept-Language: da-DK, en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.240.10.62] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] [PATCH] drivers/net/i40e/i40e_fdir.c: Improved i40e FDIR programming times X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 11:15:27 -0000 During my work (https://www.napatech.com/hw-acceleration-via-rte_flow/)on a= flowtable application example that use rte_flow I discovered that the rte_= flow programming times on a i40e was +11ms. The patch below result in an av= erage programming time of 22usec with a max of 60usec instead of +11ms. Could the following patch be useful? There might be a good reason for the o= riginal code, I'm unable to tell, so I will let it up to the maintainer to = decide. Signed-off-by: Michael Lilja --- drivers/net/i40e/i40e_fdir.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 28cc554f5..a1ec66063 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -1296,23 +1296,29 @@ i40e_fdir_filter_programming(struct i40e_pf *pf, rte_wmb(); I40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail); - for (i =3D 0; i < I40E_FDIR_WAIT_COUNT; i++) { - rte_delay_us(I40E_FDIR_WAIT_INTERVAL_US); + for (i =3D 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)= ; i++) { if ((txdp->cmd_type_offset_bsz & rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) =3D=3D rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE)) break; + rte_delay_us(1); } - if (i >=3D I40E_FDIR_WAIT_COUNT) { + if (i >=3D (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)) { PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" " time out to get DD on tx queue."); return -ETIMEDOUT; } /* totally delay 10 ms to check programming status*/ - rte_delay_us((I40E_FDIR_WAIT_COUNT - i) * I40E_FDIR_WAIT_INTERVAL_US)= ; + uint32_t w; + for (w =3D 0; w < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)= ; w++) { + if (i40e_check_fdir_programming_status(rxq) >=3D 0) { + break; + } + rte_delay_us(1); + } if (i40e_check_fdir_programming_status(rxq) < 0) { PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" - " programming status reported."); + " programming status reported."); return -ENOSYS; } -- Disclaimer: This email and any files transmitted with it may contain confid= ential information intended for the addressee(s) only. The information is n= ot to be surrendered or copied to unauthorized persons. If you have receive= d this communication in error, please notify the sender immediately and del= ete this e-mail from your system.