From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FC7AA0521; Mon, 2 Nov 2020 12:58:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B0C7C838; Mon, 2 Nov 2020 12:58:29 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 3621DC834 for ; Mon, 2 Nov 2020 12:58:26 +0100 (CET) IronPort-SDR: UaM1ljZPYLwtgPKBpD80AAqS57TI1IaGqJT8IQozUVUuMIzmNLDBkVNd3Zjuj1VpG0x0PNcCui MBzh7WJD/ecw== X-IronPort-AV: E=McAfee;i="6000,8403,9792"; a="233041541" X-IronPort-AV: E=Sophos;i="5.77,444,1596524400"; d="scan'208";a="233041541" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 03:58:24 -0800 IronPort-SDR: 5I9z8BJe1Lxvw+k7jqMF2JaJ7vwPiDpOwxfRbffoeq6TgW6l8OorIF1kmbAjf0c6gfNERHq/Df rs1Aks2owCxg== X-IronPort-AV: E=Sophos;i="5.77,444,1596524400"; d="scan'208";a="537992514" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.219.143]) ([10.213.219.143]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 03:58:21 -0800 From: Ferruh Yigit To: Jiawen Wu , 'David Marchand' , 'Thomas Monjalon' Cc: 'Jian Wang' , 'dev' , 'Bruce Richardson' , 'Olivier Matz' , 'Andrew Rybchenko' , 'Akhil Goyal' , 'Jerin Jacob Kollanukkaran' References: <20201026052105.1561859-1-thomas@monjalon.net> <16204738.pLQXvH3U5b@thomas> <5960b0cf-eb7a-af00-ae6a-86ad5e5db6eb@intel.com> <2336246.PS5YtoHrA8@thomas> <002501d6b0f8$1f5d1420$5e173c60$@trustnetic.com> <9b514cef-9998-f9c1-7ebc-f7a0df4bf43e@intel.com> Message-ID: Date: Mon, 2 Nov 2020 11:58:17 +0000 MIME-Version: 1.0 In-Reply-To: <9b514cef-9998-f9c1-7ebc-f7a0df4bf43e@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v6 00/15] remove mbuf userdata X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2020 11:08 AM, Ferruh Yigit wrote: > On 11/2/2020 9:11 AM, Jiawen Wu wrote: >> On Sunday, November 1, 2020 6:26 PM, David Marchand wrote: >>> On Sun, Nov 1, 2020 at 10:15 AM Thomas Monjalon >>> wrote: >>>>> The new txgbe driver in the next-net is also using ‘udata64’, that >>>>> also needs to be updated. cc'ed txgbe maintainer. >>>> >>>> That's a pity it did not take into account the deprecation notice. >>>> What kind of hack is it used for? >>>> Can it be simply removed to allow quick merging of the PMD? >>> >>> +1 for removing. >>> >>> It seems to be a provision for future features, as this field is simply >>> passed to >>> an internal function that does not use it. >>> >>> $ git grep -C 2 udata drivers/net/txgbe/ >>> drivers/net/txgbe/txgbe_rxtx.c- >>> drivers/net/txgbe/txgbe_rxtx.c- >>> txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, >>> drivers/net/txgbe/txgbe_rxtx.c: >>> tx_offload, &tx_pkt->udata64); >>> drivers/net/txgbe/txgbe_rxtx.c- >>> drivers/net/txgbe/txgbe_rxtx.c-                         txe->last_id = >>> tx_last; >>> >>> $ git grep -C 2 txgbe_set_xmit_ctx drivers/net/txgbe/ >>> drivers/net/txgbe/txgbe_rxtx.c- >>> drivers/net/txgbe/txgbe_rxtx.c-static inline void >>> drivers/net/txgbe/txgbe_rxtx.c:txgbe_set_xmit_ctx(struct txgbe_tx_queue >>> *txq, >>> drivers/net/txgbe/txgbe_rxtx.c-         volatile struct >>> txgbe_tx_ctx_desc *ctx_txd, >>> drivers/net/txgbe/txgbe_rxtx.c-         uint64_t ol_flags, union >>> txgbe_tx_offload tx_offload, >>> -- >>> drivers/net/txgbe/txgbe_rxtx.c-                         } >>> drivers/net/txgbe/txgbe_rxtx.c- >>> drivers/net/txgbe/txgbe_rxtx.c: >>> txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, >>> drivers/net/txgbe/txgbe_rxtx.c- >>> tx_offload, &tx_pkt->udata64); >>> drivers/net/txgbe/txgbe_rxtx.c- >>> >>> $ git grep -w mdata drivers/net/txgbe/ >>> drivers/net/txgbe/txgbe_rxtx.c:         __rte_unused uint64_t *mdata) >>> >>> >>> -- >>> David Marchand >> >> Thanks for review. >> It can be just simply removed in txgbe driver. >> > > OK, I will remove it in the next-net. > Applied following: diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c index b35b7de1cb..4d8b43423d 100644 --- a/drivers/net/txgbe/txgbe_rxtx.c +++ b/drivers/net/txgbe/txgbe_rxtx.c @@ -281,8 +281,7 @@ txgbe_xmit_pkts_simple(void *tx_queue, struct rte_mbuf **tx_pkts, static inline void txgbe_set_xmit_ctx(struct txgbe_tx_queue *txq, volatile struct txgbe_tx_ctx_desc *ctx_txd, - uint64_t ol_flags, union txgbe_tx_offload tx_offload, - __rte_unused uint64_t *mdata) + uint64_t ol_flags, union txgbe_tx_offload tx_offload) { union txgbe_tx_offload tx_offload_mask; uint32_t type_tucmd_mlhl; @@ -861,7 +860,7 @@ txgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, } txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, - tx_offload, &tx_pkt->udata64); + tx_offload); txe->last_id = tx_last; tx_id = txe->next_id;