DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Jie Hai <haijie1@huawei.com>,
	dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru
Cc: lihuisong@huawei.com, fengchengwen@huawei.com
Subject: Re: [PATCH v7 0/8] support dump reigser names and filter
Date: Sun, 22 Sep 2024 22:31:27 +0100	[thread overview]
Message-ID: <b0ba1b2e-37fe-4979-91e2-46e452e59ebb@amd.com> (raw)
In-Reply-To: <20240914071320.1982-1-haijie1@huawei.com>

On 9/14/2024 8:13 AM, Jie Hai wrote:
> The registers can be dumped through the API rte_eth_dev_get_reg_info.
> However, only register values are exported, which is inconvenient for
> users to interpret. Therefore, an extension of the structure
> "rte_dev_reg_info" and a new API rte_eth_dev_get_reg_info_ext is added
> to support the capability of exporting the name of the corresponding
> register and filtering by module names.
> 
> --
> v7: fix doc indention.
> --
> Jie Hai (8):
>   ethdev: support report register names and filter
>   ethdev: add telemetry cmd for registers
>   net/hns3: remove some basic address dump
>   net/hns3: fix dump counter of registers
>   net/hns3: remove separators between register module
>   net/hns3: refactor register dump
>   net/hns3: support report names of registers
>   net/hns3: support filter registers by module names
>

Hi Jie,

ethdev changes looks good to me, I can see there are some comments so I
assume there will be new version, if there is no major changes please
feel free to keep the review tags.

After new version I will wait for a few more days to give chance to
others for final review, and will merge later.

Thanks,
ferruh

  parent reply	other threads:[~2024-09-22 21:31 UTC|newest]

Thread overview: 134+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14  1:56 [PATCH] ethdev: add dump regs for telemetry Jie Hai
2023-12-14 12:49 ` Ferruh Yigit
2024-01-09  2:19   ` Jie Hai
2024-01-09  2:41     ` Jie Hai
2024-01-09 18:06     ` Ferruh Yigit
2024-01-10  1:38       ` fengchengwen
2024-01-10 12:15         ` Ferruh Yigit
2024-01-10 14:09           ` Thomas Monjalon
2024-01-10 15:48             ` Ferruh Yigit
2024-01-11  1:55           ` fengchengwen
2024-01-11 11:11             ` Ferruh Yigit
2024-01-11 12:43               ` fengchengwen
2024-02-05 10:51 ` [PATCH v2 0/7] support dump reigser names and filter them Jie Hai
2024-02-05 10:51   ` [PATCH v2 1/7] ethdev: support report register names and filter Jie Hai
2024-02-07 17:00     ` Ferruh Yigit
2024-02-20  8:43       ` Jie Hai
2024-02-05 10:51   ` [PATCH v2 2/7] ethdev: add telemetry cmd for registers Jie Hai
2024-02-07 17:03     ` Ferruh Yigit
2024-02-22  9:01       ` Jie Hai
2024-02-05 10:51   ` [PATCH v2 3/7] net/hns3: fix dump counter of registers Jie Hai
2024-02-05 10:51   ` [PATCH v2 4/7] net/hns3: remove dump format " Jie Hai
2024-02-05 10:51   ` [PATCH v2 5/7] net/hns3: add names for registers Jie Hai
2024-02-05 10:51   ` [PATCH v2 6/7] net/hns3: support filter directly accessed registers Jie Hai
2024-02-05 10:51   ` [PATCH v2 7/7] net/hns3: support filter dump of registers Jie Hai
2024-02-20 10:58 ` [PATCH v3 0/7] support dump reigser names and filter them Jie Hai
2024-02-20 10:58   ` [PATCH v3 1/7] ethdev: support report register names and filter Jie Hai
2024-02-20 15:09     ` Stephen Hemminger
2024-02-26  2:33       ` Jie Hai
2024-02-20 15:13     ` Stephen Hemminger
2024-02-26  2:41       ` Jie Hai
2024-02-20 15:14     ` Stephen Hemminger
2024-02-26  2:57       ` Jie Hai
2024-02-20 15:14     ` Stephen Hemminger
2024-02-26  2:33       ` Jie Hai
2024-02-20 10:58   ` [PATCH v3 2/7] ethdev: add telemetry cmd for registers Jie Hai
2024-02-20 10:58   ` [PATCH v3 3/7] net/hns3: fix dump counter of registers Jie Hai
2024-02-20 10:58   ` [PATCH v3 4/7] net/hns3: remove dump format " Jie Hai
2024-02-20 10:58   ` [PATCH v3 5/7] net/hns3: add names for registers Jie Hai
2024-02-20 10:58   ` [PATCH v3 6/7] net/hns3: support filter directly accessed registers Jie Hai
2024-02-20 10:58   ` [PATCH v3 7/7] net/hns3: support filter dump of registers Jie Hai
2024-02-26  3:07 ` [PATCH v4 0/7] support dump reigser names and filter them Jie Hai
2024-02-26  3:07   ` [PATCH v4 1/7] ethdev: support report register names and filter Jie Hai
2024-02-26  8:01     ` fengchengwen
2024-03-06  7:22       ` Jie Hai
2024-02-29  9:52     ` Thomas Monjalon
2024-03-05  7:45       ` Jie Hai
2024-02-26  3:07   ` [PATCH v4 2/7] ethdev: add telemetry cmd for registers Jie Hai
2024-02-26  9:09     ` fengchengwen
2024-03-06  7:18       ` Jie Hai
2024-02-26  3:07   ` [PATCH v4 3/7] net/hns3: fix dump counter of registers Jie Hai
2024-02-26  3:07   ` [PATCH v4 4/7] net/hns3: remove dump format " Jie Hai
2024-02-26  3:07   ` [PATCH v4 5/7] net/hns3: add names for registers Jie Hai
2024-02-26  3:07   ` [PATCH v4 6/7] net/hns3: support filter directly accessed registers Jie Hai
2024-02-26  3:07   ` [PATCH v4 7/7] net/hns3: support filter dump of registers Jie Hai
2024-03-07  3:02 ` [PATCH v5 0/7] support dump reigser names and filter them Jie Hai
2024-03-07  3:02   ` [PATCH v5 1/7] ethdev: support report register names and filter Jie Hai
2024-03-08  8:09     ` lihuisong (C)
2024-03-07  3:02   ` [PATCH v5 2/7] ethdev: add telemetry cmd for registers Jie Hai
2024-03-08  8:48     ` lihuisong (C)
2024-03-07  3:02   ` [PATCH v5 3/7] net/hns3: fix dump counter of registers Jie Hai
2024-03-08  8:49     ` lihuisong (C)
2024-03-07  3:02   ` [PATCH v5 4/7] net/hns3: remove dump format " Jie Hai
2024-03-08  9:17     ` lihuisong (C)
2024-03-07  3:02   ` [PATCH v5 5/7] net/hns3: add names for registers Jie Hai
2024-03-08  9:41     ` lihuisong (C)
2024-03-08 10:24     ` lihuisong (C)
2024-03-07  3:02   ` [PATCH v5 6/7] net/hns3: support filter directly accessed registers Jie Hai
2024-03-08  9:41     ` lihuisong (C)
2024-03-07  3:02   ` [PATCH v5 7/7] net/hns3: support filter dump of registers Jie Hai
2024-07-22  6:58 ` [PATCH v6 0/8] support dump reigser names and filter Jie Hai
2024-07-22  6:58   ` [PATCH v6 1/8] ethdev: support report register " Jie Hai
2024-07-22  6:58   ` [PATCH v6 2/8] ethdev: add telemetry cmd for registers Jie Hai
2024-07-22  6:58   ` [PATCH v6 3/8] net/hns3: remove some basic address dump Jie Hai
2024-07-22  6:58   ` [PATCH v6 4/8] net/hns3: fix dump counter of registers Jie Hai
2024-07-22  6:58   ` [PATCH v6 5/8] net/hns3: remove separators between register module Jie Hai
2024-07-22  6:58   ` [PATCH v6 6/8] net/hns3: refactor register dump Jie Hai
2024-07-22  6:58   ` [PATCH v6 7/8] net/hns3: support report names of registers Jie Hai
2024-07-22  6:58   ` [PATCH v6 8/8] net/hns3: support filter registers by module names Jie Hai
2024-08-09  9:22   ` [PATCH v6 0/8] support dump reigser names and filter Jie Hai
2024-09-05  6:26 ` [RESEND " Jie Hai
2024-09-05  6:26   ` [RESEND v6 1/8] ethdev: support report register " Jie Hai
2024-09-05  6:26   ` [RESEND v6 2/8] ethdev: add telemetry cmd for registers Jie Hai
2024-09-05  6:26   ` [RESEND v6 3/8] net/hns3: remove some basic address dump Jie Hai
2024-09-05  6:26   ` [RESEND v6 4/8] net/hns3: fix dump counter of registers Jie Hai
2024-09-05  6:26   ` [RESEND v6 5/8] net/hns3: remove separators between register module Jie Hai
2024-09-05  6:26   ` [RESEND v6 6/8] net/hns3: refactor register dump Jie Hai
2024-09-05  6:26   ` [RESEND v6 7/8] net/hns3: support report names of registers Jie Hai
2024-09-05  6:26   ` [RESEND v6 8/8] net/hns3: support filter registers by module names Jie Hai
2024-09-14  6:53 ` [PATCH v7 0/8] support dump reigser names and filter Jie Hai
2024-09-14  7:13 ` Jie Hai
2024-09-14  7:13   ` [PATCH v7 1/8] ethdev: support report register " Jie Hai
2024-09-22 21:26     ` Ferruh Yigit
2024-09-14  7:13   ` [PATCH v7 2/8] ethdev: add telemetry cmd for registers Jie Hai
2024-09-14  8:20     ` fengchengwen
2024-09-23  2:41       ` Jie Hai
2024-09-22 21:28     ` Ferruh Yigit
2024-09-14  7:13   ` [PATCH v7 3/8] net/hns3: remove some basic address dump Jie Hai
2024-09-14  8:21     ` fengchengwen
2024-09-14  7:13   ` [PATCH v7 4/8] net/hns3: fix dump counter of registers Jie Hai
2024-09-14  7:13   ` [PATCH v7 5/8] net/hns3: remove separators between register module Jie Hai
2024-09-14  7:13   ` [PATCH v7 6/8] net/hns3: refactor register dump Jie Hai
2024-09-14  8:26     ` fengchengwen
2024-09-14  7:13   ` [PATCH v7 7/8] net/hns3: support report names of registers Jie Hai
2024-09-14  8:27     ` fengchengwen
2024-09-14  7:13   ` [PATCH v7 8/8] net/hns3: support filter registers by module names Jie Hai
2024-09-14  8:46     ` fengchengwen
2024-09-14 15:00   ` [PATCH v7 0/8] support dump reigser names and filter Stephen Hemminger
2024-09-23  2:41     ` Jie Hai
2024-09-22 21:31   ` Ferruh Yigit [this message]
2024-09-25  6:40 ` [PATCH v8 0/8] support dump register " Jie Hai
2024-09-25  6:40   ` [PATCH v8 1/8] ethdev: support report " Jie Hai
2024-09-25  6:40   ` [PATCH v8 2/8] ethdev: add telemetry cmd for registers Jie Hai
2024-09-26  1:22     ` fengchengwen
2024-09-25  6:40   ` [PATCH v8 3/8] net/hns3: remove some basic address dump Jie Hai
2024-09-25  6:40   ` [PATCH v8 4/8] net/hns3: fix dump counter of registers Jie Hai
2024-09-25  6:40   ` [PATCH v8 5/8] net/hns3: remove separators between register module Jie Hai
2024-09-25  6:40   ` [PATCH v8 6/8] net/hns3: refactor register dump Jie Hai
2024-09-25  6:40   ` [PATCH v8 7/8] net/hns3: support report names of registers Jie Hai
2024-09-25  6:40   ` [PATCH v8 8/8] net/hns3: support filter registers by module names Jie Hai
2024-09-26  1:46     ` fengchengwen
2024-09-26 12:37       ` Jie Hai
2024-09-26 12:42 ` [PATCH v9 0/8] support dump reigster names and filter Jie Hai
2024-09-26 12:42   ` [PATCH v9 1/8] ethdev: support report register " Jie Hai
2024-09-26 12:42   ` [PATCH v9 2/8] ethdev: add telemetry cmd for registers Jie Hai
2024-09-26 12:42   ` [PATCH v9 3/8] net/hns3: remove some basic address dump Jie Hai
2024-09-26 12:42   ` [PATCH v9 4/8] net/hns3: fix dump counter of registers Jie Hai
2024-09-26 12:42   ` [PATCH v9 5/8] net/hns3: remove separators between register module Jie Hai
2024-09-26 12:42   ` [PATCH v9 6/8] net/hns3: refactor register dump Jie Hai
2024-09-26 12:42   ` [PATCH v9 7/8] net/hns3: support report names of registers Jie Hai
2024-09-26 12:42   ` [PATCH v9 8/8] net/hns3: support filter registers by module names Jie Hai
2024-09-27  1:37     ` fengchengwen
2024-10-04 13:59     ` David Marchand
2024-10-07  3:01       ` Ferruh Yigit
2024-09-27 21:38   ` [PATCH v9 0/8] support dump reigster names and filter Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0ba1b2e-37fe-4979-91e2-46e452e59ebb@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=haijie1@huawei.com \
    --cc=lihuisong@huawei.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).