From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 272E37CD0 for ; Fri, 30 Jun 2017 19:02:32 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jun 2017 10:02:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,287,1496127600"; d="scan'208";a="103236627" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 30 Jun 2017 10:02:28 -0700 To: Stephen Hemminger Cc: dev@dpdk.org, anatoly.burakov@intel.com, Bruce Richardson References: <20170526165228.96919-1-ferruh.yigit@intel.com> <20170621110651.75299-1-ferruh.yigit@intel.com> <20170621110651.75299-3-ferruh.yigit@intel.com> <20170621082323.3c39a2d0@xeon-e3> From: Ferruh Yigit Message-ID: Date: Fri, 30 Jun 2017 18:02:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170621082323.3c39a2d0@xeon-e3> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v8 2/4] unci: add kernel control path kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 17:02:33 -0000 On 6/21/2017 4:23 PM, Stephen Hemminger wrote: > On Wed, 21 Jun 2017 12:06:49 +0100 > Ferruh Yigit wrote: > >> +static struct ethtool_input_buffer { >> + int magic; >> + void *buffer; >> + size_t length; >> + struct completion *msg_received; >> + int *err; >> + u32 in_use; >> +} ethtool_input_buffer > > Naming in kernel is important. This isn't kernel ethtool, so it shouldn't be named that. I have updated naming on v9. > > Having a single instance per system for a control interface means it won't work > if multiple apps have control channel open or in containers. This should work for multiple add and interfaces, unci_nl_exec() serializes the requests, above struct used for output buffer indirection. I am not sure how to handle requests without serializing them ... > > You should also do policy validation on the netlink message. I will send a new version with this. >