From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B61D14C95 for <dev@dpdk.org>; Mon, 22 Oct 2018 15:14:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2018 06:14:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,412,1534834800"; d="scan'208";a="97451899" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by fmsmga002.fm.intel.com with ESMTP; 22 Oct 2018 06:14:02 -0700 To: Thomas Monjalon <thomas@monjalon.net> Cc: Dan Gora <dg@adax.com>, dev@dpdk.org, Igor Ryzhov <iryzhov@nfware.com>, Stephen Hemminger <stephen@networkplumber.org> References: <20180911232906.18352-1-dg@adax.com> <20181019002358.17132-1-dg@adax.com> <1269b37a-cb2f-c343-18a8-f4a5993fc903@intel.com> <3348901.PjEyPxuV6a@xps> From: Ferruh Yigit <ferruh.yigit@intel.com> Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsGVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLzsFNBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABwsF8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <b10cbd37-2c39-837a-26e1-a46d3d1ae93e@intel.com> Date: Mon, 22 Oct 2018 14:14:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3348901.PjEyPxuV6a@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 0/5] kni: add API to set link status on kernel interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 22 Oct 2018 13:14:05 -0000 On 10/22/2018 2:08 PM, Thomas Monjalon wrote: > 22/10/2018 15:03, Ferruh Yigit: >> On 10/19/2018 1:23 AM, Dan Gora wrote: >>> Hi All, >>> >>> Attached is version 5 of a patchset to add a new API function to >>> set the link status on kernel interfaces created with the KNI kernel >>> module. >>> >>> v5 >>> ==== >>> * Update Kernel NIC Interface document with new rte_kni option, move >>> kernel module parameter description here from KNI sample app >>> document, general cleanup. >>> >>> * Update Kernel NIC Interface sample application (kni) document >>> with new command line parameter, remove documentation for rte_kni >>> kernel module but add reference to it, general cleanup. >>> >>> * Change link status change sample rate for KNI example app to 500ms >>> from 100ms. >>> >>> * Fix bug in parameter parsing in v4 in rte_kni kernel module. >>> >>> * Fix output formatting of optional parameters for rte_kni with >>> modinfo. >>> >>> * Fix permissions of optional parameters for rte_kni. >>> >>> * Squash patch to add test for rte_kni_update_link into patch >>> introducing the API function. >>> >>>> v4 >>>> ==== >>>> * Rework rte_kni_update_link to only take linkup/linkdown as parameter, >>>> return previous link state, and remove log messages. >>>> >>>> * Update patch to set default carrier state to make default carrier >>>> state configurable by passing the 'carrier=[on|off]' option to >>>> the rte_kni kernel module. This is necessary in order to allow >>>> applications which use KNI as pure virtual interfaces without >>>> corresponding physical ethernet port to use the interfaces without >>>> having to set the carrier state to 'on' via rte_kni_update_link() >>>> or by writing to /sys/devices/virtual/net/<ifaceX>/carrier. >>>> Note that the default is 'off'. >>>> >>>> * Add command line flag '-m' to examples/kni to continuously monitor >>>> and update the KNI interface link status according to the link >>>> status of the corresponding physical ethernet port. >>>> >>>> >>>> v3 >>>> ==== >>>> * Use separate function to test rte_kni_update_link() in 'test' app. >>>> >>>> * Separate changes to 'test' app into separate patch to facilitate >>>> possible merge with https://patches.dpdk.org/patch/44730/ >>>> >>>> * Remove changes to set KNI interfaces to 'up' in example/kni >>>> >>>> v2 >>>> ==== >>>> >>>> * Fix bug where "Fixed" and "AutoNeg" were transposed in the link >>>> status log message. >>>> >>>> * Add rte_kni_update_link() to rte_kni_version.map >>>> >>>> * Add rte_kni_update_link() tests to kni_autotest >>>> >>>> * Update examples/kni to continuously monitor link status and >>>> update the corresponding kernel interface with >>>> rte_kni_update_link(). >>>> >>>> * Minor improvements to examples/kni: Add log message showing how >>>> to show/zero stats. Improve zeroing statistics. >>>> >>>> Note that checkpatches.sh compains about patch 1/5, but this appears >>>> to be a bug with check-symbol-change or something. If I move the >>>> fragment of the patch modifying rte_kni_version.map to the bottom of >>>> the patch file, it doesn't complain any more... I just don't really >>>> have time to investigate this right now. >>> >>> thanks >>> dan >>> >>> >>> >>> Dan Gora (5): >>> kni: add API to set link status on kernel interface >>> kni: set default carrier state of interface >>> examples/kni: monitor and update link status continually >>> examples/kni: add log msgs to show and clear stats >>> examples/kni: improve zeroing statistics >> >> Thanks for the document clean up. >> >> For series, >> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> >> >> >> Thomas, >> >> There is a possible doc update, what do you think fixing it while applying? Or >> do you require a new version? > > What is the update to do? comments on patch 3/5