From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8067F4365A; Mon, 4 Dec 2023 15:09:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C65540DDE; Mon, 4 Dec 2023 15:09:57 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2075.outbound.protection.outlook.com [40.107.92.75]) by mails.dpdk.org (Postfix) with ESMTP id A422740DD8; Mon, 4 Dec 2023 15:09:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JK2cG024cZJpGZEZoBo7DjkjUYRrCQtsOZ40B1qb7hHNoK/pMdsvFCJlHIHjop3ky+wSbv7A0x0SnXvA88zFE+DVSUC8yG43UiL0AUdeNy90BWWULRTSrFVomQrVbFvk8sJVybqXHkJt+CA4jEr641KWZ5JcnkVUgURV3+DVrKOtBiejTkv+aikX/blIdim9xTYIOmYUlrXtWJG+S3FqokqhUzuqwkDXXLF+fEnx3P6CZmC+Ilsq4DPam+jl6b+ihMgW8V+5iDBLJ0mqEGzvtIY9ZMs+jz2On7mBgcSyl42LlFK7KJQwSbLS97X3uz/FRNsK0ww1q7hHNLsc7jfU4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K2wMSp58S6ZL5rbmcIB4aqQY3VKJ6Qcbk4Nxq4eYmMY=; b=B3pSG3+7nuDgD48r0QtL4Roi0nCONh13DIVOo948wJOC5ElyjVUxgpBIB6d9BrUUve3ITDZ8nElW4jCe0PjR2GGwxaCKs2Cvv4l9CsndTRRME2b4QdYAg43c/Nd4qkwsryX6ns7TPaL7vmQddaoGpwpSlipaIj/JKFYi4gd5lNvQ9BBKsivbv9XLjwd7dRQ0hkp6NYZkaZNzKp38gfyMH4/DWMji44tCY9ztuDvIevuno1Yws/n1GcEI+iGnte4SE0x8uPQebg3LaIGmUEq4bb0sQq/ZTAa5w7UfvT0eBo0WNBNNkCXD7oKhsIff+nN5/IAVNX6ArhrwvZ+wRD5SYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K2wMSp58S6ZL5rbmcIB4aqQY3VKJ6Qcbk4Nxq4eYmMY=; b=2xyeLWn/wRNqjD+KQdV8jAVgtvpcx7wfYdIVndqHJ1DSTYutmemD28mCjrBbzTXeQZCpMCDfed/Imu5gHSauTdB6+sGRynEzCKRgNo2Z3VHOsKAh2JZX+Cm20YD7kEu8AA7UlnFAMlajZkh1xetcANGbDZr1HUOO4ARbswXQ8b4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB8148.namprd12.prod.outlook.com (2603:10b6:806:351::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.33; Mon, 4 Dec 2023 14:09:51 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7046.034; Mon, 4 Dec 2023 14:09:51 +0000 Message-ID: Date: Mon, 4 Dec 2023 14:09:45 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: fix memzone leak in error path Content-Language: en-US To: Yunjian Wang , dev@dpdk.org Cc: ciara.loftus@intel.com, qi.z.zhang@intel.com, xudingke@huawei.com, jerry.lilijun@huawei.com, stable@dpdk.org References: <64117415a68e8c920efdf905f799b26dcbc3f8fb.1701415014.git.wangyunjian@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <64117415a68e8c920efdf905f799b26dcbc3f8fb.1701415014.git.wangyunjian@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0270.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB8148:EE_ X-MS-Office365-Filtering-Correlation-Id: ef6eed7e-1968-46d6-345f-08dbf4d2ae68 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LnJnj5y8m2ZHbDVQIRakkmchCN6OIQmwFxNjH3pL1ge0xdh/PA4/KpuINZCi8n6aWsBYmgsUEo1yq30uXEBSvNFYaoA7gBNBij8wKMoHcwBAMBshnBEtdXuKt4YN16ivBT9grIjBjaNSb+uO6hiRLrnA1yYIljRCypUMeDJvIQY4CHxSpDLHy+PPawqWVPmt8ckqJ6jaOVRw5pOuHJ7TNy54MRzlJHV0Bp0JxXc+zk9gSGaeRvqlWICPpf3SFVgDWHB9tnDsHOgVcA0bLuU5C7cEKNpGX1UZHkmp/GhE8q61A7AvNJSm97tw27tEgoA0c90USHwGziVd9zkNhquf1bStgxz3hqE9T2HUlA4Hwt+o52r2ipb+egerV17CfDdIxkY0q86xLS9jTBa8faWf+WUC4Mkd7C0kHB8xV/w98hV5N6028T8Ec803nNqG6dAljeSPJILDjyissfH7+oVzJxRQFQ7j8Nqx85eCvUJPN0MDUqngZIpo8MM+qtI7gNZUQEy6RR6SYNpoFcpD2R1n6H/dfQ+Z+iGxwOJVkMXrY5qebPxybbeGTJS4nnEN7gCSOj9LA85uhYaI64xcIl1cgydyi3UzSQ4ioaybyvesxA82hoc5LIHLB5uYdvEqo4215cRVHtDZHHArTs1v2pUsCw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(396003)(39860400002)(136003)(366004)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(31686004)(2616005)(4326008)(8676002)(8936002)(6512007)(6506007)(53546011)(26005)(6486002)(478600001)(6666004)(66476007)(66946007)(66556008)(316002)(2906002)(36756003)(41300700001)(38100700002)(44832011)(86362001)(31696002)(5660300002)(4744005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjYrTXlZWVNKSlB2a29MRXZuWmRBd0MvQmIrSlhwMEc1bmdaeUZuOFpIOGVp?= =?utf-8?B?ZkdsWGxtUmJRcnRMR2dqOVZiSTdXUlpJSmdOWmQ3VzhidmpJWkVWNWpxcmtO?= =?utf-8?B?MXEzc2xDTXRqYlg1WW5DZDRXZ1piR05BV2JGQ0c0TWVRVTlic2RTeUZCMjZV?= =?utf-8?B?Q3BIeDBvUTRGQUJJTUxoQm90WVZqSnduQll1WFJtRDhwUEpmWnJBdU9DL01J?= =?utf-8?B?YXRWYk45UnpHaWN5T1d1YjRQcjFxOGtGMjdPQm9FUUhyNnJsM0gxOGt2YlFQ?= =?utf-8?B?TVV3K2tUbUIvYWJaUVM1cW1CSVZrb0RFRi9tRTdUUkthQWY4WjN2djk1ZUgy?= =?utf-8?B?WVV2Tnl6R0s4ampNeGV4UjIvYTBSVzN2RmRhUytOMkI4cEovZmd0YU5sOFRi?= =?utf-8?B?eUtSdVUrOVlPK2ZXWllOa1NlTUZGV1BGUTd5RmEraWV5eEUzcllKeTJpMmxU?= =?utf-8?B?U0NUMFkreTJ1SnRxK2laRDNlNm1Dc1dFQzRzTDIxU1hZOWQzSGFUVEpqMlJP?= =?utf-8?B?Q0FJSGJIcW9vbEM5ZWtiajVraGRJdFk3Wkg0d3R1SmVhTlZuelQvK3BMR2d1?= =?utf-8?B?NFd2K2VjSXMwNDh5TWgzVklZUU9YZnlqdW1Vb25ZbTFmNXlya3lIdFY1eUV1?= =?utf-8?B?YkI2WDd5M3piNGVyM3YrSDZMajNtcEd5K0ozV0FXcDJKcEJMOUZXaDdTQVdM?= =?utf-8?B?bDU4eW8zaU1PcVlKRVNSTFQ3ekVKb1FCaFp3YUJnZUVSMUlNU1NDbnc1bHJw?= =?utf-8?B?aXJVMGxSWTQ0S0piNGd4bVhHVWlreEVhQUVGTzZTc2xTRFphMjhjdlM5cEwy?= =?utf-8?B?bnorTXlVMDkzaUsyeUl0T1dpZTIrbnFyZFpYOVh6amUzY1N2ekphSnpEVGRH?= =?utf-8?B?OHBrREtRM2N4NWxmSVZiNEU4Y1V2UlY1WTAyK1Bha0RJVVJaNXM5RmdaUVVU?= =?utf-8?B?ZG11UHNwOXVtMTkzdk91dEJOQWsxOGxOZVZGT1ZPMkZYU2ZGMFNCcXA1eWQr?= =?utf-8?B?MGpnRkRvcy9rQjBCcTNmbmpkQ3c4S0dtd1VpVHY5cW1ERCtNQkprM0ZQajFC?= =?utf-8?B?NVl1RzBNRUdTVGViMVpONHZZbDNZRnlEdnlvWlk2bHJ2YzNTZWpkZHRCK1Jk?= =?utf-8?B?eXJiOXloYktIUllsY0NmTVI4ak5WWmpLSFJCNVphOFdRVmFVWnE3M0tIMjJq?= =?utf-8?B?Y0hxRUx0bjJRdHU5eDdHZi9yNVNtNlUxNzR5bmNqaXdEdFg1RXk0QzYzZXV3?= =?utf-8?B?ZWtXLzhvTndWZ21acDhQTWc4SGlsNkk4ckNscTF2TzMyZGh2Y2tyS1JJNk80?= =?utf-8?B?NEIrYmpUK3lUWDdHcSt3RUNqcDJPSXNRdExvazVZaTZUVHZGdmRHZjFLY1Fj?= =?utf-8?B?eWRVVXUxazVkdFRVUjJQUDJyOGp0YWt0TFN0aHRzdFV4K1R6QnlxQkxQVFZw?= =?utf-8?B?Y1RSNzR1R2IrSGJoQktULzNTM2ZiVmJmdUhTb3Z6aEdqWXJXQVh4L1Jnd0pB?= =?utf-8?B?UjBUY3RUTTJFSFR3YTRidzV5bFlXZ2NPaUttR21sYlU3QkNrWjd1azFLVVM3?= =?utf-8?B?dkFBTk5vTUc5TFlGQUxiNGpwb0E1b29RcDBUc09hNG0wSG5TYjNRTFlKd3lk?= =?utf-8?B?SUV6YkRCK0gvc3JvaG5yVTl4bDBmNi8xZkpHSkVNRWRoZERrZzMwOEtLR2Zn?= =?utf-8?B?bTBva1RLWkhLMGJTWFVPTjlMQkZud0hJWkoyTTJXRDV0ejljZmV0TjM0aWxU?= =?utf-8?B?aUYyb0NVRXFsOW1rWkk2RVk1Wkp1T1RObmZXYjJSWVJ3M29tMWhMK3I5cHli?= =?utf-8?B?T1hRZHhhNTEwL2dzNUYzWGw2RmppUjYvbjkzb3N0NVIxMDJEUWFJM1dIUmN6?= =?utf-8?B?b2xpNUFpNEx6a0lGUzZYaXptcm81OEtIWGlKczY1bHM0a3RTRC9vSHdJQmhG?= =?utf-8?B?K0xuNVBpUWU1L0oxZmpzS013NCs3WmoyOXRRdE5seTRUWm5FbUg5djBYbnkz?= =?utf-8?B?cHl4VlRCbkN6QzFXU2RlektYc3VzTHgrN3RqYnd2UUsyajBGaFU4YTVIZWRq?= =?utf-8?B?aURVOEl4Z0dqWDdMV1FjVkdBRzNrWFJpbUdBeHEzYkxqNndTOUVhNDMzdXJ1?= =?utf-8?Q?IeNA=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef6eed7e-1968-46d6-345f-08dbf4d2ae68 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 14:09:51.2668 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bFj1OhYed1PAUECQt5dwCq3XN9fyEZeWNSz+zOoLK/jBIyQqEZfWuhh9DB6oiKvA X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8148 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/1/2023 8:03 AM, Yunjian Wang wrote: > In xdp_umem_configure() allocated memzone for the 'umem', we should > free it when xsk_umem__create() call fails, otherwise it will lead > to memory zone leak. > > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang > --- > drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c > index 2a20a6960c..2a1fdafb3c 100644 > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > @@ -1229,6 +1229,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals, > > if (ret) { > AF_XDP_LOG(ERR, "Failed to create umem\n"); > + rte_memzone_free(mz); > Doesn't 'xdp_umem_destroy()', in the label 'err', already free it? > goto err; > } > umem->mz = mz;