From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 747B5A09E4; Fri, 29 Jan 2021 13:37:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B53B92401DF; Fri, 29 Jan 2021 13:37:04 +0100 (CET) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by mails.dpdk.org (Postfix) with ESMTP id D4A862401D0 for ; Fri, 29 Jan 2021 13:37:03 +0100 (CET) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20210129123702euoutp016179e03085534426882b3a2fb1fbc64b~etC0p7xUc1586315863euoutp01X for ; Fri, 29 Jan 2021 12:37:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20210129123702euoutp016179e03085534426882b3a2fb1fbc64b~etC0p7xUc1586315863euoutp01X DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1611923822; bh=WS9ye0xbmRTU3o7cMusKz25w1LDSUF/SQJ0xMCvS0H4=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=VqGwL5J3NRVO9vqEuQ108AMR5nMvLGXowtssslq+sCjr61R2FSIiHJQYO6JRLJjnV g6xZNPLyMF93p8o3R+NjX8T62Pa7y4pZDGT3a+4rPp59o5j4EfksBJ/hwnT/zTqbKd 5jGWy8DI8DdxhU59yLdRYza3mnidTFDoz1lkY2Cc= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20210129123702eucas1p2b84a9ad52e8780cc6e5aae7f3fc40d0f~etC0aYaGO3073530735eucas1p2-; Fri, 29 Jan 2021 12:37:02 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id BD.1C.44805.E6104106; Fri, 29 Jan 2021 12:37:02 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20210129123701eucas1p19eb7812387cfc1f274d35c8b2acaad91~etCz35ClP0199401994eucas1p1W; Fri, 29 Jan 2021 12:37:01 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20210129123701eusmtrp136179e4c1d1646c135d54567caab1568~etCz3PryW2908329083eusmtrp1N; Fri, 29 Jan 2021 12:37:01 +0000 (GMT) X-AuditID: cbfec7f4-b4fff7000000af05-a3-6014016ed3c4 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 31.2E.16282.D6104106; Fri, 29 Jan 2021 12:37:01 +0000 (GMT) Received: from [106.210.134.142] (unknown [106.210.134.142]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20210129123700eusmtip1a1133662cf74bd9cceecc125cb7d4abe~etCyfEfTZ1209712097eusmtip1U; Fri, 29 Jan 2021 12:37:00 +0000 (GMT) To: David Marchand , David Hunt , Bruce Richardson Cc: dev , dpdk stable , "Ruifeng Wang (Arm Technology China)" , ci@dpdk.org From: Lukasz Wojciechowski Message-ID: Date: Fri, 29 Jan 2021 13:36:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTcRTH+917d70zZ9c582RPJtHbVw/Wy15iqyiKJMFerryY6GbtUVlh D8HKTE2R6RxqhWnhkErdsNSalo3QopKtWGW1ZopZ1qxM07peJf/7fM/5nt/5HvhRuDCf50fF KdSMUiFLEJPuRPXDvpYFCiSKDqpM8ZHYbqySdBd24JKM7B5MYixLIyXd34yYpDXDhksGzw24 rXaTlheWI+nv4hKe9OrdDkz6pa6V3EpEua+IYRLiDjPKwNBo9wPX39Sgg+2eRz9YPqFTqMAj DfEpoBeB4WUBSkPulJAuQzCUY8U44UKgz3wwIr4jyO+txUZHqr4/IrlGKYJrt5w4J3oQXMj9 gliXN70Lml25wy4RfQaBbsg+7MJZ8fpnE8G6SHolNOb38tIQRQnocMjOkLFlgp4JJZ2/eCz7 0Pvgtb1heLWA9gJLvmN4lE9vg9quepJlnJ4OKVUFOMe+8MpRNBLVTkGOJYLjMDD3G0mOvaGz qdKN4ynwOCedYLMBXY2gtb8PcaIegfVi2YhrOTQM9pNsUJyeAxU1gSwCvQaan3hz6Am2z15c BE/IrtbiXFkA51KF3BsB8DE9F41uHTA4iCwk1o05TDfmGN2YY3T/1xYj4gbyZTQqeSyjClEw RwJUMrlKo4gN2J8ov4X+/Z7Hg00uEyrt7AkwI4xCZgQULhYJPuuF0UJBjCzpGKNM3KvUJDAq M5pMEWJfwb7K8r1COlamZuIZ5iCjHO1iFN/vFJZaut4Y3JtUEfynTzcnUv7Hq63txG77tdCB spUTXX31NruHWf3VEbhmV+kmw/Y7hwTr5v3QVIeNn7ShdvLHmVPHOa1LQl2/3nWt3hEkNG9t G7J2xT2XL17rKCnImHTRY8OO+JYZUT0N+jre+84TRc5KR0pH+9ULQX5vu2wVSc8iawZW7fGp Nc3XPDE9yrJsuc8/a5knNRTdPrS2XWo6j04vC7/iz3feXHiy/0yeKtNgy14vyot+Ojs5F1MY X0TdO7a0UafNSt6+U5uiNl8e50yEjTmzgr9ZLVMvhZjin5JUqjZIFFHX3Qj+E8J/h8yPKn7V Fjpts+J4ep1e//Jw8jZtRIuYUB2QBc/FlSrZX75bbUysAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsVy+t/xu7q5jCIJBruW6lvcWGVv8W7eS2aL vkkfmSy2r+his3j3aTuTxdW+G8wW/zr+sDuwe6yZt4bR49eCpawei/e8ZPJ4v+8qWwBLlJ5N UX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1NSmpOZllqkb5dgl7Gynu7GAue 81U8PvmCsYFxNk8XIyeHhICJxNbPJ9i6GLk4hASWMko83drM1MXIAZSQkfhwSQCiRljiz7Uu qJr3jBJdS7YzgiSEBWIkzn6ZCpYQEWhhlLi89jwLiMMs0MQosaXhDhNEy0MmifeLdrGAtLAJ 2EocmfmVFWQFr4CbxKS+RJAwi4CqxNJXP1hBbFGBJIkTsz4xg9i8AoISJ2c+AWvlFAiU2Ptm PxuIzSxgJjFv80NmCFteonnrbChbXOLWk/lMExiFZiFpn4WkZRaSlllIWhYwsqxiFEktLc5N zy020itOzC0uzUvXS87P3cQIjLZtx35u2cG48tVHvUOMTByMhxglOJiVRHjfzhFKEOJNSays Si3Kjy8qzUktPsRoCvTPRGYp0eR8YLznlcQbmhmYGpqYWRqYWpoZK4nzmhxZEy8kkJ5Ykpqd mlqQWgTTx8TBKdXANC9XVDteroP1e2JH24WqixunXHF97Rf2abd5R17XrtTcKyE5O6UVRFkk //BfvjVzl2g2+7dJra2lVe5eboem796ao1XTkq0peqkzh1k/KnB9Sqlz/7vo47218SVMma9C ko7+FwjcJXKCeW/KRbmd++XOKp5xmnVYoaniy6Le7e8nWU2dKOPNeEg0pvFltrrIvIJFbaaG 934IqPdpb2a9Xd/798qpddacG9efsVJkeKB+5vI592PnHsYf+3rPnltkKWP+6brGTQ6p4v1C 9zNYmV3YPm2OvWejMOH3+u0tHCo23d9F1vpO7Je//uyMFBPLI6PK3tJdmRX2EoYrnl7hdrRa aZraW83ys6vV6akSS3FGoqEWc1FxIgAMwHRPPwMAAA== X-CMS-MailID: 20210129123701eucas1p19eb7812387cfc1f274d35c8b2acaad91 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20210119035921eucas1p1aaea0d68975ba9481f200912eb10a40e X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20210119035921eucas1p1aaea0d68975ba9481f200912eb10a40e References: <20210119035910.8324-1-l.wojciechow@partner.samsung.com> <20210119035910.8324-2-l.wojciechow@partner.samsung.com> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1 1/1] test/distributor: prevent return buffer overload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thank you guys! W dniu 29.01.2021 o 09:03, David Marchand pisze: > On Thu, Jan 28, 2021 at 3:10 PM David Marchand > wrote: >> On Tue, Jan 19, 2021 at 4:59 AM Lukasz Wojciechowski >> wrote: >>> The distributor library implementation uses a cyclic queue to store >>> packets returned from workers. These packets can be later collected >>> with rte_distributor_returned_pkts() call. >>> However the queue has limited capacity. It is able to contain only >>> 127 packets (RTE_DISTRIB_RETURNS_MASK). >>> >>> Big burst tests sent 1024 packets in 32 packets bursts without waiting >>> until they are processed by the distributor. In case when tests were >>> run with big number of worker threads, it happened that more than >>> 127 packets were returned from workers and put into cyclic queue. >>> This caused packets to be dropped by the queue, making them impossible >>> to be collected later with rte_distributor_returned_pkts() calls. >>> However the test waited for all packets to be returned infinitely. >>> >>> This patch fixes the big burst test by not allowing more than >>> queue capacity packets to be processed at the same time, making >>> impossible to drop any packets. >>> It also cleans up duplicated code in the same test. >>> >>> Bugzilla ID: 612 >>> Fixes: c0de0eb82e40 ("distributor: switch over to new API") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Lukasz Wojciechowski >> Tested-by: David Marchand > Reviewed-by: David Hunt > > Applied, thanks Lukasz. > > This should fix the issue seen at UNH on the ARM server. > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com