From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "Gaëtan Rivet" <grive@u256.net>, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC] devtools: improve DPDK review process
Date: Thu, 1 Apr 2021 13:05:14 +0100 [thread overview]
Message-ID: <b17f6445-3d33-ab39-b09b-40cc2cbe13ce@intel.com> (raw)
In-Reply-To: <64c13341-24db-4fb4-8e10-94cf509badba@www.fastmail.com>
On 01-Apr-21 10:50 AM, Gaëtan Rivet wrote:
> On Thu, Apr 1, 2021, at 11:05, Anatoly Burakov wrote:
>> A common problem on the DPDK mailing list is lack of reviewers for
>> patches. This script is intended to help with that problem, by picking
>> a random commit author from our git history, and adding a Reviewed-by:
>> tag. This can be added to e.g. commit-msg git hook, like so:
>>
>> # add reviewer to commit message
>> $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1
>>
>> Now all DPDK code will definitely be well reviewed!
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> Rеviеwеd-by: Thоmas Mоnjаlоn <thomas@monjalon.net>
>> ---
>> devtools/get-reviewer.sh | 4 ++++
>> 1 file changed, 4 insertions(+)
>> create mode 100755 devtools/get-reviewer.sh
>>
>> diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh
>> new file mode 100755
>> index 0000000000..f4b07c9862
>> --- /dev/null
>> +++ b/devtools/get-reviewer.sh
>> @@ -0,0 +1,4 @@
>> +#!/bin/sh
>> +
>> +# find a reviewer for the code
>> +git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1
>> --
>> 2.25.1
>>
>>
>
> I think this is great.
> However if you accelerate only one end of the pipe, you won't gain much.
>
> Humans are still required to write patches, this is inefficient.
> Here is a suggestion:
>
> diff --git a/devtools/infinite-monkey.sh b/devtools/infinite-monkey.sh
> new file mode 100755
> index 0000000000..7d637266d3
> --- /dev/null
> +++ b/devtools/infinite-monkey.sh
> @@ -0,0 +1,13 @@
> +#!/usr/bin/env sh
> +
> +command -v csmith > /dev/null || {
> + echo 'Require csmith: https://github.com/csmith-project/csmith'
> + exit 1
> +}
> +
> +until ninja -C build; do csmith > $(find . -name '*.c' |shuf -n 1); done
> +
> +git add -F .
> +git commit -sm "$(dirname file): $(($(date +%s%N)/1000000))" \
> + -sm '' -sm "$(./devtools/get-reviewer.sh)"
> +git send-email -1 --thread --to dev@dpdk.org
>
> With proper perf testing at the other end, DPDK should be able to finally become web-scale.
>
Yep, should be doable to achieve line rate for patches to DPDK!
--
Thanks,
Anatoly
next prev parent reply other threads:[~2021-04-01 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 9:05 Anatoly Burakov
2021-04-01 9:50 ` Gaëtan Rivet
2021-04-01 12:05 ` Burakov, Anatoly [this message]
2021-04-02 13:43 ` Jerin Jacob
2021-04-02 16:23 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b17f6445-3d33-ab39-b09b-40cc2cbe13ce@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).