From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1760A0548; Thu, 1 Apr 2021 14:05:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FA4B14110E; Thu, 1 Apr 2021 14:05:21 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 4711314110D for ; Thu, 1 Apr 2021 14:05:20 +0200 (CEST) IronPort-SDR: gL8xfoe1lU+raFQXVWx/4KL4TvxmxSKHCo76MMWT5InwZtlwSXtRP8t03SX0MzC0bQcKQJLBYl alxa8RarPTIA== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="179359567" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="179359567" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 05:05:19 -0700 IronPort-SDR: 7aXVxBx8iDFBzwLS4gT6zvTQcD0WUaS1CUuPn1YIlkpj7r6NtaZqjahTyygoC5ZB6CsCWjE03H DQVD58N33wZQ== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="596310965" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.250.93]) ([10.213.250.93]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 05:05:18 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , dev@dpdk.org References: <20210401090516.209155-1-anatoly.burakov@intel.com> <64c13341-24db-4fb4-8e10-94cf509badba@www.fastmail.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 1 Apr 2021 13:05:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <64c13341-24db-4fb4-8e10-94cf509badba@www.fastmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC] devtools: improve DPDK review process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01-Apr-21 10:50 AM, Gaëtan Rivet wrote: > On Thu, Apr 1, 2021, at 11:05, Anatoly Burakov wrote: >> A common problem on the DPDK mailing list is lack of reviewers for >> patches. This script is intended to help with that problem, by picking >> a random commit author from our git history, and adding a Reviewed-by: >> tag. This can be added to e.g. commit-msg git hook, like so: >> >> # add reviewer to commit message >> $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1 >> >> Now all DPDK code will definitely be well reviewed! >> >> Signed-off-by: Anatoly Burakov >> Rеviеwеd-by: Thоmas Mоnjаlоn >> --- >> devtools/get-reviewer.sh | 4 ++++ >> 1 file changed, 4 insertions(+) >> create mode 100755 devtools/get-reviewer.sh >> >> diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh >> new file mode 100755 >> index 0000000000..f4b07c9862 >> --- /dev/null >> +++ b/devtools/get-reviewer.sh >> @@ -0,0 +1,4 @@ >> +#!/bin/sh >> + >> +# find a reviewer for the code >> +git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1 >> -- >> 2.25.1 >> >> > > I think this is great. > However if you accelerate only one end of the pipe, you won't gain much. > > Humans are still required to write patches, this is inefficient. > Here is a suggestion: > > diff --git a/devtools/infinite-monkey.sh b/devtools/infinite-monkey.sh > new file mode 100755 > index 0000000000..7d637266d3 > --- /dev/null > +++ b/devtools/infinite-monkey.sh > @@ -0,0 +1,13 @@ > +#!/usr/bin/env sh > + > +command -v csmith > /dev/null || { > + echo 'Require csmith: https://github.com/csmith-project/csmith' > + exit 1 > +} > + > +until ninja -C build; do csmith > $(find . -name '*.c' |shuf -n 1); done > + > +git add -F . > +git commit -sm "$(dirname file): $(($(date +%s%N)/1000000))" \ > + -sm '' -sm "$(./devtools/get-reviewer.sh)" > +git send-email -1 --thread --to dev@dpdk.org > > With proper perf testing at the other end, DPDK should be able to finally become web-scale. > Yep, should be doable to achieve line rate for patches to DPDK! -- Thanks, Anatoly