From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0522CA052A; Fri, 25 Dec 2020 06:28:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A13A7CA1A; Fri, 25 Dec 2020 06:28:04 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E6080CA16 for ; Fri, 25 Dec 2020 06:28:02 +0100 (CET) IronPort-SDR: myhB0oFF5nMZkVHAwiZzv88ODQGIbCFGFYWxBhQHFkVrybQ6EETIBAsppCHKEpKyYveZKxc/a3 +QWMt/btYjMw== X-IronPort-AV: E=McAfee;i="6000,8403,9845"; a="176350447" X-IronPort-AV: E=Sophos;i="5.78,447,1599548400"; d="scan'208";a="176350447" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Dec 2020 21:28:01 -0800 IronPort-SDR: sCFkGBHYS3Hme14cImbrJKoj/WaC1ObzIrwuzur99BLzyIT+vaRs7kXeR3g5hsLsFiaKdciFmL VuV01Bhuf9iQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,447,1599548400"; d="scan'208";a="562020356" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 24 Dec 2020 21:28:01 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 24 Dec 2020 21:28:00 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 25 Dec 2020 13:27:58 +0800 Received: from shsmsx605.ccr.corp.intel.com ([10.109.6.215]) by SHSMSX605.ccr.corp.intel.com ([10.109.6.215]) with mapi id 15.01.1713.004; Fri, 25 Dec 2020 13:27:58 +0800 From: "Cao, Yahui" To: "Yan, Zhirun" , "dev@dpdk.org" , "Zhang, Qi Z" , "Wang, Xiao W" , "Guo, Junfeng" CC: "Su, Simei" , "Xu, Ting" , "Zhang, Yuying" Thread-Topic: [PATCH v1 3/5] net/ice: add outer input set mask to distinguish outer fields Thread-Index: AQHW12Zh0dOp4bm6LUm2rRUO+U/ca6oHTPrA Date: Fri, 25 Dec 2020 05:27:58 +0000 Message-ID: References: <20201221065150.1600719-1-zhirun.yan@intel.com> <20201221065150.1600719-4-zhirun.yan@intel.com> In-Reply-To: <20201221065150.1600719-4-zhirun.yan@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 3/5] net/ice: add outer input set mask to distinguish outer fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yan, Zhirun > Sent: Monday, December 21, 2020 2:52 PM > To: dev@dpdk.org; Zhang, Qi Z ; Cao, Yahui ; Wang, Xiao W ; > Guo, Junfeng > Cc: Su, Simei ; Xu, Ting ; Zhang, = Yuying ; Yan, Zhirun > > Subject: [PATCH v1 3/5] net/ice: add outer input set mask to distinguish = outer fields >=20 > Add 64-bit input_set_mask_f for outer input set. input_set_mask_f is > used for inner fields or non-tunnel fields. Adjust indentation of > ice_pattern_match_item list in switch, RSS and FDIR for easy > review. For fields in tunnel layer, like GTPU TEID, put them in > outer part. >=20 > Signed-off-by: Zhirun Yan > --- > drivers/net/ice/ice_fdir_filter.c | 110 ++++----- > drivers/net/ice/ice_generic_flow.h | 1 + > drivers/net/ice/ice_hash.c | 192 ++++++--------- > drivers/net/ice/ice_switch_filter.c | 348 ++++++++++------------------ > 4 files changed, 231 insertions(+), 420 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir= _filter.c > index 1f2576a444..76e0a8df38 100644 > --- a/drivers/net/ice/ice_fdir_filter.c > +++ b/drivers/net/ice/ice_fdir_filter.c > @@ -55,92 +55,74 @@ >=20 ... > + {pattern_eth_ipv4, ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV4, ICE_I= NSET_NONE}, > + {pattern_eth_ipv4_udp, ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV4_UDP, = ICE_INSET_NONE}, > + {pattern_eth_ipv4_tcp, ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV4_TCP= , ICE_INSET_NONE}, > + {pattern_eth_ipv4_sctp, ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV4_SCT= P, ICE_INSET_NONE}, > + {pattern_eth_ipv6, ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV6, ICE_I= NSET_NONE}, > + {pattern_eth_ipv6_udp, ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV6_UDP,= ICE_INSET_NONE}, > + {pattern_eth_ipv6_tcp, ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV6_TCP= , ICE_INSET_NONE}, > + {pattern_eth_ipv6_sctp, ICE_INSET_NONE, ICE_FDIR_INSET_ETH_IPV6_SCT= P, ICE_INSET_NONE}, > + {pattern_eth_ipv4_udp_vxlan_ipv4, ICE_INSET_NONE, ICE_FDIR_INSET_VXL= AN_IPV4_L, ICE_INSET_NONE}, > + {pattern_eth_ipv4_udp_vxlan_ipv4_udp, ICE_INSET_NONE, ICE_FDIR_INSET_= VXLAN_IPV4_UDP_L, ICE_INSET_NONE}, > + {pattern_eth_ipv4_udp_vxlan_ipv4_tcp, ICE_INSET_NONE, ICE_FDIR_INSET_= VXLAN_IPV4_TCP_L, ICE_INSET_NONE}, > + {pattern_eth_ipv4_udp_vxlan_ipv4_sctp, ICE_INSET_NONE, ICE_FDIR_INSET= _VXLAN_IPV4_SCTP_L, ICE_INSET_NONE}, > + {pattern_eth_ipv4_udp_vxlan_eth_ipv4, ICE_INSET_NONE, ICE_FDIR_INSET= _VXLAN_IPV4_L, ICE_INSET_NONE}, > + {pattern_eth_ipv4_udp_vxlan_eth_ipv4_udp, ICE_INSET_NONE, ICE_FDIR_IN= SET_VXLAN_IPV4_UDP_L, ICE_INSET_NONE}, > + {pattern_eth_ipv4_udp_vxlan_eth_ipv4_tcp, ICE_INSET_NONE, ICE_FDIR_IN= SET_VXLAN_IPV4_TCP_L, ICE_INSET_NONE}, > + {pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp, ICE_INSET_NONE, ICE_FDIR_I= NSET_VXLAN_IPV4_SCTP_L, ICE_INSET_NONE}, > }; >=20 [Cao, Yahui] Why is the mask put in the 3rd column instead of 2nd column ? = I prefer the way that 2nd column is for outer field and 3rd column is for i= nner field. >=20 > static int > -- > 2.25.1