Re: [dpdk-dev] [RFC] remove unused functions

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 19-Nov-20 3:52 AM, Ferruh Yigit wrote:
> Removing unused functions, reported by cppcheck.
> 
> Easy way to remove clutter, since the code is already in the git repo,
> they can be added back when needed.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---

<snip>

> diff --git a/lib/librte_eal/linux/eal_memory.c b/lib/librte_eal/linux/eal_memory.c
> index 03a4f2dd2d..4480e5249a 100644
> --- a/lib/librte_eal/linux/eal_memory.c
> +++ b/lib/librte_eal/linux/eal_memory.c
> @@ -238,14 +238,6 @@ static int huge_wrap_sigsetjmp(void)
>   	return sigsetjmp(huge_jmpenv, 1);
>   }
>   
> -#ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES
> -/* Callback for numa library. */
> -void numa_error(char *where)
> -{
> -	RTE_LOG(ERR, EAL, "%s failed: %s\n", where, strerror(errno));
> -}
> -#endif
> -
>   /*
>    * Mmap all hugepages of hugepage table: it first open a file in
>    * hugetlbfs, then mmap() hugepage_sz data in it. If orig is set, the

 From looking at git history, this function looks to be accidentally 
added, perhaps an artifact of earlier implementation.

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly