From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98857A054A; Thu, 11 Feb 2021 12:30:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2945D1CC4D8; Thu, 11 Feb 2021 12:30:07 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id E7BEE1CC4D9 for ; Thu, 11 Feb 2021 12:30:04 +0100 (CET) IronPort-SDR: CpOPV5lj9ioikVvXSP55kz7AJ9xsYgPP6K2F9wJovGAUWraXomu5KHTdjB38buDQJdq8ebw+vt pG0GrUCp7a4g== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="161975185" X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="161975185" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 03:30:00 -0800 IronPort-SDR: sbU687FUe4dPreUCesP96oGel3gfjhBrUShXM9Ip4eY3wCL9wrqotlZDiWmwUy2gqHd1BcBZiF ACu07FdMxxJw== X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="380564426" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.21.217]) ([10.252.21.217]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 03:29:49 -0800 To: Ferruh Yigit , Jerin Jacob , Cristian Dumitrescu , Hemant Agrawal , Sachin Saxena , Ray Kinsella , Neil Horman , Rosen Xu , Jingjing Wu , Beilei Xing , Nithin Dabilpuram , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Gagandeep Singh , Somalapuram Amaranath , Akhil Goyal , Jay Zhou , Timothy McDaniel , Liang Ma , Peter Mccarthy , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Rasesh Mody , Shahed Shaikh , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Rahul Lakkireddy , Jeff Guo , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Qi Zhang , Xiao Wang , Qiming Yang , Alfredo Cardigliano , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Heinrich Kuhn , Harman Kalra , Kiran Kumar K , Andrew Rybchenko , Jasvinder Singh , Jiawen Wu , Jian Wang , Tianfei zhang , Ori Kam , Guy Kaneti , Maxime Coquelin , Chenbo Xia Cc: dev@dpdk.org References: <20201119035238.3653702-1-ferruh.yigit@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 11 Feb 2021 11:29:48 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201119035238.3653702-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] remove unused functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19-Nov-20 3:52 AM, Ferruh Yigit wrote: > Removing unused functions, reported by cppcheck. > > Easy way to remove clutter, since the code is already in the git repo, > they can be added back when needed. > > Signed-off-by: Ferruh Yigit > --- > diff --git a/lib/librte_eal/linux/eal_memory.c b/lib/librte_eal/linux/eal_memory.c > index 03a4f2dd2d..4480e5249a 100644 > --- a/lib/librte_eal/linux/eal_memory.c > +++ b/lib/librte_eal/linux/eal_memory.c > @@ -238,14 +238,6 @@ static int huge_wrap_sigsetjmp(void) > return sigsetjmp(huge_jmpenv, 1); > } > > -#ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES > -/* Callback for numa library. */ > -void numa_error(char *where) > -{ > - RTE_LOG(ERR, EAL, "%s failed: %s\n", where, strerror(errno)); > -} > -#endif > - > /* > * Mmap all hugepages of hugepage table: it first open a file in > * hugetlbfs, then mmap() hugepage_sz data in it. If orig is set, the From looking at git history, this function looks to be accidentally added, perhaps an artifact of earlier implementation. Acked-by: Anatoly Burakov -- Thanks, Anatoly