From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BD44439BE; Thu, 25 Jan 2024 08:10:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E9A74029B; Thu, 25 Jan 2024 08:10:20 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id EE8964027B; Thu, 25 Jan 2024 08:10:17 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E22DA59; Thu, 25 Jan 2024 10:10:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E22DA59 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1706166616; bh=V2ZqnDHcKDO27RrqsaN1Nqa4bDucMuyshfzT5twQo4o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=vbuuAuPV/UKIJWNAM6fbInPCr9zHZl17rDOrpO8IIOd+hMttO6btR640Ih0139lCZ NdA5iyvrLeQbjpw/JCrTigo0y6h7y6Gf70OvI3LGT8H1uyOz49pKhOGfmo0i0ScTg3 j5mjEHdm31wANBap/p21410VxMeUmhVZfj30bk/4= Message-ID: Date: Thu, 25 Jan 2024 10:10:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 8/8] net/sfc: fix calloc parameters Content-Language: en-US To: =?UTF-8?Q?Morten_Br=C3=B8rup?= , Ferruh Yigit , Andy Moreton , Ivan Malov Cc: dev@dpdk.org, stable@dpdk.org References: <20231102130847.3367102-1-ferruh.yigit@amd.com> <20240124185406.3598985-1-ferruh.yigit@amd.com> <20240124185406.3598985-8-ferruh.yigit@amd.com> <98CBD80474FA8B44BF855DF32C47DC35E9F19A@smartserver.smartshare.dk> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F19A@smartserver.smartshare.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/24/24 22:02, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yigit@amd.com] >> Sent: Wednesday, 24 January 2024 19.54 >> >> gcc [1] generates warning [2] about rte_calloc usage, because >> rte_calloc parameter order is wrong, fixing it by replacing parameters. >> >> [1] >> gcc (GCC) 14.0.1 20240124 (experimental) >> >> [2] >> Compiling C object drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_mae.c.o >> ../net/sfc/sfc_mae.c: In function ‘sfc_mae_action_set_list_add’: >> ../drivers/net/sfc/sfc_mae.c:1353:35: >> warning: ‘rte_calloc’ sizes specified with ‘sizeof’ in the earlier >> argument and not in the later argument [-Wcalloc-transposed-args] >> 1353 | sizeof(struct sfc_mae_action_set *), >> | ^~~~~~ >> >> Fixes: 002f591f54c3 ("net/sfc: support packet replay in transfer >> flows") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ferruh Yigit >> --- > > Acked-by: Morten Brørup > Reviewed-by: Andrew Rybchenko