From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F1DDA054F; Tue, 2 Mar 2021 13:10:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAC684014E; Tue, 2 Mar 2021 13:10:53 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 7F9B840142; Tue, 2 Mar 2021 13:10:51 +0100 (CET) IronPort-SDR: QjDbZdL4gsgi1fH+R297WQIkdypVFAfBl7DAhx2HE16nLr+Sa3yiNxpAIf59tDI/dH9CTeNDeV 7vEZSlbVTMiQ== X-IronPort-AV: E=McAfee;i="6000,8403,9910"; a="173931769" X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="173931769" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2021 04:10:47 -0800 IronPort-SDR: kcwWYEBeKVgw4pM09xzSj8eVGZ6aWzyn0y2tIqHZ2hVM4FHxZCs/QucqYm17PQdcINXmyZsMdF 2PY8GgT63ppA== X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="406682215" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.252.162]) ([10.213.252.162]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2021 04:10:45 -0800 From: Ferruh Yigit To: Chas Williams , "Min Hu (Connor)" , Liang Zhang Cc: dev@dpdk.org, Vadim Podovinnikov , stable@dpdk.org, Declan Doherty References: <20191126115508.11138-1-podovinnikov@protei.ru> <20210217162656.1983277-1-ferruh.yigit@intel.com> X-User: ferruhy Message-ID: Date: Tue, 2 Mar 2021 12:10:41 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3] net/bonding: fix LACP system address check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/17/2021 4:30 PM, Ferruh Yigit wrote: > On 2/17/2021 4:26 PM, Ferruh Yigit wrote: >> From: Vadim Podovinnikov >> >> In bond (LACP) we have several NICs (ports), when we have negotiation >> with peer about what port we prefer, we send information about what >> system we preferred in partner system name field. Peer also sends us >> what partner system name it prefer. >> >> When we receive a message from it we must compare its preferred system >> name with our system name, but not with our port mac address >> >> In my test I have several problems with that: >> 1. If master port (mac address same as system address) shuts down (I >>     have two ports) I loose connection >> 2. If secondary port (mac address not same as system address) receives >>     message before master port, my connection is not established. >> >> Fixes: 56cbc0817399 ("net/bonding: fix LACP negotiation") >> Cc: stable@dpdk.org >> >> Signed-off-by: Vadim Podovinnikov >> --- >> Cc: zhangliang@bigo.sg >> Cc: Declan Doherty >> >> v3: Re-sent with rebase >> * Patch title updated, commit log updated with info shared in email >> * Sign-off updated with full name >> * Debug log slightly updated >> * Syntax slightly updated > > This patch is waiting for review for a long time, if there is no objection I am > planning to get it early in the release to give it a time to fix any possible > issues. Chas, Connor, any comment?