From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11BD4A0093; Fri, 7 Oct 2022 12:31:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3A14427EE; Fri, 7 Oct 2022 12:31:06 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 9091F40042 for ; Fri, 7 Oct 2022 12:31:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665138665; x=1696674665; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Z79AbJZ8XwQyJty8W5Urjv2vQzpiSfr7Nsk1oTcqGcU=; b=fjhJEPXz0v0GV5MjT0ArL67w0W88ylLKz6AL2DtzG2KJ62T1LZaUm9pK tmD5cY5+98ebX83IhbrhDneuee4t93ia4UP8Ly798Gj+Q6iVty1brS/BX LJx3A6HHuOdrtZpOpa1bTfqYdUdldt8394ptUP5w8gWYC0N0jzpRXl51L YzuYQC5koa+XqJqRjv7w3cFuXcZOQbkvbU3xJvORsoeLvi1IoAErr59yV m3WCDWrYrfDugXNjGZ3caQQTPFUVDeRzcJDyT6UtE1TbJLc+sZpYhrLAN qIRYZLtpqMkJcZafSGnTaweoQPb9HtWoaezqaYYFEYR6gJb7+GhaKE4y3 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="304704877" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="304704877" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2022 03:31:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="954024589" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="954024589" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 07 Oct 2022 03:31:03 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 7 Oct 2022 03:31:03 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 7 Oct 2022 03:31:03 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 7 Oct 2022 03:31:03 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 7 Oct 2022 03:31:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X30NhUi9axCE/5/9UlqiEW2h1arnp93rgAXSb/1sgY4Bb/x1uyrsJKko1lthMorVpehtBYS04wYUoH2T0sjCIdygbtPROKOrmu0HAzsZbl0eYJKWz5LRCC0mtu8p5P3IVen97DyIoFYn3BTurjw1uXtu5ZRCbxNbtWqaJ1nYK1nkpZLaIHUxmuNzjkJLGsfjZMIWlwR7Nngo9aynNrEeinjdBDwe0GwMpmJhkn1BjlR+YRBCBNeQNi8muEWSMCAHzFvDPjUDZGvX6UkXRJW0ROAEPLoS517P1T8cxU73868QZ6wVxL7MtV5uoYr3n+ZqMEVEwTdnURlOvcITMK1D8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQx83C2KoUWWwyCsd5Rvcy0FPE6tlsosVf5r+4EqNiw=; b=Odz2z7+plw9c3GK2AW6TrWWYQb/MuK44sJOEBD5eEvVueFacq23jRkkDygrZNrmx5Spq/+sRgegbE4PfHUlWTR/CZ73r9CFKR6+NwNSLBFFRdV+Q23cw+2hxmikaFDEUlYN1bqGzEHgKlyc9VmmP8OSOPX0az0AJ/zE8yXVqn7Kw9rdJFOelh9IAmNtJbXjbynPrfgaXvIhH2gOkefOjqz+xP+ACe8jOctupuclFhmS13X2wW0vZHh2ToJrdJWHL0FmR9bXEX+ObonHIHmYIBGP2PXmSGQkw3abTNHXa2yofLLDrjIpN645mNPIExQ2gJwVbn6oQQC+Lae6cwu8G7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) by SA2PR11MB4873.namprd11.prod.outlook.com (2603:10b6:806:113::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct 2022 10:31:00 +0000 Received: from BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::2a3b:7b9f:8bce:711f]) by BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::2a3b:7b9f:8bce:711f%4]) with mapi id 15.20.5676.031; Fri, 7 Oct 2022 10:31:00 +0000 Message-ID: Date: Fri, 7 Oct 2022 11:30:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v9 1/3] power: add Intel uncore frequency control API to power library Content-Language: en-US To: Stephen Hemminger , Tadhg Kearney CC: , , , References: <20221005162023.1923558-1-tadhg.kearney@intel.com> <20221006093803.2076768-1-tadhg.kearney@intel.com> <20221006093803.2076768-2-tadhg.kearney@intel.com> <20221006103201.0f6da67d@hermes.local> From: "Hunt, David" In-Reply-To: <20221006103201.0f6da67d@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::27) To BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR11MB3799:EE_|SA2PR11MB4873:EE_ X-MS-Office365-Filtering-Correlation-Id: dbf56ab2-53ce-4bcd-5b98-08daa84f0702 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VXm7b/ghVbY2waUkzhxUevvjsdh3PfV+o0aO1qG+3XZfdE/5ioX7CJN+TCHCPoZRbwWaRhIYzjPa0Hwj7puNREQwQcLNIL5kCRpPvNFl2o9X+dtKI2Wu6OsCVXTWyndOLzOSwxCdrty00m6Jwyx/UPTJ8CzLgol4CZTfByBGdmZJyWgOsq2WO9QEjKR7ywv0AYudGlemHwfiVHq2XUyArQnlDt9NIw0OPR/aQ/Emn8Gqy7rUH0FTTXEOv+gHmqBk4PDEDpj5Bwd0i0rj+JYrYsKo0m5W8+POxIU43RUqbY4h23JhLxXOlAG+1e8iZ4vYu0/QRakMELW+GLb84sEaEsIaDUVkdzGOjAjvYuFOTpkuJ06VWMCdZE324UTTeMTkbB8JSl3uD8OXyYFHOBUFQtnXYt9A+PsX+2uOa/8uus842LvRlAAQNqE7UaDvgeOxHpPLGezcTkfVe2brntoYbOvet84ioa+Bjy1ZQhkLWI9xqfP14epKjTDM7ckyQkNITQ8QyLGH+Ink0T7W1FDskpC6GVRyuwhPFpWZLOabnPDeal4VEUmJVYPmcF5LFZ15yXdFO9coyyYyP+5jOZyT9jUJxwmT0Od8ErI92Wrem6aPwOkvPp49X2ZFgocukUAfxP/bbEpshgOV2fEv2uQEHcxj2jMHIHaFltFZkXwTZGOyao6Otp+RiPmBH2IcpLg4g1gMM7rKZjCpX5EELtvt/cdVhpod72t9vhu1+1Z2vin14f4GSmxboZdTruckky3pn5Dg3vZrJfpr5mD2tqfjpK1MUIYhQ7oFyrfmiDZ8A40= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3799.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(136003)(366004)(39860400002)(396003)(451199015)(36756003)(31686004)(86362001)(38100700002)(186003)(31696002)(83380400001)(6486002)(26005)(2616005)(478600001)(2906002)(6512007)(6506007)(53546011)(316002)(110136005)(5660300002)(4326008)(41300700001)(82960400001)(8936002)(66476007)(6666004)(66946007)(66556008)(8676002)(6636002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDRUUEtZelZHQWh2SlhmQU5OclcvbkNRNVd5MEJqZkVFb3hyajdxOW8vWStr?= =?utf-8?B?ODl6d2VmUmpOeHBNd2w4bG83ZjQrZW5vVXRKU0xLWDQ2VUllUHFlc00vSjJF?= =?utf-8?B?NHBRQnlCS1pqTjVjdzQyNXVVSTA0MkcvdTVnQTBGSkgwamdsWTZCM0svbVFu?= =?utf-8?B?OVZYYUZvL0tTZU80RlNNTVZTZGJMeUFGdHcyVTZaT25Tc2liL1dEdnc1d1d3?= =?utf-8?B?VmJ4L1dMb1JRTWs0cTJLYVloK3JjSGF2eDhBUVNnTGMwZ2thT1c1QjF0QVpW?= =?utf-8?B?MHZLSXlTVzNDbDVRMkFUOFNhRDNTd1JWbDBveU9BK04wOU5FRkFYZkZ4aG5C?= =?utf-8?B?RnNHZVR6WENXTDJRc0Z6VXNYRENEK1oyZHBSbFFaMmp5ekdvdUxYMEZOUU5I?= =?utf-8?B?REZBek8rc0t6V2wzUXFZYVNQNHdwZkUrb0Z3SzdsNHNQd3BuMFJvcUF4aDZ4?= =?utf-8?B?MFpJdURJeTJEeGhMVHgrMmJlclJyaFczLzR6S1loWkFUOEhwT3pVSkF2dDIr?= =?utf-8?B?MlhsV0htMVppRXYvdjFsaUplak9zUUV1WGdvV2dxZzl4L1BIazQzOVJCWE5z?= =?utf-8?B?emtxQ1ZCM2l1RFJnbE4zeHcxK2xqeU5VdGQyaGdRZ1d6YlFFMjBidjlveU80?= =?utf-8?B?TGFOY0FOdGlBV3pUZEpHWDlGQmZEdGh6eHVCRU5XYTYrRTZJVE5RaHh5VG4v?= =?utf-8?B?WlB3WEdOWEY0ZmdrV2lpNGw5dzRIN0JuSXJjYUh3RlZvQUR0c1E0QWgwSVQr?= =?utf-8?B?SldsK2FXSHhZMzlYeU9KRGQ3NWJuWTY5c0w3TlFZcFFZeG9ZVjV2NE1vT0Vz?= =?utf-8?B?T1ZSN1dhLzFKZjVuQ0NBdG5LV0RBcG5IdHlUQXEyTnN6YzF5YzJDWi9EOVVS?= =?utf-8?B?QWJsci9RRjJCdWx1dS94YUs3TWZqUGpQcEdQVTE0bHV0SjJrb0NMS3JZL1Rl?= =?utf-8?B?SHJIbVh3RkpWOEVaNzVZRXd3WXA0eDZNQjJoZGxJSHhkYzJPemNpYzk1dFJE?= =?utf-8?B?L2hrZjJrNWc2TlRKTm5rNnVSQmx1Tm83ZHhpQ2FDT2hyNThSWURqSmRNOUVu?= =?utf-8?B?S0tJN1hLU1V6WElmRFZkSi9GQ1RVd1FoZnpNTGxockViRnJFd2VqblBwTDRx?= =?utf-8?B?UEU4VHBGUzNXYjBxL0EvaVFiT0tzdDJYV2dIQm5mMlRyOWRzN2hrTGcxanQz?= =?utf-8?B?VVk5SldMcDJiaXkwb3RvMVc2UHlmc0JTOFQ1QmR0MEtpL3BOUTA3c0p3VEFm?= =?utf-8?B?dmNZb3dlQ0xwNUQzaUtQK2JPeGRvMkRXU09NenY5R1BSdGhsaWtYaVFKZGJm?= =?utf-8?B?S3RQK25zQ2h0U2IrV1JjdXpBcG5TYU9xLzAwdGU5UTd0TUYxWHIwd3JxUlZE?= =?utf-8?B?V3Rqa3JON295S3J3bzQ3QlMyTmxhSmxsRjFrR2YrbGlsbWlHMURLWjRnaHVI?= =?utf-8?B?UXBLQ3pPd01vMElaQUwwczRNRktmdTVYYlBVbWVLQTR4UnlSYjVUYVFBNkFp?= =?utf-8?B?ZmwxeEg0aXY0V1pIMEc0Mzk4a1FtNEVjelU0c1psUnlaODhHYW1qbjJrVUFK?= =?utf-8?B?QUFmdy9PQlk5WEpXVm1MNGlZREVlam1JM1NjSVF1R0xidUg1dGVUT2wzdHJ3?= =?utf-8?B?UlN3eUY5N2tabkc3NFlYWE9qZmVXak0wMHl6cHFlS0VDM1k5UGRKdFphT25x?= =?utf-8?B?RzNZNGVNZ1ovUUx6ZllHV21JendEUHk4SFYvdi9yUmFGaG5BWVYvbnpPRkJK?= =?utf-8?B?KzZQWVlXUVh3ZFp3eEV3Z1ZxeFh2MjZBVHpwRE9ncDV0S2htK2ZTV3pzRVU3?= =?utf-8?B?aUVHZ0hsaWZOUUhLNmJhR3ltRmJLR01jc1p0NzRnNkJUNStTRk1rR0pOcDZ4?= =?utf-8?B?Tmp5MStqUVd6cjRDWllncEQvbVZxWGZ3Um1IbnBLL1BHY1dINTlYNHJPUEk1?= =?utf-8?B?L3FQOEJWMWxKWmZNTklrQ21SUVVRazZVMG82WDQwY3pMVUpvMGlFL05DQ2h5?= =?utf-8?B?QWdQVVlic0pDejRvb3J5YmpLQXU4NENyakVBRGZROE1uSk8yZ05FVDZ2cGo2?= =?utf-8?B?QzF1YnFVYUgyN2ZsYjIvOEJOUXpUUXdpcEhqRVUzaStzclRjTjdsQVcwMEhu?= =?utf-8?Q?pQGDGLYkYkEL4AHFvIk2OaFrq?= X-MS-Exchange-CrossTenant-Network-Message-Id: dbf56ab2-53ce-4bcd-5b98-08daa84f0702 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3799.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 10:31:00.2480 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8F899/G5fO70ud9541fVfU2utvFZMrE6onLLNuaz3hC8pJXLRO1CJyof7VBRTDxp7CJfrNq4jY7n3ksnl2SuqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4873 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 06/10/2022 18:32, Stephen Hemminger wrote: > On Thu, 6 Oct 2022 09:38:01 +0000 > Tadhg Kearney wrote: > >> Add API to allow uncore frequency adjustment. Uncore is a >> term used by Intel to describe function of a microprocessor >> that are closely connected to the core to achieve high >> performance. This is done through manipulating related >> uncore frequency control sysfs entries to adjust the >> minimum and maximum uncore frequency values and works >> on Linux for Intel hardware. >> >> Signed-off-by: Tadhg Kearney >> Reviewed-by: David Hunt >> Acked-by: David Hunt Hi Stephen, > Looks like this is missing an opportunity for a more general > long term solution in DPDK. We're hoping that this is the first step along the path to that long-term solution. It's like the power library frequency control for cores, which was initially Intel only, and then more architectures were added over time. The API's are experimental, so can be adapted if needed. > Shouldn't this be a general thing like the Linux kernel scheduler. I don't think the kernel scheduler has any concept of uncore busyness, the uncore frequency is typically controlled by hardware, and if there's enough polling going on, the frequency of the uncore will remain high (if uncore frequency scaling is enabled). We're addressing that in this patch in that if the application realises that it's not processing a lot of packets even though most of it's cores are polling, it can tell the hardware to scale down the uncore to save power. > Uncore is Intel specific, but there is already big/little cores > on many ARM platforms. I don't think big/little is related to uncore frequency scaling. The big/little cores still need to communicate via that architecture's communications bus (called uncore in Intel's case, though I've seen that term used on other architectures also). Where an architecture can scale the frequency of this communications bus, this patch set's functionality can be extended in the future to cover this. Regards, Dave