From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 458553989 for ; Fri, 9 Dec 2016 18:35:05 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 09 Dec 2016 09:34:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="1079793353" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by fmsmga001.fm.intel.com with ESMTP; 09 Dec 2016 09:34:57 -0800 To: Andrew Rybchenko , dev@dpdk.org References: <1480664691-26561-1-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: Date: Fri, 9 Dec 2016 17:34:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480664691-26561-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 00/31] Support more features in Solarflare PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 17:35:06 -0000 On 12/2/2016 7:44 AM, Andrew Rybchenko wrote: > The patch series adds a number of features to Solarflare libefx-based > PMD. Basically one patch per feature. > > The patches are grouped into one series since they touch nearby lines > in either PMD feature list, or dev_ops structure, or documentation. > So, patches cannot be applied in arbitrary order. > > The patch series should be applied after > [PATCH v2 00/55] Solarflare libefx-based PMD > (Message-ID: 1480436367-20749-1-git-send-email-arybchenko@solarflare.com) > > > Andrew Rybchenko (16): > net/sfc: implement MCDI logging callback > net/sfc: support parameter to choose performance profile > net/sfc: implement ethdev hook to get basic statistics > net/sfc: support extended statistics > net/sfc: support flow control settings get/set > net/sfc: support link status change interrupt > net/sfc: implement device operation to change MTU > net/sfc: support link speed and duplex settings > net/sfc: support checksum offloads on receive > net/sfc: handle received packet type info provided by HW > net/sfc: support callback to get receive queue information > net/sfc: support Rx free threshold > net/sfc: add callback to get RxQ pending descriptors count > net/sfc: add RxQ descriptor done callback > net/sfc: support scattered Rx DMA > net/sfc: support deferred start of receive queues > > Artem Andreev (1): > net/sfc: support link up/down > > Ivan Malov (14): > net/sfc: support promiscuous and all-multicast control > net/sfc: support main (the first) MAC address change > net/sfc: support multicast addresses list controls > net/sfc: add callback to get transmit queue information > net/sfc: support Tx free threshold > net/sfc: support deferred start of transmit queues > net/sfc: support VLAN offload on transmit path > net/sfc: add basic stubs for RSS support on driver attach > net/sfc: support RSS hash offload > net/sfc: add callback to query RSS key and hash types config > net/sfc: add callback to set RSS key and hash types config > net/sfc: add callback to query RSS redirection table > net/sfc: add callback to update RSS redirection table > net/sfc: support firmware-assisted TSOv2 Hi Andrew, I am getting following build errors for clang [1] and ICC [2]. I have not investigated the root cause, just copy-pasting here. For ICC, since you explicitly noted it is not supported, and reported warning is known, I believe it is safe the ignore this warning via "-wd188" CFLAGS option in the Makefile. Thanks, ferruh [1] clang .../drivers/net/sfc/sfc_ethdev.c:1143:4: error: format specifies type 'unsigned short' but the argument has type 'int' [-Werror,-Wformat] EFX_RSS_TBL_SIZE); ^~~~~~~~~~~~~~~~ .../drivers/net/sfc/base/efx.h:1866:26: note: expanded from macro 'EFX_RSS_TBL_SIZE' #define EFX_RSS_TBL_SIZE 128 /* Rows in RX indirection table */ ^~~ .../drivers/net/sfc/sfc_log.h:51:19: note: expanded from macro 'sfc_err' SFC_LOG(sa, ERR, __VA_ARGS__) ^~~~~~~~~~~ .../drivers/net/sfc/sfc_log.h:47:18: note: expanded from macro 'SFC_LOG' RTE_FMT_TAIL(__VA_ARGS__,))); \ ^~~~~~~~~~~ .../x86_64-native-linuxapp-clang/include/rte_common.h:345:32: note: expanded from macro 'RTE_FMT_TAIL' #define RTE_FMT_TAIL(fmt, ...) __VA_ARGS__ ^~~~~~~~~~~ .../x86_64-native-linuxapp-clang/include/rte_common.h:343:39: note: expanded from macro 'RTE_FMT' #define RTE_FMT(fmt, ...) fmt "%.0s", __VA_ARGS__ "" ^~~~~~~~~~~ .../x86_64-native-linuxapp-clang/include/rte_log.h:258:32: note: expanded from macro 'RTE_LOG' RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__) ^~~~~~~~~~~ [2] ICC .../drivers/net/sfc/sfc_ethdev.c(1063): error #188: enumerated type mixed with another type efx_hash_types, B_TRUE); ^ .../drivers/net/sfc/sfc_ethdev.c(1086): error #188: enumerated type mixed with another type sa->rss_hash_types, B_TRUE) != 0) ^ compilation aborted for .../drivers/net/sfc/sfc_ethdev.c (code 2) make[7]: *** [sfc_ethdev.o] Error 2 make[7]: *** Waiting for unfinished jobs.... .../drivers/net/sfc/sfc_rx.c(820): error #188: enumerated type mixed with another type sa->rss_hash_types, B_TRUE); ^ compilation aborted for .../drivers/net/sfc/sfc_rx.c (code 2)