From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 909F5A0471 for ; Fri, 19 Jul 2019 12:04:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1925858C6; Fri, 19 Jul 2019 12:04:22 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CE9862BE5; Fri, 19 Jul 2019 12:04:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2019 03:04:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,281,1559545200"; d="scan'208";a="191885927" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.237.221.70]) ([10.237.221.70]) by fmsmga004.fm.intel.com with ESMTP; 19 Jul 2019 03:04:17 -0700 To: Sean Morrissey , dev@dpdk.org Cc: harry.vanhaaren@intel.com, john.oloughlin@intel.com, marko.kovacevic@intel.com, ciara.power@intel.com, stable@dpdk.org References: <20190715105434.18581-1-sean.morrissey@intel.com> From: "Laatz, Kevin" Message-ID: Date: Fri, 19 Jul 2019 11:04:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190715105434.18581-1-sean.morrissey@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 15/07/2019 11:54, Sean Morrissey wrote: > Added telemetry to EAL long options so that when > --telemetry is passed as an EAL arg that there is > no unrecognized argument error message printed. > > Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") > Cc: ciara.power@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Sean Morrissey > --- > lib/librte_eal/common/eal_common_options.c | 3 +++ > lib/librte_eal/common/eal_options.h | 4 ++++ > 2 files changed, 7 insertions(+) > > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index 512d5088e..24e36cf23 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -81,6 +81,9 @@ eal_long_options[] = { > {OPT_LEGACY_MEM, 0, NULL, OPT_LEGACY_MEM_NUM }, > {OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM}, > {OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM}, > +#ifdef RTE_LIBRTE_TELEMETRY > + {OPT_TELEMETRY, 0, NULL, OPT_TELEMETRY_NUM }, > +#endif > {0, 0, NULL, 0 } > }; > > diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h > index 9855429e5..e4c8e25c2 100644 > --- a/lib/librte_eal/common/eal_options.h > +++ b/lib/librte_eal/common/eal_options.h > @@ -69,6 +69,10 @@ enum { > OPT_IOVA_MODE_NUM, > #define OPT_MATCH_ALLOCATIONS "match-allocations" > OPT_MATCH_ALLOCATIONS_NUM, > +#ifdef RTE_LIBRTE_TELEMETRY > + #define OPT_TELEMETRY "telemetry" > + OPT_TELEMETRY_NUM, > +#endif > OPT_LONG_MAX_NUM > }; > LGTM, thanks! Acked-by: Kevin Laatz