From: oulijun <oulijun@huawei.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: <linuxarm@openeuler.org>, dev <dev@dpdk.org>, <ferruh.yigit@intel.com>, <andrew.rybchenko@oktetlabs.ru> Subject: Re: [dpdk-dev] [Linuxarm] Re: [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd Date: Thu, 18 Mar 2021 11:56:27 +0800 Message-ID: <b2b53fbd-904c-f337-9700-acda8e0d3b69@huawei.com> (raw) In-Reply-To: <2205707.nYbv8Qi5Wc@thomas> 在 2021/3/17 20:07, Thomas Monjalon 写道: > 17/03/2021 12:30, oulijun: >> 2021/3/12 19:21, Thomas Monjalon: >>> 12/03/2021 11:29, oulijun: >>>> 2021/3/10 15:59, Thomas Monjalon: >>>>> 10/03/2021 02:48, oulijun: >>>>>> Can we add an API such as rte_eth_get_device(pord_id) >>>>>> >>>>>> for example: >>>>>> struct rte_eth_dev * >>>>>> rte_eth_get_device(uint16_t port_id) >>>>>> { >>>>>> return &rte_eth_devices[port_id]; >>>>>> } >>>>> An application is not supposed to access the struct rte_eth_dev. >>>>> Which info do you need from this struct? >>>> >>>> Applications cannot directly access the global variable >>>> rte_eth_devices[]. To obtain information about rte_eth_dev, they need to >>>> access the global variable through APIs instead of directly. >>> >>> That's not the question. >>> Which device info do you need, which is not already provided by >>> one of the function rte_eth_*info* ? >>> rte_eth_dev_get_dcb_info >>> rte_eth_dev_get_reg_info >>> rte_eth_dev_info_get >>> rte_eth_rx_queue_info_get >>> rte_eth_tx_queue_info_get >>> rte_eth_dev_get_module_info >>> >> Hi, Thomas >> I think dev->data->nb_tx_queues can be obtained through >> rte_eth_info_get, but dev->data->tx_queue_state[queue_id] has nowhere to >> be obtained. I think a patch needs to be added to obtain >> tx_queue_state[queue_id] through rte_eth_tx_queue_info_get. What do you >> think? > > Yes it looks OK to add more queue info in rte_eth_*x_queue_info_get. Good, can I just catch up with this version? > > > . >
next prev parent reply other threads:[~2021-03-18 3:56 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-05 7:33 [dpdk-dev] [PATCH] " Lijun Ou 2021-03-05 7:46 ` Li, Xiaoyun 2021-03-05 9:58 ` oulijun 2021-03-05 9:57 ` [dpdk-dev] [PATCH V2] " Lijun Ou 2021-03-08 17:33 ` Ferruh Yigit 2021-03-09 8:49 ` oulijun 2021-03-09 9:53 ` Ferruh Yigit 2021-03-09 9:57 ` Thomas Monjalon 2021-03-09 10:18 ` Andrew Rybchenko 2021-03-09 14:00 ` Aaron Conole 2021-03-09 14:13 ` Ferruh Yigit 2021-03-10 1:48 ` oulijun 2021-03-10 7:59 ` Thomas Monjalon 2021-03-12 10:29 ` [dpdk-dev] [Linuxarm] " oulijun 2021-03-12 11:21 ` Thomas Monjalon 2021-03-17 11:30 ` oulijun 2021-03-17 12:07 ` Thomas Monjalon 2021-03-18 3:56 ` oulijun [this message] 2021-03-18 7:51 ` Thomas Monjalon 2021-04-12 13:12 ` [dpdk-dev] [PATCH V3] " Lijun Ou 2021-04-19 3:11 ` Li, Xiaoyun 2021-04-19 12:40 ` oulijun 2021-04-19 14:56 ` Ferruh Yigit 2021-04-19 12:36 ` [dpdk-dev] [PATCH V4] " Lijun Ou 2021-04-19 15:28 ` Ferruh Yigit 2021-04-21 1:44 ` oulijun 2021-04-21 8:09 ` [dpdk-dev] [PATCH V5] app/test-pmd: support cleanup txq mbufs command Lijun Ou 2021-04-21 8:15 ` Ferruh Yigit 2021-04-21 8:32 ` oulijun 2021-04-21 8:45 ` [dpdk-dev] [PATCH V6] " Lijun Ou 2021-04-21 11:26 ` Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b2b53fbd-904c-f337-9700-acda8e0d3b69@huawei.com \ --to=oulijun@huawei.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=linuxarm@openeuler.org \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git