From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E941A0C41; Tue, 19 Oct 2021 14:58:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84D384119C; Tue, 19 Oct 2021 14:58:26 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 4C83F4119B for ; Tue, 19 Oct 2021 14:58:24 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="251970475" X-IronPort-AV: E=Sophos;i="5.87,163,1631602800"; d="scan'208";a="251970475" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 05:58:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,163,1631602800"; d="scan'208";a="720041715" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 19 Oct 2021 05:58:23 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 05:58:22 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 05:58:22 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 05:58:22 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 05:58:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d/FEra75/MDn9leH/S7s5hyYwXVy7kr/Qp8FxbwdApTGMxAY1MfqeJ8gUGUz1VszFZ9IT0wIuNlj5DDajFnaG6pb9DiQhjo/EW77+FgIjw4ffdmkDtVr9AGHRRvEyfQvkXpT5X61hlq8LVVN5Y9Q5mplvkpHzZ1aWECgEC5LXJ+7C3VnNRsM+YKAHXuLv/pYwQCgzuPTk/VgWoRsg3leasZuFeYpkk1K4S5sGfXEpda8tvJWFLotkWU1ssgwkMFED1tzz2sX7rbJQA10ek7uDNgaFYdrVRiKizex64buTfFdKMUORndEaZ+iYh32e7YVpGXt74tG+7qXIsWWoXR2sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q5LYZ/nAykCHQm1y+9fcpgiFpIzB/VPIJimYgm2693o=; b=fke1oEWc9K8dzQdVKjwrJhxpChndjlxFbuIZZUCGAbemJ7Z/mni3aaE3JAAfWU7hXZTNgPdVvezHKaLlaahlbn9awZq1C616e8DYbzJUALTnx/1TuITL1okrDZB7rU0loZpLVbJsI71uJcXLRhbZAWkjo0zVnVL9Ca09ChpEa1eT+VP8/D2t1wn5jjai2mjPPpni6cuzf6r0Q+VMHnt/GAT4i+oI38JgMySR6YtJgDbdY8VW+/o1BODthekNUEPRGgNjBEntU5k047spbLFgbnRGhA6rZBkR454sw11CMXthdesWAT10Q6IuZt3piqg/2GaJ5dxcT7xKvMuCUvDV0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q5LYZ/nAykCHQm1y+9fcpgiFpIzB/VPIJimYgm2693o=; b=sw++6/lIqXrIzsJE/CEXMoSrv3G7sny3FM4fhIgpxjq9vVOHS+Ug8zRZ94YDKx12u/FkTP/3UatM0jU8wt0ASArgLZW49TIa5L/qscccwO6jg0QEQ78I8GflXJXxhcyiYE+MCb7l7RJVk++hFDPYnoHX5Du+47GATPDJFYcE3z4= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5206.namprd11.prod.outlook.com (2603:10b6:510:3f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct 2021 12:58:17 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 12:58:17 +0000 Message-ID: Date: Tue, 19 Oct 2021 13:58:10 +0100 Content-Language: en-US To: Tudor Cornea , CC: , , References: <1634306769-20123-1-git-send-email-tudor.cornea@gmail.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DBBPR09CA0022.eurprd09.prod.outlook.com (2603:10a6:10:c0::34) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DBBPR09CA0022.eurprd09.prod.outlook.com (2603:10a6:10:c0::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Tue, 19 Oct 2021 12:58:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 85d9a31f-2030-4143-fad5-08d993001e50 X-MS-TrafficTypeDiagnostic: PH0PR11MB5206: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /boN4Ycu0ORR/xvq5+6ZlTUjctjRX7w4DIO9O9+984z1NeeD7lQnr2zmuMQTxdRkGum7j0TgGY/FYoABcKSN4tzntIkJYifYTTyKmi59diCJObf3iXa4Ql1jNk+tSNXvp03TcTMzYAdnMonJXVbFY+K2TYnfoqsE273BU4EeUvFL+EUSoXeltopvJXMGkHFXV/IMDUPnVpQ+99/qpuCAMQMqYrZWcmQceis9WhOLH+MZgU75kVYQBaWt/TBeJj7+jhXrZyWBA8peqPmAqL/PzJD03p5+y9MpqSkaBpLmagYgucESh578atJix7fontBh+aTxliLbVVBoIvkv/EWzs+El8KYGt1PN+HUq9IqV2yhhOkZtmtfQSu4ZR1rolXuViwiY3UlrxjSya5YWPEWLmbBYICvljSYgcuzyCYBqsRPmp0b+xn/N2sZdxSkPJihOCFUA7sMzkYkvPaoffgh7InrmyLeJI+OOQAQ0FE59eAdvmOyfoBsZp0R/ShMUa+fGK+C7JvVD7IOhWvWR6vF/N6QH8MOUIWkNJSx9Dg9sn64R6aQJGCXEpjrY5NLxeZfw7yb5nhsJlrgVG1NN3VVv67exox/+NUcly5QFDFGEJ8Gr2pwgGL9UKsNiA/4F0PipYLUS/gBf4p1yDefRw3MxIrMQx3L5b1epQSRJlC3ZZD9o1hVWbILKDUGMst+cKr7Mz+9IB1l00axF+cv4iH7mridtL9z+ES2o0LfXUKIQxTzRY4J2N1sQ42K46bGGTcYxhKVMSBsL21YZaW20MY07iJGysbme8asL9WkOECGO4Sk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(31696002)(316002)(6486002)(82960400001)(8676002)(44832011)(53546011)(16576012)(31686004)(508600001)(66556008)(8936002)(4326008)(66946007)(5660300002)(86362001)(36756003)(66476007)(6636002)(2616005)(186003)(83380400001)(956004)(6666004)(38100700002)(966005)(2906002)(26005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MU11Q250L2hTS1JjK1p5UlgxRWhpdHltRjlBbnBMblBTZEFRdWVhY3JaM1ow?= =?utf-8?B?QVFqR0RWZ1BlRFE1clZtNHhkSXFZOFlPN1pzc2FiMDJ5NFpuRkpQc1g2WUg5?= =?utf-8?B?NXRaaGlaL0lIYzdoVUhxWHBRUWlQaFRhd1MyVnNRSHNmVWFiSWl3ZlljNi9K?= =?utf-8?B?N1k5NkZjWEFOSHFCaTcwemhqZkZHbEFmZFhuZVl5aWh1OThtajhNSXR1V3B2?= =?utf-8?B?RldiK1NYbm9PZEppWDlSeUZlbEdvYmc0MmltUm5GdkI4M3JXMmp0aEFoaGlP?= =?utf-8?B?WEY0c204T05uOE4rbXZkdWNyWEJxRFhUa0hsNEdEbHJkN2FuSXIvT2hpSHM4?= =?utf-8?B?MkxVWC9EV04rUjAyK2hOVndhazFRbS85eUppektBejdSRE9KMEVtemNKSWxQ?= =?utf-8?B?RnNIS2VGNXVRcUlnaitMaDNFZy80emVncnFCVWhnRUx6MHlmNnV1KzlSNE5C?= =?utf-8?B?WmJTQlJFUWs4NWEwSEZkYlNoQmpJTmQzUmxrNFZSYXhOWUlRMU92T2ZuV2hl?= =?utf-8?B?WmhDb1ZFUTBwUk81MnpZcXNYR1hVUnREMEJMTGZ5UTQrbm1VNkFYTzJneG5G?= =?utf-8?B?NnpxNjNJRmY5TnBDS2dPT0NGbzhFclVoZzJHeU1UL2VCTmlJa0xtYTBkN0Z5?= =?utf-8?B?UVVVOE5NbzdBN2QyVDN5N3NNbFVPNXU3MjVmUi9oUVJQek9hUXRIUndXdXZG?= =?utf-8?B?Vk9zSDR6SXpxaTRTWjREQXNhdExuR0UwVGJlN2JUMENHQ0lIejB4cXhPUEor?= =?utf-8?B?TDIzKzl5TUhKNWJvUzVNb25TTVZYVk5wMERGVFZjdGNoM1J2RXoyeDhwTVhh?= =?utf-8?B?eFhmQlBMOG93SjEyY1IvL1Q4dFdyd2dzRWxGek5Jdzc1UnBZTUxqcjdqb0Qz?= =?utf-8?B?eVQ3VVhPcVNoM081YVE5bVNhN0JTb0pPSE5aYmNyMzk1WjljUC9qZEV1dS93?= =?utf-8?B?eC9yQ0ZSbytUQ01Ta0JJSzRLRXNBV3dDL0ZEeVVqa2FJcnljQTdrWFUwNFNz?= =?utf-8?B?b0RKRFJrSzl2YXRVeCtGeHU5RVVDTHBJN2NUSjdmakdkeEswbm1NWm44Y1VY?= =?utf-8?B?dHZsY2JqQkdGY0o5MXJJUmw2MnM0M2gyaUgzVitiOEZIVWlhWVN1WDhoQTZy?= =?utf-8?B?VU1HMEpzcGcxNG5ic0hQbDNBakxvcFV6LzZ6UXd6Mk9sZ2N1alFoVUJGT2NY?= =?utf-8?B?TWl6bkd3aXkyQi93MU11V25jRWc3aTdOSE1GUy9WRmdwY21ta2x5OTJUNzFR?= =?utf-8?B?bTdnTHNNckxhbCtqNFNsYlFpeVdzKzlWYTlQZndyd3NhQm1EaUY0Qzc4dFpO?= =?utf-8?B?QnVqUURwUWw3RVRnK3VpWjhndnlYMnMxcktidjErSXBUVW5aNEVqUzU5d05v?= =?utf-8?B?Q1lMcWhHVHVJSE5DU1ZPcEc3VWdzWHJLYUdQTGk2S2VYR2t1YTkwQlhxcDM0?= =?utf-8?B?aUJyUHhVZnlHT1VURS83alFpWkdMQ3FYOG5WUEpEbTdHL2IzblJwc1BGN1ZT?= =?utf-8?B?Wm80dUp3Q280TldmOHNkRy9HU05UaHFLUXI5ZXRaMkF4S1lDTHFtaFRsQkJT?= =?utf-8?B?T0NWOGQrditXaStJbEEvQXZvRmtvSDBPb2dzVUNzQmtYWkVPNFRLdUZCOG1q?= =?utf-8?B?OXhTeGFzL0F3eitlZzlSTmRRQ21BQjUxeURxNzVWc2IyWlF3dmRkaXlNTzB5?= =?utf-8?B?TkFjVmlMM2VyUUU1WUxPempRNXBZcnNReHhzbjQvcG1Ebi9lckZoWk9sM09R?= =?utf-8?Q?dvEBVzMUlFp2JPFDsU1Dd14WukD298DxDqWq7Hr?= X-MS-Exchange-CrossTenant-Network-Message-Id: 85d9a31f-2030-4143-fad5-08d993001e50 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 12:58:17.1415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MqfXBdACBFnn9PAYYZRBrRmUa5ALuMaMGhb5WgZG6i+w8D30oEOAJz13dgqEuXhWb7uCxVNz77Sqedom0xVYdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5206 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: initialize max_rx_pkt_len if rlpml_set_vf fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/15/2021 3:20 PM, Tudor Cornea wrote: > Some of our customers use ESXi 6.0 or 6.5 servers, which could have older > versions of the PF ixgbe driver. > It seems that with a more recent version of the PMD driver, we are not able > to initialize 82599EB ports correctly. > This scenario seems to have worked with DPDK 19.11. > > Would it be possible to print a warning, while still allowing the driver to > initialize the ports ? > > I was also thinking about the return code of ixgbevf_dev_set_mtu. > Do you think it would be more appropriate to return ENOTSUP or ENOSYS > instead of EINVAL ? > > As a user, calling 'rte_eth_dev_mtu_set', I would expect an error like > EINVAL to suggest to me that > the mtu value which I provided is incorrect [1]. The 82599 NIC, however has > some particularities related to mtu, > which could cause the operation to fail. I was thinking that EINVAL might > not be most descriptive error. > > [1] https://doc.dpdk.org/api/rte__ethdev_8h.html > > Thanks, > Tudor Hi Tudor, Can you please check if the patch is still after 'max_rx_pkt_len' related changes in next-net? > > On Fri, 15 Oct 2021 at 17:06, Tudor Cornea wrote: > >> It seems that if the call to ixgbevf_rlpml_set_vf fails, >> we will not initialize dev_conf.rxmode.max_rx_pkt_len correctly anymore. >> >> This happens with a 82599EB NIC and a VMware ESXI 6.0 setup, >> and is causing VF the ports to fail to initialize >> >> We see the following error: >> ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. >> >> Investigating over DPDK 19.11, it seems that the call still fails, >> but it doesn't exit prematurely, and max_rx_pkt_len is initialized in >> the respective case. >> >> On the ESXi server, we seem to have the following driver >> net-ixgbe: 3.7.13.7.14iov-20vmw.600.0.0.2494585 >> >> It seems that the behavior related to MTU setting has changed >> since the following commit: >> >> commit c77866a16904 ("net/ixgbe: detect failed VF MTU set") >> >> We would like to still be able to support older setups if possible, >> as we might have customers running ESXi 6.0 or 6.5, and these seem >> to have an older version of the PF driver as default. >> >> Signed-off-by: Tudor Cornea >> --- >> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++-- >> drivers/net/ixgbe/ixgbe_rxtx.c | 1 - >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >> b/drivers/net/ixgbe/ixgbe_ethdev.c >> index 4dbe049..4301dfd 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> @@ -6369,6 +6369,9 @@ ixgbevf_dev_set_mtu(struct rte_eth_dev *dev, >> uint16_t mtu) >> return -EINVAL; >> } >> >> + /* update max frame size */ >> + dev->data->dev_conf.rxmode.max_rx_pkt_len = max_frame; >> + >> /* >> * When supported by the underlying PF driver, use the >> IXGBE_VF_SET_MTU >> * request of the version 2.0 of the mailbox API. >> @@ -6381,8 +6384,6 @@ ixgbevf_dev_set_mtu(struct rte_eth_dev *dev, >> uint16_t mtu) >> if (ixgbevf_rlpml_set_vf(hw, max_frame)) >> return -EINVAL; >> >> - /* update max frame size */ >> - dev->data->dev_conf.rxmode.max_rx_pkt_len = max_frame; >> return 0; >> } >> >> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c >> b/drivers/net/ixgbe/ixgbe_rxtx.c >> index 0ac89cb..02d9809 100644 >> --- a/drivers/net/ixgbe/ixgbe_rxtx.c >> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c >> @@ -5677,7 +5677,6 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev) >> (uint16_t)dev->data->dev_conf.rxmode.max_rx_pkt_len)) { >> PMD_INIT_LOG(ERR, "Set max packet length to %d failed.", >> dev->data->dev_conf.rxmode.max_rx_pkt_len); >> - return -EINVAL; >> } >> >> /* >> -- >> 2.7.4 >> >>