From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 99C3BA00E6
	for <public@inbox.dpdk.org>; Fri, 17 May 2019 16:42:38 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 843F35F25;
	Fri, 17 May 2019 16:42:37 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id E5D045B40
 for <dev@dpdk.org>; Fri, 17 May 2019 16:42:35 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id F06DB30842A1;
 Fri, 17 May 2019 14:42:29 +0000 (UTC)
Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A699600C4;
 Fri, 17 May 2019 14:42:22 +0000 (UTC)
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Tiwei Bie <tiwei.bie@intel.com>,
 Jens Freimann <jfreimann@redhat.com>, Zhihong Wang <zhihong.wang@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
References: <20190517122220.31283-1-maxime.coquelin@redhat.com>
 <20190517122220.31283-3-maxime.coquelin@redhat.com>
 <CAJFAV8yMw3F2=afMup3hsFXJnxOT-K4F2zba2Dz3rbs7SnJVCg@mail.gmail.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <b2e8b3ce-597a-2971-4854-6a8ce07f18f1@redhat.com>
Date: Fri, 17 May 2019 16:42:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CAJFAV8yMw3F2=afMup3hsFXJnxOT-K4F2zba2Dz3rbs7SnJVCg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.40]); Fri, 17 May 2019 14:42:30 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH 2/5] vhost: do not inline packed and split
 functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 5/17/19 3:00 PM, David Marchand wrote:
> 
> On Fri, May 17, 2019 at 2:23 PM Maxime Coquelin 
> <maxime.coquelin@redhat.com <mailto:maxime.coquelin@redhat.com>> wrote:
> 
>     At runtime either packed Tx/Rx functions will always be called,
>     or split Tx/Rx functions will always be called.
> 
>     This patch removes the forced inlining in order to reduce
>     the I-cache pressure.
> 
> 
> I just wonder if the compiler can't decide on its own to inline those 
> static functions.
> We have __rte_noinline for this.

Good idea, I think it did not happen in my case because the compiler
would find the functions too large to be inlined.

I'll fix that in v2.

Thanks,
Maxime