From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA7F4A0C41; Fri, 5 Nov 2021 22:21:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A51740689; Fri, 5 Nov 2021 22:21:18 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 4922C40151 for ; Fri, 5 Nov 2021 22:21:17 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10159"; a="318184196" X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="318184196" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2021 14:21:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="468956141" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga002.jf.intel.com with ESMTP; 05 Nov 2021 14:21:16 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 5 Nov 2021 14:21:15 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 5 Nov 2021 14:21:15 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 5 Nov 2021 14:21:15 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 5 Nov 2021 14:21:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WZjNUkje8Ay4oMQ4eKxHS5yktX4gZ54tmA/5lXvqdjo3hVHQB6+P+hCH8ghrgrvXYU9/1SX1u2fylqFtlmqEqocHDSCX0Ft9R0Dl3D+vtM508OwMMulX0QrChFqxmDBKRkrBdDS9AtCuH7LcGGXF9+44NlbKbHSM7HpSoyAsLRLc5C5JxFxRqC5e04dLx9RNMREuVzW+InMM/q2jKQtfSzNqWnJsy4VjTJvna/ghR7ZE+4+a5nnMXxMtSd6yzQpCePB/53n0unFB/8Zdko/uR7CwQI2Zz3WFJ9ehlShWSMaEKySP7TFI/gXQWXTp37dvwz3UCOMJBUg9lczvS2ovUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Gbd/4w6k/x13kE/iSfwhjkhACn+x1ZCH3ClQx3MHFI=; b=UM7jc1uS39WjiYostc0SKZmb81BDDwysvw1Oj9zCAHutn9jC0fu7O3RN2GELNCwasEMqRN2jS4mno12rDBHYytVIt6UGN0mYwBvM9vyC6tl4vGZC9kTY744+fP5R43OgLOeHxb8PW3I1wfbOaERZRVNDqEF1bmNt6aTQ7T3jMnQ3E4eZlpiarSK2H8BE5F7DTGOnCWQkfwQO0OEkoKwwCiUJXj+Pq2W0HpBmR47FXAPTHk53uGXk6yyhfLJv5GupHiSCe1G8QcEzxrkMc/e4M7okoqXE59V0v9vEzsEhDH1mfKEOr2npX/cFT+NEZuWNhgSRjA2cIgJw7ui+UpM+SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Gbd/4w6k/x13kE/iSfwhjkhACn+x1ZCH3ClQx3MHFI=; b=Ujj8PdbKVt/YvQnH6yatzdgWvVn8O008T700lzvBknCMQed2s+OaeS6wFu263Lp26gc5ckptorNWIQKXDUSyZhmCt2eUtZz8p4q7EYstBA8jeqvEVIPk8J3pQLwYaQKgFzWdCdnYc6b8EuptFexV1mYxaSYW5zR+I/ZKDJRks28= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4982.namprd11.prod.outlook.com (2603:10b6:510:37::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Fri, 5 Nov 2021 21:21:13 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Fri, 5 Nov 2021 21:21:13 +0000 Message-ID: Date: Fri, 5 Nov 2021 21:21:05 +0000 Content-Language: en-US To: Slava Ovsiienko , Gregory Etelson , Ori Kam CC: Matan Azrad , Raslan Darawsheh , Xiaoyun Li , "dev@dpdk.org" References: <20211026152000.11665-1-getelson@nvidia.com> <489cf220-720f-985e-5982-78db17b2845d@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0359.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::35) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO2P265CA0359.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Fri, 5 Nov 2021 21:21:11 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2178c3a-0821-478e-5531-08d9a0a231cd X-MS-TrafficTypeDiagnostic: PH0PR11MB4982: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2887; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9Ha+f1ZeYszUmZVBnLEJ5v3um1Bt6uYqHQpUD7aaa/u8nbiUi4sPxAAglyy0J8oIlyx70kmQAaSd71UMITynoZZWNJGGjetJAFV9A7mOVKyYeMqPpoAOF5EfS41Gct/r3IcacBqJqgnOyGYH9DfP5Caf+kDcNp+E8ODQSOsIyFrdEuHH9CSXKY1KoWB49/UD94FPAZK2T2jQd4XjledLQLK6y9z9EjmGxvF0iAO9ev5nD6N0DC7yZCTXJtKOP/IehFcOileTD26eMiLHXK/NBo8aUKGRTEX5yYrFpBN5w+1Pq1pOj8u+DGve3NkGjNFzSGeKNirMJZHahauszYeSvCR1Qj4YCj25qqDP6nfQ+l3GA1er9YZP1t2AMaWZFAigE5EkuVPAqnA/ogrPpia9rUv2I0l6gqziaTplKGPzQSassPwSbiXvrFe6PrRGdOFLjQxm8tGDObi6v72aaRGfWsQJvjeBD2S4GByBojwAxUOu/s900isbxvT+81yJVbowp0ZKSy5H3CaunktftMGV7ovommZ+Pn3JAFnbDS4FJd6Lg3BeTvvoXO7a3d4o/4svOqh9b7PXtXbTipDEZtDj7P0+vbkINSUyYRySzJkG8WHTazFtnX10q+8Na7/og9Lxx1K0nNwrR86OaQysDxwpghmUiKeLwNJu2Q0XUes5y47NhPYAUkzBtjE7JPwZIIT289tmqzmjfvcZviPxr0TtoQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(5660300002)(82960400001)(44832011)(508600001)(36756003)(53546011)(26005)(54906003)(66946007)(66556008)(2906002)(66476007)(8936002)(316002)(16576012)(110136005)(38100700002)(8676002)(6666004)(956004)(31696002)(2616005)(83380400001)(31686004)(6486002)(4326008)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFpHSXBHSW4vMjEyOUlRZHlFdXZVSzNYb3Q3Qkl3NUM4SkZ3Mlg5OENxY2FT?= =?utf-8?B?dE95YVQ2OFVjS3V3OFU0SHduak5zT3h2enE2ZDlGMzBSWE90dUxQZ1pjc05G?= =?utf-8?B?b0ZSb3NtNlNxQzFvTkVzejdwRFV4YjgxL094YWx1Z0k4RUtCalVTTlZnUkNV?= =?utf-8?B?TXRaaGVzK0VWTUVGZURSQXY3UVFEMnhjekpsVHgwbHVmLzJLa3FTSVhMSGJi?= =?utf-8?B?WXd4R3RONFpWUnYyc0I1YS9IZmZTdThCcXcwV01hZUllVS9UQ0x4UWNSNU80?= =?utf-8?B?MHRtL0xpMlQxa045WlR2YUNYeWcrZjlXdng1ditQK2QrUUJ5cnBwTzBOSmVF?= =?utf-8?B?QklFYk40UU5pa2doUWtONUVjczhHa0JZL0lHaGVKUk1CZnUzc1RYVTdSUlVC?= =?utf-8?B?eERVV3NtVnlTK01BYzYxOXpQdm1IWEJSc1RqZE9BMkIrQllVU2NDWldHQlpz?= =?utf-8?B?NG81MXBYa3JBaTVLemlCTXlqTDY5aVU1aEpjQ1JyRDQ0V0FJeEQrRlpBV0RY?= =?utf-8?B?cExETm5zY3JTcEpQVzVIeWVSS3ViTGU0a3pVcHcrb01qaWRMRHZ3Ykg4RW0x?= =?utf-8?B?b1JSTWxkR2wwZEx0b2pNb2JIdnN5K1lnaDFqUVRWTHI5SXdiZHNZQkJ2blB6?= =?utf-8?B?K0VVR1ZkaFZRSzk2clUxeVp3MUUwUUJidFRqc3pRK0c2Ri9RNHlUdDRPRHB2?= =?utf-8?B?cmxkSXZrTXFrVkhzYzNhYnlvSDVCLzFtdUhXNFpacTM1U0NUWGI4TjZSbzVY?= =?utf-8?B?TjB6ZmUxVGg2UHBXQ1NHa1Z5VmxKTWFwTGNGTk5JUXYxRWNiU25DR3AwV1dV?= =?utf-8?B?WGdWbzU4RHdsYnFKYUwyKzNaSFZxOFAwZkJTZko3WkhVZXIyb2svVmkvemZX?= =?utf-8?B?OWNySUFUQlFoUWwralVMa1NkYlBTakNKdWp4VHcyV1FYUDhjbVNaOXdWTlVy?= =?utf-8?B?dGFrU2dyU0NVcC9RS0NpN012cWZONjN6TXdCQlpQRFF5TEJnVTd5R1ZvMi9Y?= =?utf-8?B?RDdhQytUdUROVUVaZzcyR3ZvWjY5VHNzU0lWT2VIUzc4dE84Z29Sa2dIL3dI?= =?utf-8?B?TmRDeVg2ZEJ4VmpDdUlWWE1RNisxNU9FT0o1VzFrb1BDbWNYcDdSVGNheWlV?= =?utf-8?B?TXZvb3R4UVJtRFBFaXZWelp1TjgxM1MzNWErYWd1bVp3enlIdTFkQnF0RWVX?= =?utf-8?B?Um8wV2tKWlVsWW44dXJnYVd5dHNYMXR4NnJYMHZMT2NjcFB3Qld4bEVUdTQ1?= =?utf-8?B?YkFrNThQaTkvSVRSbGUvY1JSM3F3Y3RPQ29zc2t0VWVUSElZSFl1VU1wVUE0?= =?utf-8?B?TkRrTGtaM2hucDB3bmw2NHJVS0g1NnVyY2Z5UXVsd3c2VURlUkZQNlZYUXB6?= =?utf-8?B?d25iVkR4eWlPcDRKOHl4VEtRNHZ4Z0dNVmpza3luS2tzbkZNalhKaGg0aEZw?= =?utf-8?B?THlrMXkydmF5cUppTTlES0NEdzNxeWpXdXc1RDZHeHBXUHRWVEVQNHlXS0Ew?= =?utf-8?B?ZDNlTVMweDVlaGlVYmxqdS9Tc2c0K1hVZXk0YWJ6bjFCVGNlY0o1OHZqQUl4?= =?utf-8?B?WTVRb2xnajUwNlZyNkRDeHNBYXFYaXlzUjdGTTJJU3VqbG12NTdudkV6RUM5?= =?utf-8?B?VkJ4UWhQN2ZmdjNTSGdoOWUvU1hLR2dEeHdJWS9uTGRLeG92OVZyNVZwRTdX?= =?utf-8?B?QWxxZjlWNW13bDkwb1BNMmU1cDZzRWtSMHh2STZSS0pWNHQ1VU85ZS9LMnor?= =?utf-8?B?UXB6MGo1RGcya2JVc2hPMUlEUU1IVGVvRXNPU1ZKWG1kYWlSR3QrQmRCOTYw?= =?utf-8?B?NnMwalhWdVk1M1pmNWdWRm51QWdUdXR3M3EwOGkrTDdvZndmeEVtODY5bDYv?= =?utf-8?B?WHhRL0dIUjJ2di8xNDRURzNlMVRxMW0yNExlekhOQlBRemJRejJNWFYrcE5y?= =?utf-8?B?dlFtRVNmOTkxb2lOUmQrYTBpZEc5WkdtczAyQ2RWS0E4eEtpbzZTdENoR1ps?= =?utf-8?B?UnQ1Rlp3STBqd0laVU9WNTFSbnVkM2JwZTQ1YUlFdG1tbFV4THZDOC9VOGI4?= =?utf-8?B?THkwbjdUWVgvczNLM1ZiQUJVUkVaTGFURGdPTDNoSmIrSnlJVlRiUFhXNHFk?= =?utf-8?B?SDNXSy9udkRWVm5hSlNobmV4d3ZONk5SaEpGSUIyVGxjVUo4b3VXRXE2dTVZ?= =?utf-8?Q?vCFZgaSKGqJJ9Jwk9fs3qq4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f2178c3a-0821-478e-5531-08d9a0a231cd X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 21:21:13.2831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bBjmiBGW0MNu/pCReBNEBxqEA60ZTTxH+aGi6+/77vA9UWJoln9VMbbqzGlc/G3uvJQFnQviBSn/Pys5eYrqvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4982 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/5/2021 5:03 PM, Slava Ovsiienko wrote: >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, November 5, 2021 17:57 >> To: Gregory Etelson ; Slava Ovsiienko >> ; Ori Kam >> Cc: Matan Azrad ; Raslan Darawsheh >> ; Xiaoyun Li ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush >> >> On 10/26/2021 4:20 PM, Gregory Etelson wrote: >>> Testpmd provides 2 sets of flex item create and destroy functions One >>> for hosts with JSON library. These functions parse flex item >>> configuration stored in JSON file and create or destroy flex item >>> object. The second functions set is for hosts without JSON library for >>> compilation compatibility. >>> >>> On hosts without JSON library, current implementation issues "no JSON >>> library" notification on port close. >>> The notification was triggered by port destructors that include flex >>> items flush routine. >>> >>> The patch introduces single implementation for testpmd flex item >>> destroy. >>> >>> Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands") >>> Signed-off-by: Gregory Etelson >> >> Hi Viacheslav, Ori, >> >> Can you please help on reviewing this patch? > Reviewed-by: Viacheslav Ovsiienko > Applied to dpdk-next-net/main, thanks.