From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E4C091B231 for ; Tue, 31 Oct 2017 22:49:29 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 31 Oct 2017 14:49:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,326,1505804400"; d="scan'208";a="915995658" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.190]) ([10.241.225.190]) by FMSMGA003.fm.intel.com with ESMTP; 31 Oct 2017 14:49:28 -0700 To: Jianfeng Tan , dev@dpdk.org Cc: santosh.shukla@caviumnetworks.com, sergio.gonzalez.monroy@intel.com, thomas@monjalon.net References: <1507718028-12943-1-git-send-email-jianfeng.tan@intel.com> <1507718028-12943-2-git-send-email-jianfeng.tan@intel.com> From: Ferruh Yigit Message-ID: Date: Tue, 31 Oct 2017 14:49:27 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1507718028-12943-2-git-send-email-jianfeng.tan@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] eal: honor IOVA mode for no-huge case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Oct 2017 21:49:30 -0000 On 10/11/2017 3:33 AM, Jianfeng Tan wrote: > With the introduction of IOVA mode, the only blocker to run > with 4KB pages for NICs binding to vfio-pci, is that > RTE_BAD_PHYS_ADDR is not a valid IOVA address. > > We can refine this by using VA as IOVA if it's IOVA mode. > > Signed-off-by: Jianfeng Tan > --- > lib/librte_eal/linuxapp/eal/eal_memory.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c > index 28bca49..187d338 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_memory.c > +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c > @@ -1030,7 +1030,10 @@ rte_eal_hugepage_init(void) > strerror(errno)); > return -1; > } > - mcfg->memseg[0].phys_addr = RTE_BAD_PHYS_ADDR; > + if (rte_eal_iova_mode() == RTE_IOVA_VA) > + mcfg->memseg[0].phys_addr = (uintptr_t)addr; > + else > + mcfg->memseg[0].phys_addr = RTE_BAD_PHYS_ADDR; This breaks KNI which requires physical address. Any idea how to disable RTE_IOVA_VA when KNI used? > mcfg->memseg[0].addr = addr; > mcfg->memseg[0].hugepage_sz = RTE_PGSIZE_4K; > mcfg->memseg[0].len = internal_config.memory; >