DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>
Subject: Re: [PATCH v2 10/12] net/txgbe: fix debug log
Date: Wed, 9 Feb 2022 19:07:22 +0000	[thread overview]
Message-ID: <b32a7f46-e579-e3cd-f5b1-1be6098beb6f@intel.com> (raw)
In-Reply-To: <20220209104213.602728-11-jiawenwu@trustnetic.com>

On 2/9/2022 10:42 AM, Jiawen Wu wrote:
> Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix
> that double line was added by using 'DEBUGOUT'.
> 
> Fixes: 7dc117068a7c ("net/txgbe: support probe and remove")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

Comments to ngbe patch (8/12) applies here too.

> ---
>   drivers/net/txgbe/txgbe_logs.h | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/txgbe/txgbe_logs.h b/drivers/net/txgbe/txgbe_logs.h
> index 67e9bfb3af..8fa80a69b2 100644
> --- a/drivers/net/txgbe/txgbe_logs.h
> +++ b/drivers/net/txgbe/txgbe_logs.h
> @@ -17,10 +17,13 @@ extern int txgbe_logtype_init;
>   		"%s(): " fmt "\n", __func__, ##args)
>   
>   extern int txgbe_logtype_driver;
> -#define PMD_DRV_LOG(level, fmt, args...) \
> +#define PMD_TLOG_DRIVER(level, fmt, args...) \
>   	rte_log(RTE_LOG_ ## level, txgbe_logtype_driver, \
>   		"%s(): " fmt "\n", __func__, ##args)
>   
> +#define PMD_DRV_LOG(level, fmt, args...) \
> +	PMD_TLOG_DRIVER(level, fmt "\n", ## args)
> +
>   #ifdef RTE_LIBRTE_TXGBE_DEBUG_RX
>   extern int txgbe_logtype_rx;
>   #define PMD_RX_LOG(level, fmt, args...) \
> @@ -48,11 +51,11 @@ extern int txgbe_logtype_tx_free;
>   #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)
>   #endif
>   
> -#define TLOG_DEBUG(fmt, args...)  PMD_DRV_LOG(DEBUG, fmt, ##args)
> +#define TLOG_DEBUG(fmt, args...)  PMD_TLOG_DRIVER(DEBUG, fmt, ##args)
>   
>   #define DEBUGOUT(fmt, args...)    TLOG_DEBUG(fmt, ##args)
>   #define PMD_INIT_FUNC_TRACE()     TLOG_DEBUG(" >>")
> -#define DEBUGFUNC(fmt)            TLOG_DEBUG(fmt)
> +#define DEBUGFUNC(fmt)            do { } while (0)
>   
>   extern int txgbe_logtype_bp;
>   #define BP_LOG(fmt, args...) \


  reply	other threads:[~2022-02-09 19:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 10:42 [PATCH v2 00/12] Wangxun fixes and supports Jiawen Wu
2022-02-09 10:42 ` [PATCH v2 01/12] net/ngbe: fix failed to receive packets Jiawen Wu
2022-02-09 10:42 ` [PATCH v2 02/12] net/ngbe: fix link interrupt sometimes lost Jiawen Wu
2022-02-09 10:42 ` [PATCH v2 03/12] net/ngbe: fix Tx pending Jiawen Wu
2022-02-09 19:07   ` Ferruh Yigit
2022-02-09 10:42 ` [PATCH v2 04/12] net/ngbe: fix RxTx packet statistics Jiawen Wu
2022-02-09 10:42 ` [PATCH v2 05/12] net/ngbe: optimize the PHY initialization process Jiawen Wu
2022-02-09 10:42 ` [PATCH v2 06/12] net/ngbe: add support to custom PHY interfaces Jiawen Wu
2022-02-09 10:42 ` [PATCH v2 07/12] net/ngbe: add LED OEM support Jiawen Wu
2022-02-09 19:06   ` Ferruh Yigit
2022-02-09 10:42 ` [PATCH v2 08/12] net/ngbe: fix debug log Jiawen Wu
2022-02-09 19:07   ` Ferruh Yigit
2022-02-10  8:03     ` Jiawen Wu
2022-02-10  9:02       ` Ferruh Yigit
2022-02-10  9:49         ` Jiawen Wu
2022-02-10 10:16           ` Ferruh Yigit
2022-02-11  2:02             ` Jiawen Wu
2022-02-09 10:42 ` [PATCH v2 09/12] net/txgbe: add LED OEM support Jiawen Wu
2022-02-09 10:42 ` [PATCH v2 10/12] net/txgbe: fix debug log Jiawen Wu
2022-02-09 19:07   ` Ferruh Yigit [this message]
2022-02-09 10:42 ` [PATCH v2 11/12] net/txgbe: fix to set link up and down Jiawen Wu
2022-02-09 10:42 ` [PATCH v2 12/12] net/txgbe: fix KR auto-negotiation Jiawen Wu
2022-02-09 19:06 ` [PATCH v2 00/12] Wangxun fixes and supports Ferruh Yigit
2022-02-11 13:10 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b32a7f46-e579-e3cd-f5b1-1be6098beb6f@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).