From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE4D2A034E; Wed, 9 Feb 2022 20:07:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D077C41153; Wed, 9 Feb 2022 20:07:51 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 6E8CD40140; Wed, 9 Feb 2022 20:07:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644433669; x=1675969669; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=rteirdZ/4QRzKx+tcGpB0K/ZwmqZ7RW9jYTzbMBG1o0=; b=ilL9qdtyhc6O/e2JuzbwPUfi44MBfKFrVGz450n/3LtsF2vNF5AS+JjT Pn70fIlZjPp63OPTRxR1pRSJgk+U8jQeSDW/3KsKMbXcbQnCIgbwG95Nc W08KY4mdTo8L6Gj50YRFDSo7w4zrcFOyA5CrLVJMUzX39NBj4ailEoeCm Heg3sQdRlJVDza6z+vhywdJCUGRfWZedKHgsmluyB+LV1V4WIAXVctM2/ 8OCHthbjDSU2Y7UksFKpFk23YJOXyTGvvkSKJOGFhtDLtRqDEZU3JGFQE IHJdFSzQjyZecCsMj4p6DTnHY6NTdxs6Nsv3+e0XiF94m+OyCZ8S72ib8 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="310049942" X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="310049942" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 11:07:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="585685561" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 09 Feb 2022 11:07:29 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 11:07:29 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 9 Feb 2022 11:07:29 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 9 Feb 2022 11:07:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hI26zKaSJu2euoz+U0us6sx46BLKdu3YOCUTfx/dM1extxQ+Lqt5Bt9hnq/CMVdQZrrhOaRLeKDhEEEjsbUY7O/4f5WPjIo/wLiXRcUddGCMZxx4S6ZrHgrYF3LWAw5GDpmc7gnxjyCFe0YUid3VtO1SD9AJUh0BEdNPAhafL79SqSPAKxqXllAyvZ49JPaoeEwc0ooVxT42oZqyVS4aOnLwzkJ7swiRg3Jz0jHf57OUmhkwA0n40HbITkuqfOcnkNdMK0e+4orZXk0tepx5r6LU4T9gUEz/T3amZvwwUPcm5qO7iP1YV9aMJLuqnoQjQ4msKYpXn16Hk3Mi+k4X8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1ewD/KOBn7rYEiH7OIA58Sn2G/bJfHpRao8sElE588U=; b=eiKXegrNYFV6xx1unywQpNUukr/4ugQoTTLlZjirMOT64mUzdjlt5QnkM+o9dvb05pia7uytotxi7+av/4zFeL5dpFDI9tphDTPkP/NsdlW/8IX+uTrPLdNtj1mjnHG1KZBHEdEkeHZkpAZQjDiGnkayeOWP6wuDBYnGNzgiqjoCmBi84bqoYg05NDh2zwBBk6zeMlLap4vdUF27gMQHojrlHK+QzN/HJTiYc/cWVooIC/7vmLGJwAOUTJ82/z4xqe+v2VspPouZOQV6jZnAUVPKd2JZ+dRHcMUCm3S/VQeh88oF/SgcXxeMbNfUI5r31CLBu+E8c0M2Q3YYbWYUag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL1PR11MB5222.namprd11.prod.outlook.com (2603:10b6:208:313::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Wed, 9 Feb 2022 19:07:27 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:07:27 +0000 Message-ID: Date: Wed, 9 Feb 2022 19:07:22 +0000 Content-Language: en-US To: Jiawen Wu , CC: References: <20220209104213.602728-1-jiawenwu@trustnetic.com> <20220209104213.602728-11-jiawenwu@trustnetic.com> From: Ferruh Yigit Subject: Re: [PATCH v2 10/12] net/txgbe: fix debug log X-User: ferruhy In-Reply-To: <20220209104213.602728-11-jiawenwu@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0034.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::8) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 01c4a2a8-2a3e-44a4-2359-08d9ebff69b5 X-MS-TrafficTypeDiagnostic: BL1PR11MB5222:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:51; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dC9Av4RBedfSaCtV2STkvBvexorVHN4ccOTdXMIXMkICXaSyMZWVmLtxuBJmosmvYjc+wZSIv9q2EXoERIk/JNykWIi7muSDm0x8tIp3RMXs9RBEptlDEJiDrDvOIdWE7/2Oq2z0UQ5MtJxHUD5UDSQ3H0oqLsZgei4Hg86789XySliz1VfG3o5upnNCHpeoJt5XImpRNo+zhzbR0C3JyDP9xq7NiexExnw4lTQPbN1h+D6XBAUvdYILrK/hF2rp/mR+Q57wrUju7JyEV8HEPZk7rdIEwUF+4YKhAX40Is10SEBVjh9VbDjR02P+7fDy1mJIp9fY1bH24QVDqpkXVnqxOrTcWkzyX4eO++PuEfQiO7v5GpirMf5Rsia9dAIeX/fyKXr7H7A8ULvIOIec/QGXdTFC54dnggsO639I+k1x4Qmtlt6EqUaz7AeqdTdj11SxVlPhPlj29DWE4uSfEK1zhMVVo3Id2hkkG06AKZduiFUpSJ4HVXyaJu44D3nXM9QaGv619tboOewyfFlOoJutKZiYJN2uTJDMrIMSvUlsJ+5X+xHXX17il2Fi+/+NkpldKXm41ts+kqy0al0ynXwHyoa6vyhOcYCgL/j1XUfXgLkXFFzSdfHdH69+CL+7rU0xBE4IhA7rCClpUIGYax2+8FEQGSrOmq6+0Pr/AbQAwzqWol5hAY/qMp6PiXx8N9iXFzTTOzEW1PtmZmIatA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(66556008)(55236004)(6512007)(6666004)(82960400001)(66476007)(186003)(2616005)(38100700002)(316002)(6506007)(53546011)(8676002)(6486002)(83380400001)(508600001)(31696002)(2906002)(66946007)(26005)(31686004)(36756003)(44832011)(4326008)(8936002)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODN4Zm1GSmtNRVl3K245dmlWMGJFSjBEbFVmODlKSHhZZWlTVFR0Z3NScE1p?= =?utf-8?B?ZDFQNUdYY1FDSW5PdjFRL05GME9Ua2xYaWNNaVc5Y29ZYjZqcWV0SjdhUis1?= =?utf-8?B?cG1wTVRqMDlxeGJBR3J6MWFBZHFtRWQ4c3dObDRSSkdFLzJjTkhVTTFJR1pu?= =?utf-8?B?aVBJVjBLVDZCRjJMdWNkN3FJRzhLbzA5dDNoc1plNmZKLzRXdVFtVnp1amIy?= =?utf-8?B?VUhoZjZCMkRvUEJ5OTVCNG8wK0kvMFhBZXhJMFdadmtzMXdGSk5ROElsVW1L?= =?utf-8?B?Z2JyVDBlcjdidkYvVFJmcFg3bHVBV28rdVpRZTFXQVg4RkV6MmsraWFncU1q?= =?utf-8?B?U0h2NDk1bzQ1SVo4dkRySHFKNFJtdTI0enV5WkZqdGZZaENERUorUTZJemVR?= =?utf-8?B?K1hkamJlSWtoVUNod1BPeGVKZnBYNjk2ZHN5b2pqUGpWOXJhZEltNmNOTFU2?= =?utf-8?B?c1lvOG9FVE9xOGJMd0c5YnBaSFJuWmdEVDgzQ0FVekFZQUtxVy9QRFVCYXBK?= =?utf-8?B?TVFBV1I0UWF2TG0xZE12MjQ1VVk1WkNoa09sWENRYjhGbUhZNlBRSU5iN2VC?= =?utf-8?B?bHdpcE82SHdRWmFvL0dhZEJVdWtYbGZ6R09JQlBUNGlQSXRTZ0FWZzljWVA5?= =?utf-8?B?SVpJd1BpQ1lFY0FaUUp3N2NrMzR3dzRtRmxLZi9ZeGd5ZzZYZy9SVTZmZnBN?= =?utf-8?B?MG5BazJHR3hoVGp1TjJ2SEJEVEFaSVZrckhOY0F2eWYzUTJIK3U3bldxZS8z?= =?utf-8?B?UnA3OWppV2hRODltTU9wZWZwdkhiQlNQQ3RYYWVTaHJGdDNzV3MxajRMVDRo?= =?utf-8?B?WFRzTWdZTmhMTkRtNWxHODBXWUxTZ3ZjZTM3bmd2eHZKSTQ2V2tEUDdFWkhC?= =?utf-8?B?YzN4YmVZeTkvMHFFTlhPWkpmTUJLaVRLVlIySlZKTU5vR0NUSjVPSXVkSnFk?= =?utf-8?B?TytvTFhMMVlPdnFDZHNPV2xNODFoa09zaDU1TmdUM1lvM3o5WlVmc3FoODRH?= =?utf-8?B?T0FRcFF0RzBFb011VDdNL1QyM1ZpazJxRzFTRm9SQ0FrNlhyWkFSTUNBQllW?= =?utf-8?B?TzluRjdsMjJSMWFBb3BBNWJLNHNKaDhpNDJITGFCaTRjZUtjOW9xREJIZnY1?= =?utf-8?B?dGdYR2k0YW02Q002czNvTXV3MmlwcmMrd3RqU0R4VCs1WlpoMnZSMHlFVVJM?= =?utf-8?B?RkFwWnJKV1ZFLzdyTUFGYW9tSENwZ25sT2l3MDhKV3dNOWN3U1U1ZDZOSHor?= =?utf-8?B?M0dib3dYSjRTUzUzd1JUd3B5Uk0vNEdPZWREeW8rOXFYODAyU2Jjc05nOHRO?= =?utf-8?B?L2lsM2JtMnl4aWk5ZUt2aGtJcURvV3BrMHErRVRnRnZNaGJ3bE1Gby9qMUF0?= =?utf-8?B?aERadWFBQkx5TjNnMStIOHJyOEFqZW4wMjFmUDVEWW5ITzVOcVdsUlJYanc2?= =?utf-8?B?dUdXblpScHFBdmZZc205aUhDYUN5eWNPTnRyYXBLMU5MeHd3SzF3RkZZbFVG?= =?utf-8?B?cHlhOUl3Ym1Ma0ZVODlyWWxjeGQ4bXhKWTNsSHllVUVFbFl6Q2pkcGxQNXgy?= =?utf-8?B?SnRjckt4ajF0Zk1XcUN2UUwzSjlGbTl1YWFWT0E4dWQyRmdDWmtLYk1HNThO?= =?utf-8?B?bG5WaGNKdDdQQXg0QjFjaFB6N3lidmV3NlQ5VVhKL1RFakdza1h3bzhSaUto?= =?utf-8?B?SjZPSVA0VEVpR1lydjlpYXlxNGpoektxTUowOUo2SUVNLzZLbHRSaWZaaTJB?= =?utf-8?B?cit6YjlWSlBJbWFvVjdkWXk2RkdRd3Q4Tk9oOGQySy9qaXU5VzBzSGs3eGgv?= =?utf-8?B?SnRicWZTUWJrSDhUV3JxSkFLRzVYM1RWN2luQlpLSDhqdTIzVU8wT3Y4em9z?= =?utf-8?B?SzNsQ1F5b2haUjAyVFZPMUgxVmVJY0NYRERmVi9NMnBaTk5qZ3lhblVXbHlo?= =?utf-8?B?VHV3QytqU3RzZTZEb3dpSjlTU3RKTG5aRWNKR2dPTzJhV2VOc2xvSnNvaDZ6?= =?utf-8?B?N2g0bXQ2UDV4clJJRDVRZHMwSGh4eEJvY2xNU3VZZDNvYTdhMW5vcVpsQU11?= =?utf-8?B?SHF4VVU4R3IyTGkvQkhQTW9aK1A3Z3YvWEc4RkQwZjlIWFFTcWVQOGJONkJV?= =?utf-8?B?OEJWVDhTR1NJUXI1aHZkSDlZT3Z1Tlh6QSt6ZnZXQ0RnUWQ4bFozWGxYaCtW?= =?utf-8?Q?SkzrBCwBts8wjBgs1mZApro=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 01c4a2a8-2a3e-44a4-2359-08d9ebff69b5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:07:27.4333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lfLqd6b8jrY4jKjkLkxcMF+HcQeGSFyPUvchKyZdhi7NHog9ZI0PCoiqZTLSH6wS0GKw2BQa9o9xHl31bvbryQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5222 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2022 10:42 AM, Jiawen Wu wrote: > Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix > that double line was added by using 'DEBUGOUT'. > > Fixes: 7dc117068a7c ("net/txgbe: support probe and remove") > Cc: stable@dpdk.org > > Signed-off-by: Jiawen Wu Comments to ngbe patch (8/12) applies here too. > --- > drivers/net/txgbe/txgbe_logs.h | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/txgbe/txgbe_logs.h b/drivers/net/txgbe/txgbe_logs.h > index 67e9bfb3af..8fa80a69b2 100644 > --- a/drivers/net/txgbe/txgbe_logs.h > +++ b/drivers/net/txgbe/txgbe_logs.h > @@ -17,10 +17,13 @@ extern int txgbe_logtype_init; > "%s(): " fmt "\n", __func__, ##args) > > extern int txgbe_logtype_driver; > -#define PMD_DRV_LOG(level, fmt, args...) \ > +#define PMD_TLOG_DRIVER(level, fmt, args...) \ > rte_log(RTE_LOG_ ## level, txgbe_logtype_driver, \ > "%s(): " fmt "\n", __func__, ##args) > > +#define PMD_DRV_LOG(level, fmt, args...) \ > + PMD_TLOG_DRIVER(level, fmt "\n", ## args) > + > #ifdef RTE_LIBRTE_TXGBE_DEBUG_RX > extern int txgbe_logtype_rx; > #define PMD_RX_LOG(level, fmt, args...) \ > @@ -48,11 +51,11 @@ extern int txgbe_logtype_tx_free; > #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0) > #endif > > -#define TLOG_DEBUG(fmt, args...) PMD_DRV_LOG(DEBUG, fmt, ##args) > +#define TLOG_DEBUG(fmt, args...) PMD_TLOG_DRIVER(DEBUG, fmt, ##args) > > #define DEBUGOUT(fmt, args...) TLOG_DEBUG(fmt, ##args) > #define PMD_INIT_FUNC_TRACE() TLOG_DEBUG(" >>") > -#define DEBUGFUNC(fmt) TLOG_DEBUG(fmt) > +#define DEBUGFUNC(fmt) do { } while (0) > > extern int txgbe_logtype_bp; > #define BP_LOG(fmt, args...) \