From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AA8143CA0; Wed, 13 Mar 2024 16:59:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A97F42E57; Wed, 13 Mar 2024 16:58:57 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2078.outbound.protection.outlook.com [40.107.223.78]) by mails.dpdk.org (Postfix) with ESMTP id 47B3E42E52 for ; Wed, 13 Mar 2024 16:58:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LFdZAQyGZrYV+GfIu/+NSVtwMd305R3nKs3odTI+GhTSubcRqoNXA9QmHNE+4thUnz9XbaezKCA2oQBbjtoAhpFCA8fe35uEVRTO/5gm+r9jRMS52h3XexgZfesL5Mb7kTu/Do5a90DRVYuGtokma2zFEeADC7rmM0L7DPrFLawfW3Sij2OiqclLFYuwxXi3GLp5vlWbaccF9v4tOjMK3J7d5yUKgCBKNVNhepor42Zo5x9Bmo3K59zeHoETS61uZRrM9B5eg77UwZ1rCAJifRkBscdWSY/lA4phKThVCxV26947pX9xmOZ1VRTZ7Mf9aU0F9aw35nmbgLh3pr7wFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LQtdrYqqXotv8C6A4ttv1MxLEaCRvr/DVxDDJtoeLHA=; b=MAgubfz4nL8ee+/rAbvyqt4U4vbxcga6Kug/Daicojzz/jAi6R6oVY2BTgE3ouQGwYF1zJkRP/V7PNS7y/YQMlKZOWnyD8UbIVLMO00BIEpSziYN49NHqgde4u0cnuBLjSvJ8s13aXmakkC/ybWjX3igP7sMQr/8iAdU1+q9OxrqP9NdwTMH01ILS4+S6YCubXhYruTasa4IhC8PmUmTmtAm6ceSXXnTEPIfp1f63TmArnurLGKz3+g0DVZd2TdPy/KBFafHtd3UvJrxPWVZhxwzVKkjS9JaCixZtL4x9zgZQkhJiJ/yOPHOdmFlOsrquQk/UlqYu+r1Gs8lZhy1YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LQtdrYqqXotv8C6A4ttv1MxLEaCRvr/DVxDDJtoeLHA=; b=LREInEs3uafDBN2A1eCJiFNAn4Lh+RGcH+T6jBC6wHcadzz0UMb55hiNaKDXPagetfIOb/1Jd8bq6/Jfm3dm9+lQuf7+/Q/ixpfhNUz7zieHOUZGI2vnsuFwXJV7D/j/Os6tg35bmTMzGTGACYqoIDYIWzRcROwnQ4sgG84WqYc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB9125.namprd12.prod.outlook.com (2603:10b6:510:2f4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Wed, 13 Mar 2024 15:58:53 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 15:58:53 +0000 Message-ID: Date: Wed, 13 Mar 2024 15:58:52 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 07/31] net/ena/base: limit exponential backoff exp Content-Language: en-US To: shaibran@amazon.com Cc: dev@dpdk.org References: <20240312180716.8515-1-shaibran@amazon.com> <20240312180716.8515-8-shaibran@amazon.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240312180716.8515-8-shaibran@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0054.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB9125:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a132b3c-4da3-449e-b13c-08dc43767b50 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6yVwg5ZF9qdW1bNYlDEaK2NuKYLUFSMevcAi0TRgBt1VZD5/E8s/NGZ0A8300c3Xt1YpEl0bFJmR9XP19fhlMmxdR/9UVuyzBYxfg17Zr82YKIley4gsIGSowsbeR+MeaFb7ziwDAHsGdUMSjnXvmhQ4ckSpAnPO16KnAq6cgpIu0R9z1UbPcnAwQsnpGY8NuDgN2lPVMI3JvDcnpSaSQSwp/ejb9Y65f7thQ1uFR7mjvdFXoltcuh6RM6YOQkdO0jOUT6MVu8hfT/KHDBBaGpgI/hTt4QaMFF17HyVMzfi1I2JgM78W+//kmCMs9g56z96L/5G5kp7dlImXylAo0CSemZADS4+HxmJDZyW0/BhyE/QSmfXxAmnJOM8xfu3ama9TqGSNeOTcvmD0h/jMzzmGnVIqgCDhTSIJujGlffaVokxGbYjgkEWqdny7pVfDVS0JuAzUANponU/B0ucRXbk5sZp5JJlA4vDvSWiXooJfQVUUJzjBOgI28lSZR8Rl3BywVOeaTnWPdpw//lBtO6glaU64KmoYOGhc0VsXRkYCUT5d0OYwJEfwxiPBFpzpKhIeE64zqeOdW2VCzuLkq44PcPK8LyaRldO+jqk8OtXhp+tSeVN3NM7AH+2U/iG3fH3ekCwwClGJwOYoYuwW/tW06YQ6AIYUJHgqsjeshNQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHR2QXNoWm5mM1AvOUcydEpGZkY5UGUrdG1LRzNXSnMwV21tSGxvTlFPWjR2?= =?utf-8?B?QXpqZ1pYcitaZW5uZkVaZmlzc2JDZlNFU3hnaEtvUzRzWmxPeU5rVzZ2MzU0?= =?utf-8?B?Q2tveTRyV1RQTWxIdndiMFI1Tit2TUVMMzVMTTIxcTJ2cGIweEZ5Rk9UK1hi?= =?utf-8?B?VVlSaVZpYjN2L2NBY3lWb2lmcTFYbUhmWCtxNkl3UDhEaTRRNjFLcWJlQ1ow?= =?utf-8?B?OGRiWGRQYzFXSmljbDRuRDFnOUV3SlR4NXk3aFN5MUE3aWwwUVJEL0ErWUVw?= =?utf-8?B?S2ZFa3JlS0NjQ1VFQ2RnQmF6bzU0OFEwSTZ3WW16UDFIQjMycVp0b1BjdllH?= =?utf-8?B?d1NPY3Q2ZUJ3RWROSWQ2ZjJnamRpdXBSazV4SDMrYXRuZWJOUUZFSXZuMWY4?= =?utf-8?B?Sy9uenlzellZNUhscmUyKzdBTU1udlV2N2RTYlYrNk4zL0FiVzd5dmNEbFRr?= =?utf-8?B?ZlJ1N25Rb254TVc4S0J6VFgyd2RGS043QzdRc0VLT3dVMElxOVpQcXJFb290?= =?utf-8?B?NGtBL1JkeWdubHNhYTRYNmhRRmsrUzRFL05FWW1ETDNOS3h3Y2Q3YTNndTZX?= =?utf-8?B?cjg0c1lRaFYzcmhYZWtzRXZpVnF5bEZTSUpjZmordGxteTgxY3dNWWxlN0Vs?= =?utf-8?B?K2JxNlo1Wm5lUDhtTFlNcXFIK0txbDl4cXNpSnBKem1lZlBLaWxnUUNtcnN5?= =?utf-8?B?RW9iM1VRU1VJL21yWGJnV1NGd2xGOUdCVXNMVm9pK0dqaCtkQ1hWb1V6MU9P?= =?utf-8?B?RnZHLzZxZDZYMk1nWlVjbUFqYnp4aUFaazdDNi9MNHQrcEdMdVN3c1hzU0hI?= =?utf-8?B?d0lwQzRyVG40aTBrODM3R2QxZVhwOHJ6ZTEycUhLRVZMNmZxTkp5TUlnUTZH?= =?utf-8?B?b3RMeU5tWUVsTXN2NEVNd1p6aWpCZklkMFpHZjBHdDlUVGN2WThCak8wdVJa?= =?utf-8?B?Y3MycFBuQkxuY0xiNlNDaVFML29IYmt2UThGMTM2OVFoMUFnNlhza1VGKzRY?= =?utf-8?B?YkYzQzRSZjd6WWZaSklmMzluUlk2L08wY3pKNjVhYjVpcFhOZ3BvOENKQUZr?= =?utf-8?B?SXJwQUgwWjZjSVhkK290cEZNSTg0YTY1NU53ZXBISjFYSkdSeWlmVm5KUDFQ?= =?utf-8?B?WnErcTlnYkpqenBXSGtIbHdpN0xYUkFlOWM3YTU3eDRBaThwRjZUUmZwYmxx?= =?utf-8?B?bE5YQmJPV1VnSlVUUjBQK00xcy9BbnUzeENPNFNkSzVMYzYwRUplY2FwZnhp?= =?utf-8?B?dzUyZllvTXgxMUJHNHJYc1pxMlFYUEdkaTdaWDhCcm5TRFRHNTFTdzhuQmpu?= =?utf-8?B?VnV6dEs3THdOMHV5ODRRdEd3U3Ntbk9PVWdGUHBFMkVRRWwrNXBnc3V5TU5m?= =?utf-8?B?dmNzV1hrbTRWZnp3Y25LdGpvMWRUdE9nY1htQmR0aWI0MUJzcEZ4dnJ5TnAx?= =?utf-8?B?KzBKYTc5OGkvcWRlQysvOHhzL1JaT21tSGJyMWszNTRZRFBFR1pPMjVjWE1N?= =?utf-8?B?V2M2NENqVG5hbjh0V3E0a0JBZVh4VGV1RjAvdjZteklHbGhqWXhrQis0L09S?= =?utf-8?B?V1J2bm9WNVBvLzFRa2NBc01TRk1CT1lTRmpHZWk0aC9MZEVoQW9iVEQxUGlU?= =?utf-8?B?MUsrclBiOHRkSXBVTlBhOEhGcm9sd1hkU05NWjg0T3VEUnNmNWpPNTRhZGFB?= =?utf-8?B?ZDJCK2dqRXpteFNtZXowRXd3SURwU1RYaW9CTG5iYWR0LzFpVVF4M0ZpNzZV?= =?utf-8?B?UVFBeFErQ01Cc2F0Vm50VVgvNXNPSWRaL1hxNmZEditxMWhHMjBQN2dBYlcx?= =?utf-8?B?c3NzQ1FRUTFyZ3lxcXhnTkQ2WGIrY21KSVpKdEVPalFlNGNJT3Jxd0RCTWlR?= =?utf-8?B?cjVuVEU0SDNYSlBiYWsyYmxNUm5zRmZyQzAzZ2U2VGc5Z3YwRmxZN2swNTN1?= =?utf-8?B?MlRmcHhQaTlmUFN2c2J4TGlNbUZyRVBXVWh1elErWDdKRm9JSUo1cFV6S1dG?= =?utf-8?B?Z09FNld3YzlsRUx1ZEluMWpudU92b1U2R0w5T1ltOUVRSWJscXVyOHlBbksw?= =?utf-8?B?R2VpQWNjU3k0dFY4eWU4SXVseFJjWlRSeHh1WDRjZUdwbE1pRnI2N3B0MTdY?= =?utf-8?Q?XqDj/5jQRitC5morEr0L3Ab5I?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a132b3c-4da3-449e-b13c-08dc43767b50 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 15:58:53.6369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZbOTPkiHr8wdj62MORNXpl2v5Wn9JuxNi/O55rMwOR3GaxMV9hLSgdjC/A6KM019 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9125 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/12/2024 6:06 PM, shaibran@amazon.com wrote: > From: Shai Brandes > > Limit the value of the exponent used for this backoff > at (1<<16) to prevent it from reaching to an excessive > value (1<<32) or potentially even overflowing. > In addition, for uniformity and readability purposes, > the min/max parameter in the calls of ENA_MIN32 and > ENA_MAX32 macros was changed to be first. > > Signed-off-by: Shai Brandes > Reviewed-by: Amit Bernstein > Fixes: 0c84e04824db ("net/ena/base: make delay exponential in polling functions") Cc: stable@dpdk.org