From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id E727A42EC8;
Thu, 20 Jul 2023 09:45:48 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7D1E140E2D;
Thu, 20 Jul 2023 09:45:48 +0200 (CEST)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam12on2081.outbound.protection.outlook.com [40.107.243.81])
by mails.dpdk.org (Postfix) with ESMTP id 9E31940DF5
for <dev@dpdk.org>; Thu, 20 Jul 2023 09:45:46 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=GaHdEqWri/LxUKdmF4pE5oYlzGKilogT8o+7VbPOp92PZfvwTb3Tymcy4WIzGHODdzdbJRsuKXRfI1ilfNWHiuaJL+wrK5ttzFL1+5kwZnXkb+YoyaneByz+41njl8noWJ+csa+fUg/Z1tA7oVRHXdBjTe2NIvePtiD/4sA0+osmap+A5tDjif5RNGXtax5ZoCUo1glRt5pVqYJfo4RRsZPWwKryXWXZxFGHm5czRhvPwJbKL4tOOdYT/2N7TO4Vk4McJuqOWJd00votN/7M+uIJDB+a7/XnFOJK/vq7Hs/8iGNKVUgnWd83qUp0+V9VGFRLepRh/SsBZFdjcMXsrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=QzLA3U1srOb6h0uPEwnZR7+tcgx5Be1tFkody1iRig4=;
b=dB2g0gRhghTe/qBfpd/I580tfd/V6aZTQiZRid3CO/G7tXq6U7/remtckkr9NTaHCwN8rOItnyj6bqgbOEXHSxxlHHqa0vBeY11rhRzvHAxDfA52JbwOGUqHpGmh6hNVxwIam2/q7ZWfV6MNK8RW5qSc7qMp8KfULhY6T4STVahFteXhRKG6x4Bf/5mU1G4zkrQCCmunIkhJzFlP4HpsMTW+wSlqvPqh7Y009avbANuaDx/T22aZC+y8rgu4XpXZL1VHUMgDHuNACGW6pMbOTUO2iFoSyJZCRJbs4ibk6ioICrVtmG8gkjLr1Q+MxEee8zbsLDQp0YgnnBZSzTy8qQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=QzLA3U1srOb6h0uPEwnZR7+tcgx5Be1tFkody1iRig4=;
b=vEhlokA9K9Ji0zTfZbbiu6nPb0z8yvH/s4MQAI9ZOM//NAZP+x409V8wO7DA7AL8pJPNCBVYkF1pYymiscTGQLr4tqdJknaj0MJqBcPea4Uul6NzrBRPwEQBI/4e4NzEjK2SnCoUnL5NVXgGBk4bk8+erFvAoAHm8CGObxw/nF8=
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=amd.com;
Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11)
by SN7PR12MB7346.namprd12.prod.outlook.com (2603:10b6:806:299::16)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.25; Thu, 20 Jul
2023 07:45:44 +0000
Received: from CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::15a9:4e83:4217:8b49]) by CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::15a9:4e83:4217:8b49%7]) with mapi id 15.20.6588.031; Thu, 20 Jul 2023
07:45:44 +0000
Message-ID: <b383533c-1ce4-c65d-a3a8-f7ae4bd32f6d@amd.com>
Date: Thu, 20 Jul 2023 08:45:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
Thunderbird/102.13.0
Subject: Re: [PATCH] tap: fix build of tap_bpf_program
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ophir Munk <ophirmu@nvidia.com>, dev@dpdk.org,
Thomas Monjalon <thomas@monjalon.net>, Aaron Conole <aconole@redhat.com>,
dpdklab <dpdklab@iol.unh.edu>, David Marchand <david.marchand@redhat.com>
References: <20230717191548.16429-1-stephen@networkplumber.org>
<3d8938a4-acb8-45d0-291b-133ba0157976@amd.com>
<75eef8f8-c0c0-1950-6149-756bd624e9d6@amd.com>
<20230719091249.0ea91a4e@hermes.local>
Content-Language: en-US
From: Ferruh Yigit <ferruh.yigit@amd.com>
In-Reply-To: <20230719091249.0ea91a4e@hermes.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO4P123CA0440.GBRP123.PROD.OUTLOOK.COM
(2603:10a6:600:1a9::13) To CH2PR12MB4294.namprd12.prod.outlook.com
(2603:10b6:610:a9::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7346:EE_
X-MS-Office365-Filtering-Correlation-Id: 92e877f3-05d3-4f3d-854e-08db88f552a6
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8cxDnZXzd/niX2pYJb4SObc2FZOoegoMuntS3sdmpJ9f64w4axU0t+/C6+MnLLxMxkGchdVnROTRchB1rAUNqStvZMeRmGRQv5BhjHjsmjSwBiUo0pWwsCuWmoqaWF7Q7Ha0/GLMZQk5RZOkWWc5drha5qZ2QgcmbTiJZKD3FvUZ6icquqixj+8UR9D/VnYYJSk/v83l2VHMVtPPRMJPLXzLZlKGKUJb20aA6GkwUN58lmOYE06m4OXW1759C3tGAUb+Tpj4vcYf+MsEyan5xSHhgHN6bbrptyg4GrBTUOXSa4emKyULxokFi50aiT8kAylO6pEJJ3qRfJNHU2XQ3GxaqC6lIBTH9i7CF4r9YkQfsbRXDz+fXRT49i7ZC+FCo9dPEBldrbNL6OwsIzGU1A3RFyIaAWe2xzY6dJXmXH+HpsUhjd4o/MIfGK0Et6SNj4rlvRaS4v8Pm9RphkJbHCfpRPgjDO1PHDMMgq2esVKz8Yw2V8aFNT9ozzTTGwY1p2HkzhkWKrX0/nEr8HWOr2JaFsIYDCXC4XU6/47b2Dtniz0Na/w+W90emAdIA6kAZqASjwKqLkAxluMJn8+J5Yi5gwDtJtviNujrJfcFHCavu/QkEulrifjECfZOGiKfulOvgoApcLfbU0+fIG7kNA==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230028)(4636009)(366004)(136003)(39860400002)(376002)(396003)(346002)(451199021)(41300700001)(53546011)(6506007)(186003)(26005)(478600001)(31686004)(316002)(4326008)(6916009)(66556008)(66476007)(66946007)(44832011)(8936002)(8676002)(5660300002)(54906003)(6666004)(6512007)(6486002)(2616005)(83380400001)(2906002)(38100700002)(36756003)(31696002)(86362001)(43740500002)(45980500001);
DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djhCbXpBN1pMVk0xL0diUC9iZnRDTTAxUS9XS3JqYzNYNVh5TE9HVHZWRnlJ?=
=?utf-8?B?UitTU1g2STNta3B3bWh1ZFdyNVRiTFJqQWkyN3FpQmg3NzJJMDlMK3N4MmxY?=
=?utf-8?B?TmhzaEFLV1IxREQyeStDWDNrdlhwWitYRi95MDU5M1g1OVZwSW9Pa0pyWUQ0?=
=?utf-8?B?NlQwYi92aG1BTkI5LzBveThyNi9NaDVPMUg5S3laWlc5dU9paCs3TGxHMENU?=
=?utf-8?B?OFVTbzM0aExUUlR3R01FT2g4azdPajBub0Rka0srSEQrRUd6c0Z5bVRINyt6?=
=?utf-8?B?WHFiUHVNK1owUWFRbDBIaWZwZGE2bGxGQTA2Y3AxU29PUWZzRlhpRGVaNDND?=
=?utf-8?B?dmhwMExqM0hzS1JVaDh5RUlJblJrRytqek1oSFA3ZTBUT1d6QkVvdzhHTmMr?=
=?utf-8?B?R0d4Ym81UXg5LzkxbG9YKzlBOWpSNEFucWYybXVRdGppQmVFWnJKWnlJcjc2?=
=?utf-8?B?cFloQzU2Q0xYUE4raTVibjI2VEN5Y2c5bW9ISnE3NENVVTJTakVTb3JHTGEy?=
=?utf-8?B?cExDeUJQUmRkUUlXcEY1NkpBMGxiVVN2YWdHZmppK3lCazZSbTVUelVlMWJa?=
=?utf-8?B?UThDZk9EYjVTZjVRZ0dPcVVma2Y4T0NKOEhSR3V1ZEdJQ0x0b3ZEN0hCdnlJ?=
=?utf-8?B?ZU9xOXpGNjhoNjRKRElkTFQ3NHo4L0oxTEZ3T2Z6MkU3bnNCZDBleWdhSDIw?=
=?utf-8?B?dng1eUd5VXIzWmpGWCtlQlNsYWFXa0J0TCtrR3VpTzhnQ2VwYnJDMVdHVUY1?=
=?utf-8?B?UjFZc3Y2N2hOd3dOSk9Mak16M3ZHVllGTDVBK0VBZ08rTGkwa0YzN2NqNGlh?=
=?utf-8?B?NmIzaUtlRFpZcDB4NURKWkQ2WHVnZEdxaGNieWdGV2Zpa0F5QzBTOFIvTGdy?=
=?utf-8?B?WXFkMk9UZ3lOWVRJOG9hT0tnVmNCaldiUFRIMzZwRVBDWHNyUXJQcS9HR1Zx?=
=?utf-8?B?bVdHQlZxdGlXdDZDZTlZTlVMTE9MM0VTTVdwY3dsRVg0MWZra2xyNGthS3JH?=
=?utf-8?B?UnR2NVYycTlrcDFnZDJ4QVNFL1VBWFUveGpXN0QzTkdWUTZaRzRrd3U1aExO?=
=?utf-8?B?TGhBR2JuR09pK2JjL21HcnNjU0RPSGhBRjNudWVBTEZONFpWcytLN3J5dnh6?=
=?utf-8?B?S1EySkpYMVNPSWVJbm5NR01sZGFKWFNzS3FJTjBxR2lPeXZEcUU3dTFpRGVV?=
=?utf-8?B?akN4N0N1Zm1ndjBmWEZCRGFpOGhuU2dCUGwvNGpsUEZ3RWx3RlpJR2l0UXZE?=
=?utf-8?B?UDgzb3NzVDY3QURiZDY1TlRqelBhMFl4WFVpSm9pQzRxcyttelZEN1JwYkE5?=
=?utf-8?B?UUdBS1dQTlVSZ2NtL0grRmM4cWRyYVpHYnVVay9UKzA3T1krcmZidExidGtq?=
=?utf-8?B?UHNhZjVlWnIrOVhXR2tzLyt1Q3h4VzZRaXQvcGRpWnVpMDQrMXEzUmpNalBw?=
=?utf-8?B?QjMzOHNuWkU1T0NPOHgvVGlwT1pGd3AyTHpPUC9heS9CbkV2YzM2MXFEVUJI?=
=?utf-8?B?M0JtTmNYOHF1WFdMeW5wTjg4QW1NcERQOXhiQWN1MnlSYTR6TVB0V25xVHZD?=
=?utf-8?B?eWd1b0g4T1F2aU1CbmhPZFRIY3BMWG5JSnIvcXkwcFkrWmt4Ukt5Qy9OOWFO?=
=?utf-8?B?eGtNb2IvWWtkNHFWUU9oVURsMDdzOUJPMy9XdGprU2lqVmNWMDNENXZUcjZa?=
=?utf-8?B?c2dTSkZZd0xSUlZ1SS9ka2ZQMkFkWTVlV1ZRcGo4SnBaSTIwSmF5T25hb0wv?=
=?utf-8?B?eWRjSldZMkF4TWFJMFRlV3BhamVOUmExQThJMFNrOHN4ZnR0d0tlZkRuRTRs?=
=?utf-8?B?d0ZqcDNrZmZKMFc5dWhDMW9YeUpWTTlxMVF4VTYxMDNqWGNzWXhBdmc3ZmpX?=
=?utf-8?B?WnRnMk9tMHRaU3lkTDUvVXN6MkMwcjd3NC9SajJuY3plOXFVTVpSWXRyUG5F?=
=?utf-8?B?ejVNSnU2SENPOGxFWXZEb3RtamJ0cldUUTFKSEZsNkpZb0JDV0ljTkxwNVAz?=
=?utf-8?B?UW1wdFowUnhIeUZaTVdwSGRiU3NiRlo2ZlRrby9VZk5LTjRNbHgvUyttU0xJ?=
=?utf-8?B?czFKQ2JSYzVYNVJVaXc0a2RsTG1wb1RJM1hHeHh6R0MvSWNiakQ2T3J1M05j?=
=?utf-8?Q?ZSek2M/oGLKRvzUe/ROo7WWU7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92e877f3-05d3-4f3d-854e-08db88f552a6
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 07:45:44.0375 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +qnOubWyBFZQxQ057TpqMpxdgZsdzLYw6lXwQnnzJacBDmFH0ppHsix4qs+hrruT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7346
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 7/19/2023 5:12 PM, Stephen Hemminger wrote:
> On Wed, 19 Jul 2023 11:03:36 +0100
> Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
>> On 7/19/2023 11:00 AM, Ferruh Yigit wrote:
>>> On 7/17/2023 8:15 PM, Stephen Hemminger wrote:
>>>> The tap_bpf_program.c is not built as part of normal DPDK
>>>> EAL environment. It is intended to be built standalone
>>>> and does not use rte_common.h.
>>>>
>>>> This reverts the related change from
>>>> commit ef5baf3486e0 ("replace packed attributes")
>>>>
>>>> Note: this patch will cause expected warnings from checkpatch
>>>> because the code involved is not used directly in DPDK environment.
>>>>
>>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>>>
>>>
>>> Agree, this seems done by mistake as part of batch update,
>>>
>>> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
>>>
>>>
>>> But I can't update the bpf file at all, if I am not missing something I
>>
>> * I can't *compile* the bpf file ...
>>
>>> am not sure if we should get just this update or have a patch/patchset
>>> that fixes the build.
>>>
>>> @Ophir, how the bpf file is compiled? And did you test it recently?
>>>
>>> I am using command from the documentation:
>>> `clang -O2 -emit-llvm -c tap_bpf_program.c -o - | llc -march=bpf
>>> -filetype=obj -o tap_bpf_program.o`
>
> It looks like this won't work because it was expecting to be able
> to find header files from older version of iproute2. These are not
> distributed, and the change to support libbpf in iproute2 makes the
> current versions not work.
>
> As a stopgap, will look back in history and see what version of header
> files will at least get a working build.
>
> From there, need to replace how the conversion of .o to array works.
> Would prefer to use dlopen() to read the ELF file rather than expecting
> developers to hack together their own tools.
>
> Not sure how much effort is really needed here. This is only being
> used for the case of rte_flow with multiq RSS. Probably, no one ever
> used it.
>
Should we remove the file, instead of fixing '__rte_packed'?