From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 598B4A034F;
	Mon, 22 Mar 2021 10:01:24 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D60AF40040;
	Mon, 22 Mar 2021 10:01:23 +0100 (CET)
Received: from dal3relay72.mxroute.com (dal3relay72.mxroute.com [64.40.27.72])
 by mails.dpdk.org (Postfix) with ESMTP id 3BA424003D
 for <dev@dpdk.org>; Mon, 22 Mar 2021 10:01:22 +0100 (CET)
Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com)
 (Authenticated sender: mN4UYu2MZsgR)
 by dal3relay72.mxroute.com (ZoneMTA) with ESMTPSA id 178592ac56d000362f.003
 for <dev@dpdk.org>
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256);
 Mon, 22 Mar 2021 09:01:18 +0000
X-Zone-Loop: 236cf769dcdddc3b1356cc9ab59458dfb5a8d11f3de7
X-Originating-IP: [149.28.56.236]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; 
 s=x;
 h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:
 Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=k10z9Cw0xQ728qm65EtZoFolGWDiyTZU2kZoeHrq2rs=; b=dxNyvo1lqc1SKsXUdlO5Ue2xPV
 NQVtoY2jm12envRuQGfTzQaV2r/8vIhPMXYbGY6hr5L3h/+853j+Wwkbemu3k9+20GEfCv4uZLxmS
 hPSAQfLzlUjJiEy4JWArgaE+s1dhTpxUAOKZ0vm9FjB36y2Gy4CVDQ3cOgStZaQlA5y4TSjuKWlJZ
 Hk4X6b3Lod7j3mgEmvD0NdGSumJdVQHbJw+fqsruUM/H9nu7I5zWs07V2/ee0Ueb3gsO34bUsQwKU
 E1+clz9SnfkJnbq6dEpQLPdp/vlED6Iybl2N9V54xsIIj5Q2P8gJJHidcrUu4jZjm/fG1lxGuSHQz
 31TLmkxg==;
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, ncopa@alpinelinux.org, stable@dpdk.org,
 Bruce Richardson <bruce.richardson@intel.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 David Marchand <david.marchand@redhat.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Haiyue Wang <haiyue.wang@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>
References: <20190313170657.16688-1-ncopa@alpinelinux.org>
 <20210319145730.3555384-3-thomas@monjalon.net>
 <139ba04c-4b63-9686-a123-3f3e1e23077b@ashroe.eu> <5446580.tqp9qgG6IV@thomas>
From: "Kinsella, Ray" <mdr@ashroe.eu>
Message-ID: <b384e5e3-b40f-4972-b845-6d1d5983d1a5@ashroe.eu>
Date: Mon, 22 Mar 2021 09:01:14 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <5446580.tqp9qgG6IV@thomas>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-AuthUser: mdr@ashroe.eu
Subject: Re: [dpdk-dev] [PATCH v7 02/17] buildtools: fix build with busybox
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 22/03/2021 08:55, Thomas Monjalon wrote:
> 22/03/2021 09:52, Kinsella, Ray:
>> On 19/03/2021 14:57, Thomas Monjalon wrote:
>>> --- a/buildtools/check-symbols.sh
>>> +++ b/buildtools/check-symbols.sh
>>> -DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump)
>>> +DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXXXXX)
>>
>> Does it make sense to change it to
>>
>> DUMPFILE=$(mktemp -t dpdk.${0##*/}.objdump.XXXXXX)
>>
>> So we can preserve what the file is in the filename?
> 
> Yes could be.
> There is already the name of the script in the temp filename,
> but I am OK to add more details.
> 
> If there is no other comment, I will change when applying.
> 
Nothing from me ...