From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "rmody@marvell.com" <rmody@marvell.com>,
"Pattan, Reshma" <reshma.pattan@intel.com>,
"shshaikh@marvell.com" <shshaikh@marvell.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"alejandro.lucero@netronome.com" <alejandro.lucero@netronome.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"Chaitanya Babu, TalluriX" <tallurix.chaitanya.babu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat
Date: Thu, 7 Feb 2019 11:56:30 +0000 [thread overview]
Message-ID: <b3966cf6-d8e6-b123-82c7-67787b7a119f@intel.com> (raw)
In-Reply-To: <7AE31235A30B41498D1C31348DC858BD5B5217F4@IRSMSX103.ger.corp.intel.com>
On 1/21/2019 10:43 AM, Parthasarathy, JananeeX M wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chaitanya Babu Talluri
>> Sent: Friday, January 18, 2019 8:54 PM
>> To: dev@dpdk.org
>> Cc: rmody@marvell.com; Pattan, Reshma <reshma.pattan@intel.com>;
>> shshaikh@marvell.com; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; alejandro.lucero@netronome.com; De Lara Guarch,
>> Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
>> <declan.doherty@intel.com>; Chaitanya Babu, TalluriX
>> <tallurix.chaitanya.babu@intel.com>; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat
>>
>> Strcat does not check the destination length and there might be chances of
>> string overflow so insted of strcat, strncat is used.
>>
>> Fixes: 540a211084 ("bnx2x: driver core")
>> Fixes: e163c18a15 ("net/i40e: update ptype and pctype info")
>> Fixes: ef28aa96e5 ("net/nfp: support multiprocess")
>> Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
<...>
>
> Any Review Please!!
>
cc'ed Bruce & Thomas.
What do you think getting strlcat() patch first and updating this patch to use
strlcat()?
Are we OK to get strlcat as the default API?
Thanks,
ferruh
next prev parent reply other threads:[~2019-02-07 11:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 6:04 [dpdk-dev] [PATCH] " Chaitanya Babu Talluri
2019-01-14 13:29 ` Ferruh Yigit
2019-01-14 16:24 ` Stephen Hemminger
2019-01-17 16:44 ` Thomas Monjalon
2019-01-14 14:21 ` Bruce Richardson
2019-01-15 1:53 ` Thomas Monjalon
2019-01-18 15:11 ` [dpdk-dev] [PATCH v2] " Chaitanya Babu Talluri
2019-01-18 15:23 ` Chaitanya Babu Talluri
2019-01-21 10:43 ` Parthasarathy, JananeeX M
2019-02-07 11:56 ` Ferruh Yigit [this message]
2019-02-07 12:08 ` Thomas Monjalon
2019-02-07 13:27 ` Bruce Richardson
2019-02-13 11:54 ` Ferruh Yigit
2019-02-27 6:02 ` [dpdk-dev] [PATCH v3] drivers: fix to replace strcat with strlcat Chaitanya Babu Talluri
2019-02-27 9:43 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-02-27 9:49 ` [dpdk-dev] " Bruce Richardson
2019-02-27 10:26 ` Pattan, Reshma
2019-03-05 13:14 ` [dpdk-dev] [PATCH v4] drivers: fix possible overflow with strcat Chaitanya Babu Talluri
2019-03-06 18:14 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-07 12:56 ` [dpdk-dev] [PATCH v5] " Chaitanya Babu Talluri
2019-03-13 18:39 ` Ferruh Yigit
2019-03-14 13:34 ` [dpdk-dev] [PATCH v6] drivers/net: " Chaitanya Babu Talluri
2019-03-14 13:34 ` Chaitanya Babu Talluri
2019-03-14 14:09 ` Pattan, Reshma
2019-03-14 14:09 ` Pattan, Reshma
2019-03-18 12:41 ` [dpdk-dev] [PATCH v7] drivers/net: fix possible overflow using strlcat Chaitanya Babu Talluri
2019-03-18 12:41 ` Chaitanya Babu Talluri
2019-03-20 20:18 ` Ferruh Yigit
2019-03-20 20:18 ` Ferruh Yigit
2019-03-22 7:51 ` [dpdk-dev] [PATCH v8] " Chaitanya Babu Talluri
2019-03-22 7:51 ` Chaitanya Babu Talluri
2019-03-22 8:02 ` [dpdk-dev] [EXT] " Shahed Shaikh
2019-03-22 8:02 ` Shahed Shaikh
2019-03-22 10:35 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-22 10:35 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3966cf6-d8e6-b123-82c7-67787b7a119f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=reshma.pattan@intel.com \
--cc=rmody@marvell.com \
--cc=shshaikh@marvell.com \
--cc=stable@dpdk.org \
--cc=tallurix.chaitanya.babu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).