From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA88CA0C45; Mon, 14 Jun 2021 18:47:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 584E84067E; Mon, 14 Jun 2021 18:47:41 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id A59FD4067A for ; Mon, 14 Jun 2021 18:47:39 +0200 (CEST) Received: from [192.168.1.71] (unknown [188.170.85.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E74E77F40D; Mon, 14 Jun 2021 19:47:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E74E77F40D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1623689259; bh=QvSGThhiHhXrsxmcABqlCfX9BEs5X9/MVB7ZJ8g+Tjw=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=nOlKDkkL1hJ+G13anNIRyOQwhayb3ILInM/LpQtBAF7QeWWFEUkrCJCggnbVGxe8i DD+HyWJCL83SYwsMaFCIiObB5dCqtXdOhWZhmSFzat6874Ss5z/CG1x9SPdkKW0fB8 Bl4Z8NUdN2HLTFd97n2CXzHVrzoVJsZHDaXgutKY= To: Bruce Richardson , Ferruh Yigit Cc: "Li, Xiaoyun" , "dev@dpdk.org" References: <20210527162452.1568351-1-andrew.rybchenko@oktetlabs.ru> <1f419fbb-b951-1a84-3329-97701c32c956@oktetlabs.ru> <87dd3fd0-9dab-8079-d135-50d966d6a5cd@intel.com> From: Andrew Rybchenko Message-ID: Date: Mon, 14 Jun 2021 19:47:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: send failure logs to stderr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/11/21 4:21 PM, Bruce Richardson wrote: > On Fri, Jun 11, 2021 at 11:35:59AM +0100, Ferruh Yigit wrote: >> On 6/11/2021 10:19 AM, Andrew Rybchenko wrote: >>> On 6/11/21 5:06 AM, Li, Xiaoyun wrote: >>>> Hi >>>> -----Original Message----- >>>> From: Andrew Rybchenko >>>> Sent: Friday, May 28, 2021 00:25 >>>> To: Li, Xiaoyun >>>> Cc: dev@dpdk.org >>>> Subject: [PATCH] app/testpmd: send failure logs to stderr >>>> >>>> Running with stdout suppressed or redirected for further processing is very confusing in the case of errors. >>>> >>>> Signed-off-by: Andrew Rybchenko >>>> --- >>>> >>>> This patch looks good to me. >>>> But what do you think about make it as a fix and backport to stable branches? >>>> Anyway works for me. >>> >>> I have no strong opinion on the topic. >>> >>> @Ferruh, what do you think? >>> >> >> Same here, no strong opinion. >> Sending errors to 'stderr' looks correct thing to do, but changing behavior in >> the LTS may cause some unexpected side affect, if it is scripted and testpmd >> output is parsed etc... For this possibility I would wait for the next LTS. >> > There are really 3 options, though: > * apply and backport > * apply now > * apply only to next LTS > > I would tend to support the middle option, because sending errors to stderr > is the right thing to do as you say, and I don't think we need to wait for > next LTS to make the change. However, since we don't want to change > behaviour in the older LTS's, I'd suggest not backporting. Many thanks for motivated point of view. I fully agree.